Skip to content

Commit 2fe64b1

Browse files
committed
playbooks: ansible-lint fix key-order
Fix key-order ansible-lint rule violations Fixed key-order rule violations across 3 file(s). Affected files: - playbooks/roles/bootlinux/tasks/main.yml - playbooks/roles/devconfig/tasks/check-apt-mirrors.yml - playbooks/roles/mmtests_compare/tasks/main.yml Applied using the ansible-lint-fix-rules.py script with --fix=key-order. Generated-by: Ansible Lint (ansible-lint-fix-rules.py) Signed-off-by: Daniel Gomez <[email protected]>
1 parent aad00e6 commit 2fe64b1

File tree

3 files changed

+19
-19
lines changed

3 files changed

+19
-19
lines changed

playbooks/roles/bootlinux/tasks/main.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,11 @@
126126

127127
- name: Debug kernel ref settings for 9P builds
128128
delegate_to: localhost
129+
when:
130+
- bootlinux_debug_ref|bool
131+
- bootlinux_9p|bool
132+
run_once: true
133+
129134
block:
130135
- name: Print kernel ref settings for 9P debug (localhost context)
131136
ansible.builtin.debug:
@@ -144,12 +149,11 @@
144149

145150
- name: End play gracefully for kernel ref debug
146151
ansible.builtin.meta: end_play
152+
- name: Debug kernel ref settings for non-9P builds
147153
when:
148154
- bootlinux_debug_ref|bool
149-
- bootlinux_9p|bool
150-
run_once: true
155+
- not bootlinux_9p|bool
151156

152-
- name: Debug kernel ref settings for non-9P builds
153157
block:
154158
- name: Print kernel ref settings for non-9P debug (per-node context)
155159
ansible.builtin.debug:
@@ -169,10 +173,6 @@
169173

170174
- name: End play gracefully for kernel ref debug
171175
ansible.builtin.meta: end_play
172-
when:
173-
- bootlinux_debug_ref|bool
174-
- not bootlinux_9p|bool
175-
176176
- name: Create data partition
177177
ansible.builtin.include_role:
178178
name: create_data_partition

playbooks/roles/devconfig/tasks/check-apt-mirrors.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,12 @@
107107
- hop1_mirror_host is defined
108108

109109
- name: Use hop1 mirror with DEB822 format for debian testing
110+
when:
111+
- has_hop1_mirror is defined
112+
- has_hop1_mirror | bool
113+
- hop1_mirror_connectivity is not failed
114+
- hop1_mirror_host is defined
115+
110116
block:
111117
- name: Backup current sources
112118
ansible.builtin.copy:
@@ -141,20 +147,14 @@
141147
cache_valid_time: 0
142148
become: true
143149

144-
- name: Inform user about hop1 mirror usage
145-
ansible.builtin.debug:
150+
- ansible.builtin.debug:
146151
msg: |
147152
Using local hop1 mirror with DEB822 format:
148153
Mirror: {{ hop1_mirror_host }}{{ hop1_mirror_path }}
149154
150155
This provides faster package downloads from your local mirror.
151156
Sources have been converted to modern DEB822 format.
152-
when:
153-
- has_hop1_mirror is defined
154-
- has_hop1_mirror | bool
155-
- hop1_mirror_connectivity is not failed
156-
- hop1_mirror_host is defined
157-
157+
name: Inform user about hop1 mirror usage
158158
- name: Fall back to official Debian mirrors if current mirror fails
159159
block:
160160
- name: Backup current sources (DEB822 format)

playbooks/roles/mmtests_compare/tasks/main.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@
138138
register: patch_results
139139

140140
- name: Get kernel versions from nodes
141+
tags: ["compare"]
141142
block:
142143
- name: Get baseline kernel version
143144
ansible.builtin.command: uname -r
@@ -153,7 +154,6 @@
153154
when:
154155
- groups['dev'] is defined
155156
- groups['dev'] | length > 0
156-
tags: ["compare"]
157157

158158
- name: Set node information facts
159159
ansible.builtin.set_fact:
@@ -274,6 +274,9 @@
274274

275275
- name: Generate performance graphs using gnuplot
276276
delegate_to: localhost
277+
run_once: true
278+
when: kdevops_baseline_and_dev|bool
279+
tags: ["compare", "graphs"]
277280
block:
278281
- name: Check for available iterations data
279282
ansible.builtin.find:
@@ -305,9 +308,6 @@
305308
failed_when: false
306309
environment:
307310
MMTESTS_AUTO_PACKAGE_INSTALL: never
308-
run_once: true
309-
when: kdevops_baseline_and_dev|bool
310-
tags: ["compare", "graphs"]
311311

312312
- name: Find generated graph files
313313
delegate_to: localhost

0 commit comments

Comments
 (0)