guestfs: bringup: fix ssh key injection

This ensures the user exists before any SSH operations and uses
the standardized virt-builder.j2 template for consistent image
customization.

The custom-image role now:
* Detects the control host's kdevops UID and preserves it in guests
* Uses virt-builder.j2 template for all customization commands
* Handles both system and non-system libvirt configurations
* Creates temporary command files and cleans them up properly

Fixes error:
sudo virt-sysprep -a
/var/lib/libvirt/images/kdevops/guestfs/debian13/root.raw \
--hostname debian13 --ssh-inject \
kdevops:file:/media/tarkir/dagomez/src/linux-kdevops/
kdevops/guestfs/debian13/ssh/id_ed25519.pub \
--timezone Etc/UTC
[   0.0] Examining the guest ...
[   2.2] Performing "abrt-data" ...
[   2.2] Performing "backup-files" ...
[   2.3] Performing "bash-history" ...
...
[   3.2] Performing "customize" ...
[   3.2] Setting a random seed
virt-sysprep: warning: random seed could not be set for this type of
guest
[   3.3] Setting the machine ID in /etc/machine-id
[   3.3] Setting the hostname: debian13
[   4.0] SSH key inject: kdevops
virt-sysprep: error: ssh-inject: the user kdevops does not exist on
the guest

If reporting bugs, run virt-sysprep with debugging enabled and include
the complete output:

  virt-sysprep -v -x [...]

Generated-by: Claude AI
Signed-off-by: Daniel Gomez <[email protected]>

Author: dkruces

playbooks/roles/base_image/tasks/custom-image.yml

@@ -85,6 +85,78 @@
         chdir: "{{ custom_image_dir }}"
       changed_when: false
 
+    - name: Get the UID of the kdevops user on the control host
+      ansible.builtin.command:
+        cmd: "id -u kdevops"
+      register: id_output
+      changed_when: false
+      failed_when: false
+      when:
+        - not sentinel_stat.stat.exists
+
+    - name: Set the kdevops UID for custom image
+      ansible.builtin.set_fact:
+        kdevops_uid: "-u {{ id_output.stdout }}"
+      when:
+        - not sentinel_stat.stat.exists
+        - id_output.rc == 0
+
+    - name: Set default kdevops UID for custom image if user doesn't exist
+      ansible.builtin.set_fact:
+        kdevops_uid: ""
+      when:
+        - not sentinel_stat.stat.exists
+        - id_output.rc != 0
+
+    - name: Create a temporary file for virt-customize commands
+      ansible.builtin.tempfile:
+        state: file
+      register: custom_command_file
+      when:
+        - not sentinel_stat.stat.exists
+
+    - name: Construct the virt-customize command file for custom image
+      ansible.builtin.template:
+        src: "{{ role_path }}/templates/virt-builder.j2"
+        dest: "{{ custom_command_file.path }}"
+        mode: "u=rw"
+      when:
+        - not sentinel_stat.stat.exists
+
+    - name: Customize the downloaded image with kdevops user and settings
+      become: true
+      become_method: ansible.builtin.sudo
+      ansible.builtin.command:
+        argv:
+          - "virt-customize"
+          - "-a"
+          - "{{ custom_image }}"
+          - "--commands-from-file"
+          - "{{ custom_command_file.path }}"
+      when:
+        - libvirt_uri_system|bool
+        - not sentinel_stat.stat.exists
+
+    - name: Customize the downloaded image with kdevops user and settings (non-root)
+      ansible.builtin.command:
+        argv:
+          - "virt-customize"
+          - "-a"
+          - "{{ custom_image }}"
+          - "--commands-from-file"
+          - "{{ custom_command_file.path }}"
+      when:
+        - not libvirt_uri_system|bool
+        - not sentinel_stat.stat.exists
+
+    - name: Clean up the virt-customize command file
+      ansible.builtin.file:
+        path: "{{ custom_command_file.path }}"
+        state: absent
+      when:
+        - custom_command_file.path is defined
+        - not sentinel_stat.stat.exists
+
     - name: Touch the custom image sentinel
       ansible.builtin.file:
         path: "{{ custom_image_ok }}"

playbooks/roles/guestfs/tasks/main.yml

@@ -31,6 +31,18 @@
     - bringup
   ansible.builtin.set_fact:
     base_image: "{{ storagedir }}/base_images/{{ virtbuilder_os_version }}.raw"
+  when:
+    - not guestfs_has_custom_raw_image|bool
+  delegate_to: localhost
+
+- name: Set the pathname of the custom OS base image
+  tags:
+    - base_image
+    - bringup
+  ansible.builtin.set_fact:
+    base_image: "{{ storagedir }}/custom_images/{{ virtbuilder_os_version }}/{{ virtbuilder_os_version }}.raw"
+  when:
+    - guestfs_has_custom_raw_image|bool
   delegate_to: localhost
 
 - name: Ensure the required base OS image exists