Revert "bringup: devconfig: fix python3-apt debian issue"

This reverts commit bcea53d

Reverting fixes [1] but we need to ensure APT packages are always
uptodate:

Commit bcea53d ("bringup: devconfig:
fix python3-apt debian issue") was originally added as a workaround for
a Debian python3-apt problem. However, in the Debian bug report thread
[2][3] was revealed that the real problem was:

"APT has a fluctuating ABI that
depends on which std:: symbols it calls, and which of those calls
the compiler inlines and omits the symbols for, so it can change
with every update to APT or the compiler."

To address the problem, we ensure that the distribution and especially
the apt packages, are always updated to the latest available versions.
This update is performed during bringup, when the image is first booted
(firstboot).

Additionally, a new firstconfig target has been added to upgrade the
system even if it has already booted with an outdated image.

[1]
https://github.com/linux-kdevops/linux-mm-kpd/actions/runs/13677761684/job/38242628757

[2]
https://lore.kernel.org/kdevops/[email protected]/T/#u

[3]
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095111

Reported-by: Luis Chamberlain <[email protected]>
Acked-by: Luis Chamberlain <[email protected]>
Signed-off-by: Daniel Gomez <[email protected]>

Author: dkruces

Makefile

@@ -95,6 +95,7 @@ LOCALHOST_SETUP_WORK :=
 ANSIBLE_EXTRA_ARGS += $(LOCAL_DEVELOPMENT_ARGS)
 
 include scripts/provision.Makefile
+include scripts/firstconfig.Makefile
 include scripts/systemd-timesync.Makefile
 include scripts/journal-server.Makefile
 include scripts/update_etc_hosts.Makefile

playbooks/roles/devconfig/tasks/install-deps/debian/main.yml

@@ -1,51 +1,10 @@
 ---
-- name: Update package lists
-  become: true
-  become_method: sudo
-  ansible.builtin.shell:
-    cmd: >
-      DEBIAN_FRONTEND=noninteractive apt
-      -o Acquire::Check-Valid-Until=false update
-  when:
-    - ansible_os_family == "Debian"
-    - ansible_distribution_release == "trixie"
-  tags: vars_simple
-  register: apt_update_result
-  retries: 5
-  delay: 10
-  until: apt_update_result.rc == 0
-
-- name: Install required packages
-  become: true
-  become_method: sudo
-  ansible.builtin.shell:
-    cmd: >
-      DEBIAN_FRONTEND=noninteractive apt install -y
-      python3-setuptools libapt-pkg-dev python3-pip git
-  when:
-    - ansible_os_family == "Debian"
-    - ansible_distribution_release == "trixie"
-  tags: vars_simple
-
-- name: Install python-apt from Git with pip3
-  become: true
-  become_method: sudo
-  ansible.builtin.shell:
-    cmd: >
-      pip3 install
-      git+https://salsa.debian.org/apt-team/[email protected]
-      --break-system-packages
-  when:
-    - ansible_os_family == "Debian"
-    - ansible_distribution_release == "trixie"
-  tags: vars_simple
-
-- name: Hold python3-apt package version
+- name: Upgrade Packages
   become: yes
-  ansible.builtin.command: apt-mark hold python3-apt
-  when:
-    - ansible_os_family == "Debian"
-  tags: vars_simple
+  become_method: sudo
+  ansible.builtin.apt:
+    upgrade: full
+  tags: firstconfig
 
 - name: Remove unattended-upgrades package
   become: yes

scripts/bringup_guestfs.sh

@@ -222,6 +222,7 @@ append-line /etc/network/interfaces.d/enp1s0:iface enp1s0 inet dhcp
 firstboot-command systemctl stop ssh
 firstboot-command DEBIAN_FRONTEND=noninteractive DEBCONF_NONINTERACTIVE_SEEN=true dpkg-reconfigure -p low --force openssh-server
 firstboot-command systemctl start ssh
+firstboot-command apt update && apt upgrade --yes
 _EOT
 	# CONFIG_GUESTFS_COPY_SOURCES_FROM_HOST_TO_GUEST will not work
 	# if /etc/nsswitch.conf has a line like this:

scripts/firstconfig.Makefile

@@ -0,0 +1,15 @@
+# SPDX-License-Identifier: copyleft-next-0.3.1
+
+firstconfig:
+	$(Q)ansible-playbook $(ANSIBLE_VERBOSE) -l baseline,dev \
+		-f 30 -i hosts  \
+		--extra-vars '{ kdevops_cli_install: True }' \
+		--tags vars_simple,firstconfig \
+		$(KDEVOPS_PLAYBOOKS_DIR)/devconfig.yml
+
+KDEVOPS_BRING_UP_DEPS_EARLY += firstconfig
+
+firstconfig-help:
+	@echo "firstconfig    - Setup firstconfig"
+
+HELP_TARGETS += firstconfig-help