playbooks: ansible-lint fix deprecated-local-action

Fix deprecated-local-action ansible-lint rule violations

Fixed deprecated-local-action rule violations across 225 file(s).

Affected files include:
- playbooks/devconfig.yml
- playbooks/monitor-results.yml
- playbooks/roles/ansible_cfg/tasks/main.yml
- playbooks/roles/blktests/defaults/main.yml
- playbooks/roles/blktests/handlers/main.yml
... and 220 more files

Applied using the ansible-lint-fix-rules.py script with --fix=deprecated-local-action.

Generated-by: Ansible Lint (ansible-lint-fix-rules.py)
Signed-off-by: Daniel Gomez <[email protected]>

Author: dkruces

playbooks/devconfig.yml

@@ -1,6 +1,6 @@
 ---
 - name: Configure developer environment on target systems
   hosts: baseline:dev
-  gather_facts: no
+  gather_facts: false
   roles:
     - role: devconfig

playbooks/monitor-results.yml

@@ -1,17 +1,17 @@
 ---
 - hosts: all
-  become: yes
-  become_flags: 'su - -c'
+  become: true
+  become_flags: "su - -c"
   become_method: sudo
   tasks:
     - name: Import optional extra_args file
       include_vars: "{{ item }}"
-      ignore_errors: yes
+      ignore_errors: true
       with_first_found:
         - files:
-          - "../extra_vars.yml"
-          - "../extra_vars.yaml"
-          - "../extra_vars.json"
+            - "../extra_vars.yml"
+            - "../extra_vars.yaml"
+            - "../extra_vars.json"
           skip: true
       tags: vars
 
@@ -21,4 +21,4 @@
         tasks_from: monitor_collect_only
       when:
         - enable_monitoring|default(false)|bool
-      tags: [ 'monitoring', 'monitor_collect' ]
+      tags: ["monitoring", "monitor_collect"]

playbooks/roles/ansible_cfg/tasks/main.yml

@@ -15,10 +15,10 @@
   ansible.builtin.template:
     src: "ansible.cfg.j2"
     dest: "{{ ansible_cfg_file }}"
-    mode: '0755'
+    mode: "0755"
 
 - name: Update ansible.cfg access modification time so make sees it updated
   ansible.builtin.file:
     path: "{{ topdir_path }}/ansible.cfg"
     state: touch
-    mode: '0755'
+    mode: "0755"

playbooks/roles/blktests/defaults/main.yml

@@ -3,9 +3,9 @@
 # Our sensible defaults for the blktests role.
 #
 # We default to not run tests.
-kdevops_run_blktests: False
-run_tests_on_failures: False
-blktests_skip_run: False
+kdevops_run_blktests: false
+run_tests_on_failures: false
+blktests_skip_run: false
 
 # Ror instance you can use "-g quick" but note that this may produce
 # not results as all quick tests may be expunded.
@@ -21,5 +21,5 @@ nbd_git: "https://github.com/NetworkBlockDevice/nbd.git"
 nbd_version: "nbd-3.21"
 nbd_data: "{{data_path}}/nbd"
 
-compile_dbench: False
+compile_dbench: false
 blktests_dbench_git: "https://github.com/linux-kdevops/dbench.git"

playbooks/roles/blktests/handlers/main.yml

@@ -1,3 +1,4 @@
+---
 # SPDX-License-Identifier GPL-2.0+ OR MIT
 - name: Restart watchdog daemon
   service: name="{{watchdog_service_name}}" state=restarted

playbooks/roles/blktests/tasks/install-deps/debian/main.yml

@@ -1,21 +1,21 @@
 ---
 - name: Update apt cache
-  become: yes
+  become: true
   become_method: sudo
   apt:
-    update_cache: yes
+    update_cache: true
   tags: linux
 
 - name: Install nvme tools
-  become: yes
+  become: true
   become_method: sudo
   apt:
     name:
       - nvme-cli
-    update_cache: yes
+    update_cache: true
 
 - name: Install blktests build dependencies
-  become: yes
+  become: true
   become_method: sudo
   apt:
     name:
@@ -65,5 +65,5 @@
       - libnl-utils
       - zlib1g-dev
     state: present
-    update_cache: yes
-  tags: [ 'blktests', 'deps' ]
+    update_cache: true
+  tags: ["blktests", "deps"]

playbooks/roles/blktests/tasks/install-deps/redhat/main.yml

@@ -1,9 +1,9 @@
 ---
 - name: Install build dependencies for blktests
-  become: yes
+  become: true
   become_method: sudo
   yum:
-    update_cache: yes
+    update_cache: true
     name: "{{ packages }}"
   vars:
     packages:

playbooks/roles/blktests/tasks/install-deps/suse/main.yml

@@ -25,19 +25,19 @@
 
 - name: Set SLE specific version labels to make checks easier when not SLE
   set_fact:
-    is_sle10: False
-    is_sle11: False
-    is_sle12: False
-    is_sle12sp5: False
-    is_sle15: False
-    is_sle10sp3: False
-    is_sle11sp1: False
-    is_sle11sp4: False
-    is_sle12sp1: False
-    is_sle12sp3: False
-    is_sle15sp2: False
-    is_sle15sp3: False
-    is_sle15sp4: False
+    is_sle10: false
+    is_sle11: false
+    is_sle12: false
+    is_sle12sp5: false
+    is_sle15: false
+    is_sle10sp3: false
+    is_sle11sp1: false
+    is_sle11sp4: false
+    is_sle12sp1: false
+    is_sle12sp3: false
+    is_sle15sp2: false
+    is_sle15sp3: false
+    is_sle15sp4: false
   when:
     - not is_sle|bool
 
@@ -64,7 +64,7 @@
     - is_sle10|bool or is_sle11|bool or is_sle12sp1|bool
 
 - name: Install NVMe tools
-  become: yes
+  become: true
   become_method: sudo
   ansible.builtin.package:
     name:
@@ -75,7 +75,7 @@
     - not lacks_nvme_utils|bool
 
 - name: Install build dependencies for blktests
-  become: yes
+  become: true
   become_method: sudo
   ansible.builtin.package:
     name:
@@ -120,7 +120,7 @@
     - repos_present|bool
 
 - name: Install tumblweed packages
-  become: yes
+  become: true
   become_method: sudo
   ansible.builtin.package:
     name:
@@ -131,7 +131,7 @@
     - is_tumbleweed|bool
 
 - name: Install leap packages
-  become: yes
+  become: true
   become_method: sudo
   ansible.builtin.package:
     name:
@@ -143,7 +143,7 @@
     - is_tumbleweed|bool
 
 - name: Install libgdbm4
-  become: yes
+  become: true
   become_method: sudo
   ansible.builtin.package:
     name:
@@ -156,7 +156,7 @@
 # to find way to get autoconf-archive for sles15sp4
 # as it is required...
 - name: Install autoconf-archive for building nbd
-  become: yes
+  become: true
   become_method: sudo
   ansible.builtin.package:
     name:
@@ -168,40 +168,40 @@
 
 - name: The default is to assume we do not want to add the benchmark repo
   set_fact:
-    add_benchmark_repo: False
+    add_benchmark_repo: false
 
 - name: Does this release require the benchmark repo
   set_fact:
-    add_benchmark_repo: True
+    add_benchmark_repo: true
   when:
     - is_sle15sp2|bool or is_sle15sp3|bool or is_sle15sp4|bool or is_sle12sp5|bool
 
 - name: Add benchmark sles12sp5 opensuse repo when needed
-  become: yes
+  become: true
   become_method: sudo
   script:
     cmd: "{{ role_path }}/scripts/add-suse-repo-if-not-found.sh http://download.opensuse.org/repositories/benchmark/SLE_12_SP5/ benchmark benchmark"
   when:
     - is_sle12sp5|bool
 
 - name: Add benchmark sles15sp2 opensuse repo when needed
-  become: yes
+  become: true
   become_method: sudo
   script:
     cmd: "{{ role_path }}/scripts/add-suse-repo-if-not-found.sh http://download.opensuse.org/repositories/benchmark/SLE_15_SP2/ benchmark benchmark"
   when:
     - is_sle15sp2|bool
 
 - name: Add benchmark sles15sp3 opensuse repo when needed
-  become: yes
+  become: true
   become_method: sudo
   script:
     cmd: "{{ role_path }}/scripts/add-suse-repo-if-not-found.sh http://download.opensuse.org/repositories/benchmark/SLE_15_SP3/ benchmark benchmark"
   when:
     - is_sle15sp3|bool or is_sle15sp4|bool
 
 - name: Install dbench when needed
-  become: yes
+  become: true
   become_method: sudo
   ansible.builtin.package:
     name:
@@ -212,16 +212,16 @@
 
 - name: The default is to assume we do not want to to compile nbd manually
   set_fact:
-    compile_nbd: False
+    compile_nbd: false
 
 - name: Set when we need to compile nbd
   set_fact:
-    compile_nbd: True
+    compile_nbd: true
   when:
     - is_sle15sp2|bool or is_sle15sp3|bool or is_sle15sp4|bool or is_leap|bool
 
 - name: Install build dependencies for nbd
-  become: yes
+  become: true
   become_method: sudo
   ansible.builtin.package:
     name:
@@ -235,12 +235,12 @@
   git:
     repo: "{{ nbd_git }}"
     dest: "{{ nbd_data }}"
-    update: yes
+    update: true
     version: "{{ nbd_version }}"
   when:
     - repos_present|bool
     - compile_nbd|bool
-  tags: [ 'git', 'blktests', 'nbd' ]
+  tags: ["git", "blktests", "nbd"]
 
 - name: Skip documentation for nbd as we lack the requirement of docbook2man
   file:
@@ -254,39 +254,39 @@
     - "nbdtab.5.sh.in"
   loop_control:
     label: "Faking generation of documentation for nbd{{ item }}"
-  tags: [ 'blktests', 'nbd' ]
+  tags: ["blktests", "nbd"]
   when:
     - repos_present|bool
     - compile_nbd|bool
 
 - name: Run autogen for nbd
   command: "./autogen.sh"
-  tags: [ 'blktests', 'nbd' ]
+  tags: ["blktests", "nbd"]
   args:
     chdir: "{{ nbd_data }}"
 
 - name: Run configure for nbd
   command: "./configure"
-  tags: [ 'blktests', 'nbd' ]
+  tags: ["blktests", "nbd"]
   args:
     chdir: "{{ nbd_data }}"
 
 - name: Get nproc
   command: "{{ num_jobs }}"
-  tags: [ 'git', 'blktests', 'nbd' ]
+  tags: ["git", "blktests", "nbd"]
   register: nproc
 
 - name: Build nbd
-  tags: [ 'git', 'blktests', 'nbd' ]
+  tags: ["git", "blktests", "nbd"]
   make:
     chdir: "{{ nbd_data }}"
     jobs: "{{ nproc.stdout }}"
 
 - name: Install nbd
-  become: yes
-  become_flags: 'su - -c'
+  become: true
+  become_flags: "su - -c"
   become_method: sudo
   command: "{{  make }} install"
-  tags: [ 'git', 'blktests', 'nbd' ]
+  tags: ["git", "blktests", "nbd"]
   args:
     chdir: "{{ nbd_data }}"