Skip to content

Commit 4da8c43

Browse files
committed
devconfig: install-deps is skipped in some configurations
A recent commit replaced import_tasks with include_tasks in a few steps in the devconfig playbook. The Ansible "import_tasks" documentation says: > Tags are not interpreted for this action, they are applied to the > imported tasks Revert some of the import_tasks conversions to ensure those steps are run according to the command-line tag settings. For the original problem that I tripped on, add tags to ensure those sub-steps get run as needed. Reported-by: Joel Granados <[email protected]> Closes: https://lore.kernel.org/kdevops/[email protected]/T/#t Fixes: ec9a34e ("devconfig: Replace import_tasks with include_tasks") Reviewed-by: Daniel Gomez <[email protected]> Tested-by: Daniel Gomez <[email protected]> Signed-off-by: Chuck Lever <[email protected]>
1 parent 1f3811c commit 4da8c43

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

playbooks/roles/devconfig/tasks/main.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,10 @@
3232
# Distro specific
3333
- name: Install dependencies
3434
ansible.builtin.include_tasks: install-deps/main.yml
35+
tags: ['vars', 'vars_simple']
3536

3637
- name: Configure custom repositories and install packages
37-
ansible.builtin.include_tasks: config-custom-repos-and-packages/main.yml
38+
ansible.builtin.import_tasks: config-custom-repos-and-packages/main.yml
3839
when:
3940
- ansible_facts['os_family']|lower == 'redhat'
4041

@@ -447,7 +448,7 @@
447448
tags: [ 'console' ]
448449

449450
- name: Update your boot GRUB file if necessary
450-
ansible.builtin.include_tasks: update-grub/main.yml
451+
ansible.builtin.import_tasks: update-grub/main.yml
451452
when:
452453
- grub2_config_file.stat.exists
453454
- devconfig_enable_console|bool
@@ -637,7 +638,7 @@
637638
tags: [ 'sysctl' ]
638639

639640
- name: Rev the kernel to the latest distribution kotd
640-
ansible.builtin.include_tasks: kotd-rev-kernel/main.yml
641+
ansible.builtin.import_tasks: kotd-rev-kernel/main.yml
641642
when:
642643
- devconfig_enable_kotd|bool
643644
tags: [ 'kotd' ]

0 commit comments

Comments
 (0)