guestfs: fix dnsmasq check to avoid false positives in container environments

The dnsmasq configuration check was too strict and caused false positives on
systems where dnsmasq configuration directories exist but the service is not
actually running. This particularly affected systems with Incus installed
which creates /etc/dnsmasq.d/incus symlink for container networking without
running the dnsmasq systemd service.

The original check verified the existence of /etc/dnsmasq.conf and
/etc/dnsmasq.d directory and would fail if either existed regardless of
whether the dnsmasq service was actually running and conflicting with
libvirt networking.

Replace the filesystem-based checks with a simple service status check that
only fails if the dnsmasq service is actually active. This addresses the
root cause of the networking conflict which is the running dnsmasq service
not the presence of configuration files that may be used by other tools.

Remove the checks for configuration file existence and service enabled status
keeping only the check for active service state. The check now uses systemctl
is-active which returns zero only when the service is currently running and
will return non-zero for inactive not-found or any other non-active state.

This allows kdevops to run successfully on systems where dnsmasq directories
exist for other purposes such as Incus container networking while still
protecting against actual conflicts with running dnsmasq services.

Generated-by: Claude AI
Signed-off-by: Daniel Gomez <[email protected]>

Author: dkruces

playbooks/roles/guestfs/tasks/bringup/network.yml

@@ -1,64 +1,26 @@
 ---
-- name: Check for dnsmasq configuration files
-  ansible.builtin.stat:
-    path: "{{ item }}"
-  loop:
-    - /etc/dnsmasq.conf
-    - /etc/dnsmasq.d
-  register: dnsmasq_config_files
-  when:
-    - distro_debian_based|bool
-
-- name: Fail if dnsmasq configuration files exist
-  ansible.builtin.fail:
-    msg: |
-      dnsmasq configuration files or directories still exist.
-      Please remove the following to fully uninstall
-      dnsmasq:\n{{ dnsmasq_config_files | join('\n') }}
-  when:
-    - distro_debian_based|bool
-    - dnsmasq_config_files.results | selectattr('stat.exists') | list | length > 0
-
-- name: Check if dnsmasq service is enabled
-  # noqa: command-instead-of-module
-  become: true
-  become_flags: "su - -c"
-  become_method: ansible.builtin.sudo
-  ansible.builtin.command:
-    cmd: "systemctl is-enabled dnsmasq"
-  register: dnsmasq_enabled
-  failed_when: false
-  changed_when: false
-  when:
-    - distro_debian_based|bool
-    - dnsmasq_config_files | length > 0
-
-- name: Check if dnsmasq service is active
+- name: Check if dnsmasq service is running
   # noqa: command-instead-of-module
   become: true
   become_flags: "su - -c"
   become_method: ansible.builtin.sudo
   ansible.builtin.command:
     cmd: "systemctl is-active dnsmasq"
-  register: dnsmasq_active
+  register: dnsmasq_status
   failed_when: false
   changed_when: false
   when:
     - distro_debian_based|bool
-    - dnsmasq_config_files | length > 0
 
-- name: Fail if dnsmasq service is enabled or active
+- name: Fail if dnsmasq service conflicts with libvirt
   ansible.builtin.fail:
     msg: |
-      dnsmasq service is
-      {{ 'enabled' if dnsmasq_enabled.rc == 0 else 'active' if dnsmasq_active.rc == 0 else 'present' }}.
-      Please ensure dnsmasq is fully uninstalled and disabled.
-      Run 'sudo systemctl disable dnsmasq' and 'sudo systemctl
-      stop dnsmasq' to disable and stop the service.
+      dnsmasq service is running and will conflict with libvirt networking.
+      The libvirt default network requires control of DHCP/DNS services.
+      Disable dnsmasq with: sudo systemctl disable --now dnsmasq
   when:
     - distro_debian_based|bool
-    - dnsmasq_config_files | length > 0
-    - (dnsmasq_enabled.rc == 0) or (dnsmasq_active.rc == 0)
+    - dnsmasq_status.rc == 0
 
 - name: Check if libvirt default network is running
   become: true