ansible-lint: systematic fixes for major rule violations

Fix the most impactful ansible-lint violations across all playbook files:

1. Schema fixes (607 violations → fixed):
   - become_method: sudo → become_method: ansible.builtin.sudo
   - Fixed across 128 playbook files

2. YAML formatting fixes (30+ violations → fixed):
   - Boolean values: yes/no → true/false
   - Fixed inconsistent boolean representations

These changes address the bulk of schema validation errors and YAML
formatting inconsistencies, significantly improving playbook quality.

Impact: ~640+ ansible-lint violations resolved

Generated-by: Claude AI
Signed-off-by: Daniel Gomez <[email protected]>

Author: dkruces

playbooks/roles/blktests/tasks/install-deps/debian/main.yml

@@ -1,22 +1,22 @@
 ---
 - name: Update apt cache
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.apt:
     update_cache: true
   tags: linux
 
 - name: Install nvme tools
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.apt:
     name:
       - nvme-cli
     update_cache: true
 
 - name: Install blktests build dependencies
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.apt:
     name:
       - bison

playbooks/roles/blktests/tasks/install-deps/redhat/main.yml

@@ -1,7 +1,7 @@
 ---
 - name: Install build dependencies for blktests
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.dnf:
     update_cache: true
     name: "{{ packages }}"

playbooks/roles/blktests/tasks/install-deps/suse/main.yml

@@ -65,7 +65,7 @@
 
 - name: Install NVMe tools
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.package:
     name:
       - nvme-cli
@@ -76,7 +76,7 @@
 
 - name: Install build dependencies for blktests
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.package:
     name:
       - bison
@@ -121,7 +121,7 @@
 
 - name: Install tumblweed packages
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.package:
     name:
       - libgdbm6
@@ -132,7 +132,7 @@
 
 - name: Install leap packages
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.package:
     name:
       - libgdbm4
@@ -144,7 +144,7 @@
 
 - name: Install libgdbm4
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.package:
     name:
       - libgdbm4
@@ -157,7 +157,7 @@
 # as it is required...
 - name: Install autoconf-archive for building nbd
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.package:
     name:
       - autoconf-archive
@@ -178,31 +178,31 @@
 
 - name: Add benchmark sles12sp5 opensuse repo when needed
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.script:
     cmd: "{{ role_path }}/scripts/add-suse-repo-if-not-found.sh http://download.opensuse.org/repositories/benchmark/SLE_12_SP5/ benchmark benchmark"
   when:
     - is_sle12sp5|bool
 
 - name: Add benchmark sles15sp2 opensuse repo when needed
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.script:
     cmd: "{{ role_path }}/scripts/add-suse-repo-if-not-found.sh http://download.opensuse.org/repositories/benchmark/SLE_15_SP2/ benchmark benchmark"
   when:
     - is_sle15sp2|bool
 
 - name: Add benchmark sles15sp3 opensuse repo when needed
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.script:
     cmd: "{{ role_path }}/scripts/add-suse-repo-if-not-found.sh http://download.opensuse.org/repositories/benchmark/SLE_15_SP3/ benchmark benchmark"
   when:
     - is_sle15sp3|bool or is_sle15sp4|bool
 
 - name: Install dbench when needed
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.package:
     name:
       - dbench
@@ -222,7 +222,7 @@
 
 - name: Install build dependencies for nbd
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.package:
     name:
       - glib2-devel
@@ -285,7 +285,7 @@
 - name: Install nbd
   become: true
   become_flags: "su - -c"
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.command: "{{  make }} install"
   tags: ["git", "blktests", "nbd"]
   args:

playbooks/roles/blktests/tasks/main.yml

@@ -47,7 +47,7 @@
 - name: Remove any old blktrace as we always clone a fresh tree
   become: true
   become_flags: "su - -c"
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.file:
     path: "{{ blktrace_data }}"
     state: absent
@@ -75,7 +75,7 @@
 - name: Install blktrace
   become: true
   become_flags: "su - -c"
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.command: "{{  make }} install"
   tags: ["blktests", "install", "root", "blktrace"]
   args:
@@ -84,7 +84,7 @@
 - name: Remove any old blktets as we always clone a fresh tree
   become: true
   become_flags: "su - -c"
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.file:
     path: "{{ blktests_data }}"
     state: absent
@@ -107,7 +107,7 @@
 - name: Install blktests
   become: true
   become_flags: "su - -c"
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.command: "{{  make }} install"
   tags: ["blktests", "install", "root"]
   args:
@@ -125,7 +125,7 @@
 
 - name: Create a symbolic links needed
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.file:
     src: "{{ kdevops_dir }}/workflows/blktests/scripts/{{ item }}"
     dest: "{{ blktests_data_target }}/{{ item }}"
@@ -138,7 +138,7 @@
 
 - name: Disable multipathd service for srp blktests tests
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.systemd:
     name: multipathd
     enabled: false
@@ -148,7 +148,7 @@
 - name: Reboot system before our test so we know everything is sane
   tags: ["blktests", "run_tests", "reboot"]
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.reboot:
     post_reboot_delay: 10
 
@@ -201,15 +201,15 @@
   tags: ["blktests", "run_tests", "configfs"]
   become: true
   become_flags: "su - -c"
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.command: "modprobe configfs"
   when:
     - kdevops_run_blktests|bool
 
 - name: Clear out old results directory on target hosts
   become: true
   become_flags: "su - -c"
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.file:
     state: absent
     path: "{{ blktests_data_target }}/results/"
@@ -236,7 +236,7 @@
   tags: ["blktests", "run_tests"]
   become: true
   become_flags: "su - -c"
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.command: "test -e {{ verify_dev_list }}"
   when:
     - kdevops_run_blktests|bool
@@ -248,7 +248,7 @@
   tags: ["blktests", "run_tests"]
   become: true
   become_flags: "su - -c"
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.command: "test -b {{ verify_dev_list }}"
   when:
     - kdevops_run_blktests|bool
@@ -268,7 +268,7 @@
 - name: Enable low-level messages on console
   become: true
   become_flags: "su - -c"
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.command: sysctl kernel.printk="8 8 1 7"
 - name: Check to see if dynamic test limit scope was set
   ansible.builtin.set_fact:
@@ -359,7 +359,7 @@
   tags: ["blktests", "run_tests"]
   become: true
   become_flags: "su - -c"
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.command: "./oscheck.sh --print-start --print-done --test-group {{ group }} {{ oscheck_extra_args }} {{ all_limit_tests }}"
   ignore_errors: true
   no_log: true
@@ -397,7 +397,7 @@
   tags: ["blktests", "copy_results"]
   become: true
   become_flags: "su - -c"
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.find:
     paths: "{{ blktests_data_target }}/results/"
     recurse: true
@@ -408,7 +408,7 @@
   tags: ["blktests", "copy_results"]
   become: true
   become_flags: "su - -c"
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.fetch:
     src: "{{ item.path }}"
     dest: "{{ blktests_results_target }}/last-run/{{ item.path | regex_replace(blktests_data_target + 'results/' | regex_escape()) | regex_replace('^/', '') }}"

playbooks/roles/bootlinux/tasks/build/9p.yml

@@ -7,7 +7,7 @@
 
 - name: Install b4 on host
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.pip:
     name:
       - b4

playbooks/roles/bootlinux/tasks/build/targets.yml

@@ -1,7 +1,7 @@
 ---
 - name: Install b4
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.pip:
     name:
       - b4

playbooks/roles/bootlinux/tasks/install-deps/debian/main.yml

@@ -3,14 +3,14 @@
 
 - name: Update apt cache
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.apt:
     update_cache: true
 
 # apt-get build-dep does not capture all requirements
 - name: Install Linux kernel build dependencies
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.apt:
     name:
       - bison

playbooks/roles/bootlinux/tasks/install-deps/redhat/main.yml

@@ -7,7 +7,7 @@
 
 - name: Install packages we care about
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.dnf:
     update_cache: true
     name: "{{ packages }}"
@@ -55,7 +55,7 @@
 
 - name: Install btrfs-progs
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.dnf:
     update_cache: true
     name: "{{ packages }}"
@@ -104,7 +104,7 @@
 
 - name: Remove packages that mess with initramfs
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.dnf:
     state: absent
     name: dracut-config-generic

playbooks/roles/bootlinux/tasks/install-deps/suse/main.yml

@@ -1,7 +1,7 @@
 ---
 - name: Install Linux kernel build dependencies for SUSE sources
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   community.general.zypper:
     name:
       - bison

playbooks/roles/bootlinux/tasks/install-minimal-deps/debian/main.yml

@@ -4,13 +4,13 @@
 
 - name: Update apt cache
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.apt:
     update_cache: true
 
 - name: Install minimal build tools for kernel installation
   become: true
-  become_method: sudo
+  become_method: ansible.builtin.sudo
   ansible.builtin.apt:
     name:
       - make