Skip to content

Commit 640b996

Browse files
committed
playbooks: ansible-lint fix fqcn[action-core]
Generated-by: Claude AI Signed-off-by: Daniel Gomez <[email protected]>
1 parent 9de68e7 commit 640b996

File tree

25 files changed

+142
-142
lines changed

25 files changed

+142
-142
lines changed

playbooks/ai_multifs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
- role: ai_multifs_run
1010
tasks:
1111
- name: Final multi-filesystem testing summary
12-
debug:
12+
ansible.builtin.debug:
1313
msg: |
1414
Multi-filesystem AI benchmark testing completed!
1515

playbooks/roles/ai_docker_storage/tasks/main.yml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
- name: Import optional extra_args file
3-
include_vars: "{{ item }}"
3+
ansible.builtin.include_vars: "{{ item }}"
44
ignore_errors: true
55
with_items:
66
- "../extra_vars.yaml"
@@ -10,7 +10,7 @@
1010
when: ai_docker_storage_enable | bool
1111
block:
1212
- name: Install filesystem utilities
13-
package:
13+
ansible.builtin.package:
1414
name:
1515
- xfsprogs
1616
- e2fsprogs
@@ -21,13 +21,13 @@
2121
become_method: sudo
2222

2323
- name: Check if device exists
24-
stat:
24+
ansible.builtin.stat:
2525
path: "{{ ai_docker_device }}"
2626
register: docker_device_stat
2727
failed_when: not docker_device_stat.stat.exists
2828

2929
- name: Check if Docker storage is already mounted
30-
command: mountpoint -q {{ ai_docker_mount_point }}
30+
ansible.builtin.command: mountpoint -q {{ ai_docker_mount_point }}
3131
register: docker_mount_check
3232
changed_when: false
3333
failed_when: false
@@ -36,15 +36,15 @@
3636
when: docker_mount_check.rc != 0
3737
block:
3838
- name: Create Docker mount point directory
39-
file:
39+
ansible.builtin.file:
4040
path: "{{ ai_docker_mount_point }}"
4141
state: directory
4242
mode: '0755'
4343
become: true
4444
become_method: sudo
4545

4646
- name: Format device with XFS
47-
command: >
47+
ansible.builtin.command: >
4848
mkfs.xfs -f
4949
-b size={{ ai_docker_xfs_blocksize | default(4096) }}
5050
-s size={{ ai_docker_xfs_sectorsize | default(4096) }}
@@ -55,19 +55,19 @@
5555
become_method: sudo
5656

5757
- name: Format device with Btrfs
58-
command: mkfs.btrfs {{ ai_docker_btrfs_mkfs_opts }} {{ ai_docker_device }}
58+
ansible.builtin.command: mkfs.btrfs {{ ai_docker_btrfs_mkfs_opts }} {{ ai_docker_device }}
5959
when: ai_docker_fstype == "btrfs"
6060
become: true
6161
become_method: sudo
6262

6363
- name: Format device with ext4
64-
command: mkfs.ext4 {{ ai_docker_ext4_mkfs_opts }} {{ ai_docker_device }}
64+
ansible.builtin.command: mkfs.ext4 {{ ai_docker_ext4_mkfs_opts }} {{ ai_docker_device }}
6565
when: ai_docker_fstype == "ext4"
6666
become: true
6767
become_method: sudo
6868

6969
- name: Mount Docker storage filesystem
70-
mount:
70+
ansible.posix.mount:
7171
path: "{{ ai_docker_mount_point }}"
7272
src: "{{ ai_docker_device }}"
7373
fstype: "{{ ai_docker_fstype }}"
@@ -77,7 +77,7 @@
7777
become_method: sudo
7878

7979
- name: Add Docker storage mount to fstab
80-
mount:
80+
ansible.posix.mount:
8181
path: "{{ ai_docker_mount_point }}"
8282
src: "{{ ai_docker_device }}"
8383
fstype: "{{ ai_docker_fstype }}"
@@ -87,14 +87,14 @@
8787
become_method: sudo
8888

8989
- name: Check if Docker service exists
90-
systemd:
90+
ansible.builtin.systemd:
9191
name: docker
9292
register: docker_service_status
9393
failed_when: false
9494
changed_when: false
9595

9696
- name: Stop Docker service if running
97-
systemd:
97+
ansible.builtin.systemd:
9898
name: docker
9999
state: stopped
100100
become: true
@@ -106,7 +106,7 @@
106106
# No need to move data or create symlinks as the storage is already in the right place
107107

108108
- name: Ensure Docker directory has proper permissions
109-
file:
109+
ansible.builtin.file:
110110
path: "{{ ai_docker_mount_point }}"
111111
state: directory
112112
mode: '0711'
@@ -119,5 +119,5 @@
119119
# Docker will be installed and started later by the ai role
120120
# We only prepare the storage here
121121
- name: Display Docker storage setup complete
122-
debug:
122+
ansible.builtin.debug:
123123
msg: "Docker storage has been prepared at: {{ ai_docker_mount_point }}"

playbooks/roles/ai_install/tasks/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
---
22
- name: Include role create_data_partition
3-
include_role:
3+
ansible.builtin.include_role:
44
name: create_data_partition
55
tags: ['setup', 'data_partition']
66

77
- name: Include role common
8-
include_role:
8+
ansible.builtin.include_role:
99
name: common
1010
when:
1111
- infer_uid_and_group|bool

playbooks/roles/ai_milvus_storage/tasks/main.yml

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
- name: Import optional extra_args file
3-
include_vars: "{{ item }}"
3+
ansible.builtin.include_vars: "{{ item }}"
44
ignore_errors: true
55
with_items:
66
- "../extra_vars.yaml"
@@ -10,7 +10,7 @@
1010
when: ai_milvus_storage_enable | bool
1111
block:
1212
- name: Install filesystem utilities
13-
package:
13+
ansible.builtin.package:
1414
name:
1515
- xfsprogs
1616
- e2fsprogs
@@ -20,13 +20,13 @@
2020
become_method: sudo
2121

2222
- name: Check if device exists
23-
stat:
23+
ansible.builtin.stat:
2424
path: "{{ ai_milvus_device }}"
2525
register: milvus_device_stat
2626
failed_when: not milvus_device_stat.stat.exists
2727

2828
- name: Check if Milvus storage is already mounted
29-
command: mountpoint -q {{ ai_milvus_mount_point }}
29+
ansible.builtin.command: mountpoint -q {{ ai_milvus_mount_point }}
3030
register: milvus_mount_check
3131
changed_when: false
3232
failed_when: false
@@ -35,15 +35,15 @@
3535
when: milvus_mount_check.rc != 0
3636
block:
3737
- name: Create Milvus mount point directory
38-
file:
38+
ansible.builtin.file:
3939
path: "{{ ai_milvus_mount_point }}"
4040
state: directory
4141
mode: '0755'
4242
become: true
4343
become_method: sudo
4444

4545
- name: Detect filesystem type from node name
46-
set_fact:
46+
ansible.builtin.set_fact:
4747
detected_fstype: >-
4848
{%- if 'xfs' in inventory_hostname -%}
4949
xfs
@@ -57,7 +57,7 @@
5757
when: ai_milvus_use_node_fs | default(false) | bool
5858

5959
- name: Detect XFS parameters from node name
60-
set_fact:
60+
ansible.builtin.set_fact:
6161
milvus_xfs_blocksize: >-
6262
{%- if '64k' in inventory_hostname -%}
6363
65536
@@ -81,7 +81,7 @@
8181
- detected_fstype | default(ai_milvus_fstype) == 'xfs'
8282

8383
- name: Detect ext4 parameters from node name
84-
set_fact:
84+
ansible.builtin.set_fact:
8585
milvus_ext4_opts: >-
8686
{%- if '16k' in inventory_hostname and 'bigalloc' in inventory_hostname -%}
8787
-F -b 4096 -C 16384 -O bigalloc
@@ -95,11 +95,11 @@
9595
- detected_fstype | default(ai_milvus_fstype) == 'ext4'
9696

9797
- name: Set final filesystem type
98-
set_fact:
98+
ansible.builtin.set_fact:
9999
milvus_fstype: "{{ detected_fstype | default(ai_milvus_fstype | default('xfs')) }}"
100100

101101
- name: Format device with XFS
102-
command: >
102+
ansible.builtin.command: >
103103
mkfs.xfs -f
104104
-b size={{ milvus_xfs_blocksize | default(ai_milvus_xfs_blocksize | default(4096)) }}
105105
-s size={{ milvus_xfs_sectorsize | default(ai_milvus_xfs_sectorsize | default(4096)) }}
@@ -110,19 +110,19 @@
110110
become_method: sudo
111111

112112
- name: Format device with Btrfs
113-
command: mkfs.btrfs {{ ai_milvus_btrfs_mkfs_opts | default('-f') }} {{ ai_milvus_device }}
113+
ansible.builtin.command: mkfs.btrfs {{ ai_milvus_btrfs_mkfs_opts | default('-f') }} {{ ai_milvus_device }}
114114
when: milvus_fstype == "btrfs"
115115
become: true
116116
become_method: sudo
117117

118118
- name: Format device with ext4
119-
command: mkfs.ext4 {{ milvus_ext4_opts | default(ai_milvus_ext4_mkfs_opts | default('-F')) }} {{ ai_milvus_device }}
119+
ansible.builtin.command: mkfs.ext4 {{ milvus_ext4_opts | default(ai_milvus_ext4_mkfs_opts | default('-F')) }} {{ ai_milvus_device }}
120120
when: milvus_fstype == "ext4"
121121
become: true
122122
become_method: sudo
123123

124124
- name: Mount Milvus storage filesystem
125-
mount:
125+
ansible.posix.mount:
126126
path: "{{ ai_milvus_mount_point }}"
127127
src: "{{ ai_milvus_device }}"
128128
fstype: "{{ milvus_fstype }}"
@@ -132,7 +132,7 @@
132132
become_method: sudo
133133

134134
- name: Add Milvus storage mount to fstab
135-
mount:
135+
ansible.posix.mount:
136136
path: "{{ ai_milvus_mount_point }}"
137137
src: "{{ ai_milvus_device }}"
138138
fstype: "{{ milvus_fstype }}"
@@ -142,7 +142,7 @@
142142
become_method: sudo
143143

144144
- name: Ensure Milvus directories exist with proper permissions
145-
file:
145+
ansible.builtin.file:
146146
path: "{{ item }}"
147147
state: directory
148148
mode: '0755'
@@ -157,5 +157,5 @@
157157
- "{{ ai_milvus_mount_point }}/minio"
158158

159159
- name: Display Milvus storage setup complete
160-
debug:
160+
ansible.builtin.debug:
161161
msg: "Milvus storage has been prepared at: {{ ai_milvus_mount_point }} with filesystem: {{ milvus_fstype | default(ai_milvus_fstype | default('xfs')) }}"

playbooks/roles/ai_multifs_run/tasks/generate_comparison.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
- name: Create multi-filesystem comparison script
3-
copy:
3+
ansible.builtin.copy:
44
content: |
55
#!/usr/bin/env python3
66
"""
@@ -268,11 +268,11 @@
268268
mode: '0755'
269269

270270
- name: Run multi-filesystem comparison analysis
271-
command: python3 {{ ai_multifs_results_dir }}/generate_comparison.py
271+
ansible.builtin.command: python3 {{ ai_multifs_results_dir }}/generate_comparison.py
272272
register: comparison_result
273273

274274
- name: Display comparison completion message
275-
debug:
275+
ansible.builtin.debug:
276276
msg: |
277277
Multi-filesystem comparison completed!
278278
Comparison report: {{ ai_multifs_results_dir }}/comparison/multi_filesystem_comparison.html
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
11
---
22
- name: Import optional extra_args file
3-
include_vars: "{{ item }}"
3+
ansible.builtin.include_vars: "{{ item }}"
44
ignore_errors: true
55
with_items:
66
- "../extra_vars.yaml"
77
tags: vars
88

99
- name: Filter enabled filesystem configurations
10-
set_fact:
10+
ansible.builtin.set_fact:
1111
enabled_fs_configs: "{{ ai_multifs_configurations | selectattr('enabled', 'equalto', true) | list }}"
1212

1313
- name: Run AI benchmarks on each filesystem configuration
14-
include_tasks: run_single_filesystem.yml
14+
ansible.builtin.include_tasks: run_single_filesystem.yml
1515
loop: "{{ enabled_fs_configs }}"
1616
loop_control:
1717
loop_var: fs_config
1818
index_var: fs_index
1919
when: enabled_fs_configs | length > 0
2020

2121
- name: Generate multi-filesystem comparison report
22-
include_tasks: generate_comparison.yml
22+
ansible.builtin.include_tasks: generate_comparison.yml
2323
when: enabled_fs_configs | length > 1

0 commit comments

Comments
 (0)