playbooks: ansible-lint fix no-free-form

Fix no-free-form ansible-lint rule violations

Fixed no-free-form rule violations across 18 file(s).

Affected files include:
- playbooks/roles/blktests/handlers/main.yml
- playbooks/roles/blktests/tasks/main.yml
- playbooks/roles/cxl/tasks/cxl-dcd-setup/main.yml
- playbooks/roles/cxl/tasks/main.yml
- playbooks/roles/devconfig/tasks/main.yml
... and 13 more files

Applied using the ansible-lint-fix-rules.py script with --fix=no-free-form.

Generated-by: Ansible Lint (ansible-lint-fix-rules.py)
Signed-off-by: Daniel Gomez <[email protected]>

Author: dkruces

playbooks/roles/blktests/handlers/main.yml

@@ -1,4 +1,6 @@
 ---
 # SPDX-License-Identifier GPL-2.0+ OR MIT
 - name: Restart watchdog daemon
-  ansible.builtin.service: name="{{watchdog_service_name}}" state=restarted
+  ansible.builtin.service:
+    name: "{{watchdog_service_name}}"
+    state: restarted

playbooks/roles/blktests/tasks/main.yml

@@ -170,7 +170,8 @@
 
 - name: Print uname for each host
   tags: ["blktests", "run_tests"]
-  ansible.builtin.debug: var=ansible_kernel
+  ansible.builtin.debug:
+    var: ansible_kernel
 - name: Get used target kernel version
   tags: ["blktests", "copy_results", "augment_expunge_list"]
   ansible.builtin.command: "uname -r"
@@ -255,7 +256,9 @@
     - blktests_test_devs|length != 0
 
 - name: Hint to watchdog tests are about to kick off
-  ansible.builtin.file: path="{{ blktests_workflow_target }}/.begin" state=touch
+  ansible.builtin.file:
+    path: "{{ blktests_workflow_target }}/.begin"
+    state: touch
   delegate_to: localhost
   tags: ["blktests", "run_tests"]
   when:
@@ -369,15 +372,19 @@
     - kdevops_run_blktests|bool
 
 - name: Remove watchdog hint that tests have started
-  ansible.builtin.file: path="{{ blktests_workflow_target }}/.begin" state=absent
+  ansible.builtin.file:
+    path: "{{ blktests_workflow_target }}/.begin"
+    state: absent
   delegate_to: localhost
   tags: ["blktests", "run_tests"]
   when:
     - kdevops_run_blktests|bool
   run_once: true
 
 - name: Clean up our localhost results/last-run directory
-  ansible.builtin.file: path="{{ blktests_results_target }}/{{ item }}" state=absent
+  ansible.builtin.file:
+    path: "{{ blktests_results_target }}/{{ item }}"
+    state: absent
   delegate_to: localhost
   with_items:
     - "last-run"

playbooks/roles/cxl/tasks/cxl-dcd-setup/main.yml

@@ -7,7 +7,8 @@
   tags: ["cxl-dcd-setup"]
   delegate_to: localhost
 
-- ansible.builtin.debug: var=command_output.stdout_lines
+- ansible.builtin.debug:
+    var: command_output.stdout_lines
   tags: ["cxl-dcd-setup"]
 
 - name: Show DC extents added
@@ -16,7 +17,8 @@
   register: command_output
   tags: ["cxl-dcd-setup"]
 
-- ansible.builtin.debug: var=command_output.stdout_lines
+- ansible.builtin.debug:
+    var: command_output.stdout_lines
   tags: ["cxl-dcd-setup"]
 
 - name: Create dax devices for DC region
@@ -26,7 +28,8 @@
   register: command_output
   tags: ["cxl-dcd-setup"]
 
-- ansible.builtin.debug: var=command_output.stdout_lines
+- ansible.builtin.debug:
+    var: command_output.stdout_lines
   tags: ["cxl-dcd-setup"]
 
 - name: Show dax devices added
@@ -35,7 +38,8 @@
   register: command_output
   tags: ["cxl-dcd-setup"]
 
-- ansible.builtin.debug: var=command_output.stdout_lines
+- ansible.builtin.debug:
+    var: command_output.stdout_lines
   tags: ["cxl-dcd-setup"]
 
 - name: Convert dax devices to system RAM and online
@@ -45,7 +49,8 @@
   register: command_output
   tags: ["cxl-dcd-setup"]
 
-- ansible.builtin.debug: var=command_output.stdout_lines
+- ansible.builtin.debug:
+    var: command_output.stdout_lines
   tags: ["cxl-dcd-setup"]
 
 - name: Show system memory with lsmem
@@ -54,5 +59,6 @@
   register: command_output
   tags: ["cxl-dcd-setup"]
 
-- ansible.builtin.debug: var=command_output.stdout_lines
+- ansible.builtin.debug:
+    var: command_output.stdout_lines
   tags: ["cxl-dcd-setup"]

playbooks/roles/cxl/tasks/main.yml

@@ -97,7 +97,8 @@
 
 - name: Print uname for each host
   tags: ["ndctl", "cxl-test-prep", "copy_results"]
-  ansible.builtin.debug: var=ansible_kernel
+  ansible.builtin.debug:
+    var: ansible_kernel
 - name: Clear out old meson results directory on target hosts
   become: true
   become_flags: "su - -c"
@@ -161,7 +162,9 @@
     - kdevops_run_cxl_tests|bool
 
 - name: Clean up our localhost results/last-run directory
-  ansible.builtin.file: path="{{ cxl_results_target }}/{{ item }}" state=absent
+  ansible.builtin.file:
+    path: "{{ cxl_results_target }}/{{ item }}"
+    state: absent
   delegate_to: localhost
   with_items:
     - "last-run"
@@ -171,7 +174,9 @@
   tags: ["ndctl", "cxl-test-meson", "copy_results"]
 
 - name: Create empty last-run directory
-  ansible.builtin.file: path="{{ cxl_results_target }}/" state=directory
+  ansible.builtin.file:
+    path: "{{ cxl_results_target }}/"
+    state: directory
   delegate_to: localhost
   run_once: true
   tags: ["ndctl", "cxl-test-meson", "copy_results"]

playbooks/roles/devconfig/tasks/main.yml

@@ -143,7 +143,8 @@
   when: dev_git_config_file.stat.exists
 
 - name: Check if the system has a user vimrc file
-  ansible.builtin.stat: path=~/.vimrc
+  ansible.builtin.stat:
+    path: ~/.vimrc
   register: dev_vimrc_file
   tags: vimrc
 
@@ -158,7 +159,8 @@
   become: true
   become_flags: "su - -c"
   become_method: sudo
-  ansible.builtin.stat: path=~/.vimrc
+  ansible.builtin.stat:
+    path: ~/.vimrc
   register: dev_root_vimrc_file
   tags: vimrc
 
@@ -226,15 +228,17 @@
   when: dev_bash_config_file_copied_root is success
 
 - name: Check to see if system has GRUB2
-  ansible.builtin.stat: path=/etc/default/grub
+  ansible.builtin.stat:
+    path: /etc/default/grub
   register: grub2_config_file
   tags: ["console"]
 
 - name: Check to see if stupid /etc/default/grub.d/15_timeout.cfg exists
   become: true
   become_flags: "su - -c"
   become_method: sudo
-  ansible.builtin.stat: path=/etc/default/grub.d/15_timeout.cfg
+  ansible.builtin.stat:
+    path: /etc/default/grub.d/15_timeout.cfg
   register: stupid_cloud_grub_timeout
   when:
     - devconfig_enable_console|bool
@@ -641,7 +645,8 @@
   when: devconfig_enable_systemd_journal_remote|bool
 
 - name: Enables systemd's watchdog
-  ansible.builtin.stat: path=/etc/systemd/system.conf
+  ansible.builtin.stat:
+    path: /etc/systemd/system.conf
   register: systemd_config_file
   tags: ["systemd_watchdog"]
 

playbooks/roles/fstests/handlers/main.yml

@@ -1,4 +1,6 @@
 ---
 # SPDX-License-Identifier GPL-2.0+ OR MIT
 - name: Restart watchdog daemon
-  ansible.builtin.service: name="{{watchdog_service_name}}" state=restarted
+  ansible.builtin.service:
+    name: "{{watchdog_service_name}}"
+    state: restarted

playbooks/roles/fstests/tasks/main.yml

@@ -1080,15 +1080,20 @@
 
 - name: Print uname for each host
   tags: ["oscheck", "fstests", "run_tests"]
-  ansible.builtin.debug: var=ansible_kernel
+  ansible.builtin.debug:
+    var: ansible_kernel
 - name: Clean up our localhost results/last-run directory
-  ansible.builtin.file: path="{{ fstests_results_target }}/" state=absent
+  ansible.builtin.file:
+    path: "{{ fstests_results_target }}/"
+    state: absent
   delegate_to: localhost
   run_once: true
   tags: ["oscheck", "fstests", "copy_results", "clean_local_results"]
 
 - name: Create empty last-run directory
-  ansible.builtin.file: path="{{ fstests_results_target }}/" state=directory
+  ansible.builtin.file:
+    path: "{{ fstests_results_target }}/"
+    state: directory
   delegate_to: localhost
   run_once: true
   tags: ["oscheck", "fstests", "copy_results", "clean_local_results"]
@@ -1134,7 +1139,9 @@
     - devconfig_enable_systemd_journal_remote|bool
 
 - name: Hint to watchdog tests are about to kick off
-  ansible.builtin.file: path="{{ fstests_workflow_dir }}/.begin" state=touch
+  ansible.builtin.file:
+    path: "{{ fstests_workflow_dir }}/.begin"
+    state: touch
   delegate_to: localhost
   tags: ["oscheck", "fstests", "run_tests"]
   when:
@@ -1296,7 +1303,9 @@
   tags: ["oscheck", "fstests", "run_tests", "monitoring", "monitor_collect"]
 
 - name: Remove watchdog hint that tests have started
-  ansible.builtin.file: path="{{ fstests_workflow_dir }}/.begin" state=absent
+  ansible.builtin.file:
+    path: "{{ fstests_workflow_dir }}/.begin"
+    state: absent
   delegate_to: localhost
   tags: ["oscheck", "fstests", "run_tests"]
   when:
@@ -1604,7 +1613,8 @@
   run_once: true
 
 - name: Get stat of new files not yet committed, ie, new expunge files
-  ansible.builtin.stat: path="{{ fstests_results_target }}/new_expunge_files.txt"
+  ansible.builtin.stat:
+    path: "{{ fstests_results_target }}/new_expunge_files.txt"
   delegate_to: localhost
   register: new_expunge_files_stat
   run_once: true

playbooks/roles/gitr/tasks/main.yml

@@ -29,13 +29,17 @@
     gitr_run_uniqifier: "{{ ansible_date_time.iso8601_basic_short }}"
 
 - name: Clean up our localhost results/last-run directory
-  ansible.builtin.file: path="{{ gitr_results_target }}/" state=absent
+  ansible.builtin.file:
+    path: "{{ gitr_results_target }}/"
+    state: absent
   delegate_to: localhost
   run_once: true
   tags: ["run_tests", "copy_results", "clean_local_results"]
 
 - name: Create empty last-run directory
-  ansible.builtin.file: path="{{ gitr_results_target }}/" state=directory
+  ansible.builtin.file:
+    path: "{{ gitr_results_target }}/"
+    state: directory
   delegate_to: localhost
   run_once: true
   tags: ["run_tests", "copy_results", "clean_local_results"]

playbooks/roles/hypervisor-tuning/tasks/main.yml

@@ -16,7 +16,8 @@
   become: true
   become_flags: "su - -c"
   become_method: sudo
-  ansible.builtin.stat: path=/sys/kernel/mm/ksm/run
+  ansible.builtin.stat:
+    path: /sys/kernel/mm/ksm/run
   register: ksm_enable_file
   tags: ["hypervisor"]
 
@@ -33,15 +34,17 @@
   become: true
   become_flags: "su - -c"
   become_method: sudo
-  ansible.builtin.stat: path=/sys/module/zswap/parameters/enabled
+  ansible.builtin.stat:
+    path: /sys/module/zswap/parameters/enabled
   register: zswap_enable_file
   tags: ["hypervisor"]
 
 - name: Check to see if zswap max pool percent file exists /sys/module/zswap/parameters/max_pool_percent
   become: true
   become_flags: "su - -c"
   become_method: sudo
-  ansible.builtin.stat: path=/sys/module/zswap/parameters/max_pool_percent
+  ansible.builtin.stat:
+    path: /sys/module/zswap/parameters/max_pool_percent
   register: zswap_max_pool_percent_file
   when:
     - hypervisor_tunning_zswap_enable|bool

playbooks/roles/ltp/tasks/main.yml

@@ -33,13 +33,17 @@
   run_once: true
 
 - name: Clean up our localhost results/last-run directory
-  ansible.builtin.file: path="{{ ltp_results_target }}/" state=absent
+  ansible.builtin.file:
+    path: "{{ ltp_results_target }}/"
+    state: absent
   delegate_to: localhost
   run_once: true
   tags: ["run_tests", "copy_results", "clean_local_results"]
 
 - name: Create empty last-run directory
-  ansible.builtin.file: path="{{ ltp_results_target }}/" state=directory
+  ansible.builtin.file:
+    path: "{{ ltp_results_target }}/"
+    state: directory
   delegate_to: localhost
   run_once: true
   tags: ["run_tests", "copy_results", "clean_local_results"]