Skip to content

Commit 768dad8

Browse files
committed
Makefile: add missing extra_vars.yaml dependencies
The ANSIBLE_INVENTORY_FILE and KDEVOPS_NODES targets both use '--extra-vars=@./extra_vars.yaml' in their ansible-playbook commands but didn't declare extra_vars.yaml as a dependency. This can caused build failures when running targets which depend on then when starting from a clear slate. This will be more important for future declared hosts environments which likely just depend on a defconfig and will run make targets on workflows. But this is also a sensible dependency clarification. This fix ensures that extra_vars.yaml is properly generated before any ansible-playbook commands that require it are executed. Generated-by: Claude AI Signed-off-by: Luis Chamberlain <[email protected]>
1 parent 557077d commit 768dad8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,14 +226,14 @@ include scripts/bringup.Makefile
226226
endif
227227

228228
DEFAULT_DEPS += $(ANSIBLE_INVENTORY_FILE)
229-
$(ANSIBLE_INVENTORY_FILE): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_HOSTS_TEMPLATE) $(KDEVOPS_NODES)
229+
$(ANSIBLE_INVENTORY_FILE): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_HOSTS_TEMPLATE) $(KDEVOPS_NODES) $(KDEVOPS_EXTRA_VARS)
230230
$(Q)ANSIBLE_LOCALHOST_WARNING=False ANSIBLE_INVENTORY_UNPARSED_WARNING=False \
231231
ansible-playbook $(ANSIBLE_VERBOSE) \
232232
$(KDEVOPS_PLAYBOOKS_DIR)/gen_hosts.yml \
233233
--extra-vars=@./extra_vars.yaml
234234

235235
DEFAULT_DEPS += $(KDEVOPS_NODES)
236-
$(KDEVOPS_NODES): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_NODES_TEMPLATE)
236+
$(KDEVOPS_NODES): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_NODES_TEMPLATE) $(KDEVOPS_EXTRA_VARS)
237237
$(Q)ANSIBLE_LOCALHOST_WARNING=False ANSIBLE_INVENTORY_UNPARSED_WARNING=False \
238238
ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \
239239
--inventory localhost, \

0 commit comments

Comments
 (0)