Skip to content

Commit 8715ce3

Browse files
committed
guestfs: bringup: fix networking issue for debian hosts
Add isc-dhcp-client as runtime guestfs dependency to fix the networking issue when bring up images with virt-builder. Include Joel's patch 03 [3] from his cleanup as dependency. [3] https://lore.kernel.org/all/ux4jlutnenwfc6dfj3om3tnq6jwxxvxumexznvegeq2l l3obu6@ttujm2rtvtfv/ Finally, libguestfs was added as part of bringup_guestfs rather than having it's own playbook. Other than the explicit runtime dependency package list, libguestsfs is supported by normal distro package manager installations and so, does not seem necessary to create another playbook/role for this. Note that when libguestfs was introduced in kdevops [1], no install-deps like playbook/role, etc was added and my best guess is that new kdevops installations/users are currently installing libguestfs manually (vagrant playbook currently installs libguestfs-tools [2] for RedHat/Fedora). So while fixing this for Debian, also add libguestfs package support for Suse and RedHat/Fedora distros. [1] 03b6eb1d34c16aa654f44e5668f0af9e075367d4 ("guestfs: add a new local guest management variant") [2] 99b78db71edbb01048f375030ff464e7f8faa024 ("install_vagrant: enhance the redhat install") # Describe the purpose of this series. The information you put here # will be used by the project maintainer to make a decision whether # your patches should be reviewed, and in what priority order. Please be # very detailed and link to any relevant discussions or sites that the # maintainer can review to better understand your proposed changes. If you # only have a single patch in your series, the contents of the cover # letter will be appended to the "under-the-cut" portion of the patch. # Lines starting with # will be removed from the cover letter. You can # use them to add notes or reminders to yourself. If you want to use # markdown headers in your cover letter, start the line with ">#". # You can add trailers to the cover letter. Any email addresses found in # these trailers will be added to the addresses specified/generated # during the b4 send stage. You can also run "b4 prep --auto-to-cc" to # auto-populate the To: and Cc: trailers based on the code being # modified. To: Luis Chamberlain <[email protected]> To: Chuck Lever <[email protected]> To: Joel Granados <[email protected]> Cc: [email protected] Signed-off-by: Daniel Gomez <[email protected]> --- Changes in v3: - EDITME: describe what is new in this series revision. - EDITME: use bulletpoints and terse descriptions. - Link to v2: https://lore.kernel.org/r/[email protected] Changes in v2: - Add Makefile target for libguestfs installation: install_libguestfs. - Add libguestfs installation task as part of bringup_guestfs playbook/role. - Remove virt-builder check from Makefile.min_deps. - Link to v1: https://lore.kernel.org/r/[email protected] https://lore.kernel.org/all/[email protected]/ Note: Patch was sent to the wrong mailing list and so history is only partial. --- b4-submit-tracking --- # This section is used internally by b4 prep for tracking purposes. { "series": { "revision": 3, "change-id": "20250129-fix-bringup-network-5f7e43b3bafe", "prefixes": [], "history": { "v1": [ "[email protected]" ], "v2": [ "[email protected]" ] } } }
1 parent 734f0af commit 8715ce3

File tree

0 file changed

+0
-0
lines changed

    0 file changed

    +0
    -0
    lines changed

    0 commit comments

    Comments
     (0)