terraform/AWS: Use "output yaml" for the profile setting

Refactor: Remove the line in terraform.Makefile that sets
"terraform_aws_profile", and just pass it directly from Kconfig
via an "output yaml" directive.

As an additional clean up, update the help text.

Signed-off-by: Chuck Lever <[email protected]>

Author: chucklever

scripts/terraform.Makefile

@@ -48,7 +48,6 @@ KDEVOPS_MRPROPER += $(KDEVOPS_NODES)
 DEFAULT_DEPS_REQS_EXTRA_VARS += $(KDEVOPS_TFVARS)
 
 ifeq (y,$(CONFIG_TERRAFORM_AWS))
-TERRAFORM_EXTRA_VARS += terraform_aws_profile=$(subst ",,$(CONFIG_TERRAFORM_AWS_PROFILE))
 TERRAFORM_EXTRA_VARS += terraform_aws_region=$(subst ",,$(CONFIG_TERRAFORM_AWS_REGION))
 TERRAFORM_EXTRA_VARS += terraform_aws_av_region=$(subst ",,$(CONFIG_TERRAFORM_AWS_AV_REGION))
 TERRAFORM_EXTRA_VARS += terraform_aws_ami_owner=$(subst ",,$(CONFIG_TERRAFORM_AWS_AMI_OWNER))

terraform/aws/kconfigs/Kconfig.identity

@@ -1,11 +1,12 @@
 config TERRAFORM_AWS_PROFILE
-	prompt "AWS profile to use"
-	string
+	string "AWS authentication profile to use"
+	output yaml
 	default "default"
 	help
-	  This option sets the value of the Terraform aws_profile
-	  variable. The AWS profile specifies an IAM user and secret
-	  key that Terraform uses to authenticate to AWS.
+	  This option sets the value of the terraform provider's
+	  aws_profile argument. An AWS profile specifies the IAM
+	  user and secret key that both terraform and the "aws"
+	  command line utility use to authenticate to AWS.
 
 	  AWS profiles are set up in ~/.aws/credentials using the
 	  "aws configure" command. You may also edit this file by