Skip to content

Commit a3f0c86

Browse files
committed
Makefile: add missing extra_vars.yaml dependencies
The ANSIBLE_INVENTORY_FILE and KDEVOPS_NODES targets both use '--extra-vars=@./extra_vars.yaml' in their ansible-playbook commands but didn't declare extra_vars.yaml as a dependency. This caused build failures when running targets like 'make minio' from a clean state. The missing dependency meant that ansible-playbook would fail with: 'No such file or directory: /data/minio/kdevops/extra_vars.yaml' This fix ensures that extra_vars.yaml is properly generated before any ansible-playbook commands that require it are executed. Generated-by: Claude AI Signed-off-by: Luis Chamberlain <[email protected]>
1 parent 13f944d commit a3f0c86

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,14 +234,14 @@ include scripts/bringup.Makefile
234234
endif
235235

236236
DEFAULT_DEPS += $(ANSIBLE_INVENTORY_FILE)
237-
$(ANSIBLE_INVENTORY_FILE): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_HOSTS_TEMPLATE) $(KDEVOPS_NODES)
237+
$(ANSIBLE_INVENTORY_FILE): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_HOSTS_TEMPLATE) $(KDEVOPS_NODES) $(KDEVOPS_EXTRA_VARS)
238238
$(Q)ANSIBLE_LOCALHOST_WARNING=False ANSIBLE_INVENTORY_UNPARSED_WARNING=False \
239239
ansible-playbook $(ANSIBLE_VERBOSE) \
240240
$(KDEVOPS_PLAYBOOKS_DIR)/gen_hosts.yml \
241241
--extra-vars=@./extra_vars.yaml
242242

243243
DEFAULT_DEPS += $(KDEVOPS_NODES)
244-
$(KDEVOPS_NODES): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_NODES_TEMPLATE)
244+
$(KDEVOPS_NODES): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_NODES_TEMPLATE) $(KDEVOPS_EXTRA_VARS)
245245
$(Q)ANSIBLE_LOCALHOST_WARNING=False ANSIBLE_INVENTORY_UNPARSED_WARNING=False \
246246
ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \
247247
--inventory localhost, \

0 commit comments

Comments
 (0)