Skip to content

Commit b95bd35

Browse files
committed
linux: use stable ref for baseline and dev for dev group
Right now we have the default tree being selected for the "baseline" group. However when booting with BOOTLINUX_AB_DIFFERENT_REF we end up with a baseline group and "dev" group. Is is therefore odd, to end up up with the "stable" kernel on the "dev" group, and the latest kernel on the "baseline" group. Invert this logic, so the dev group always has the latest and greatest to match expectations that dev groups are the bleeding edge. Now we get more sensible defaults: $ make defconfig-mmtests-ab-testing-thpcompact KDEVOPS_HOSTS_PREFIX="lpc" $ make $ make bringup $ make bringup $ make uname lpc-thpcompact-dev 6.17.0-rc4-00047-ge6b9dce0aeeb lpc-thpcompact 6.15.0 Signed-off-by: Luis Chamberlain <[email protected]>
1 parent a862beb commit b95bd35

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

workflows/linux/Kconfig

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ config BOOTLINUX_TEST_MESSAGE_ID_INSTALL_B4
307307
help
308308
When enabled, b4 will be installed using pip
309309

310-
config BOOTLINUX_TREE_REF
310+
config LATEST_BOOTLINUX_TREE_REF
311311
string
312312
default BOOTLINUX_TREE_LINUS_REF if BOOTLINUX_TREE_LINUS
313313
default BOOTLINUX_TREE_STABLE_REF if BOOTLINUX_STABLE
@@ -324,6 +324,11 @@ config BOOTLINUX_TREE_REF
324324
default BOOTLINUX_TREE_CEL_LINUX_REF if BOOTLINUX_TREE_CEL_LINUX
325325
default BOOTLINUX_TREE_CUSTOM_REF if BOOTLINUX_CUSTOM
326326

327+
config BOOTLINUX_TREE_REF
328+
string
329+
default LATEST_BOOTLINUX_TREE_REF if !BOOTLINUX_AB_DIFFERENT_REF
330+
default $(shell, scripts/infer_last_stable_kernel.sh) if BOOTLINUX_AB_DIFFERENT_REF
331+
327332
config BOOTLINUX_TREE_CUSTOM_KERNELRELEASE
328333
bool "Do you want a full custom kernel release name?"
329334
output yaml
@@ -424,7 +429,7 @@ config BOOTLINUX_DEV_TREE
424429
config TARGET_LINUX_DEV_REF
425430
string "Development kernel reference"
426431
output yaml
427-
default $(shell, scripts/infer_last_stable_kernel.sh)
432+
default LATEST_BOOTLINUX_TREE_REF
428433
help
429434
Git reference (branch, tag, or commit) for the development kernel.
430435
This should be different from the baseline reference to enable

0 commit comments

Comments
 (0)