terraform/AWS: Rename the region Kconfig symbols

Be consistent with the other terraform providers -- add "REGION" to
the names of Kconfig symbols that define specific regions. This also
comports with the names of the other items that are configured under
terraform/aws/.

Signed-off-by: Chuck Lever <[email protected]>

Author: chucklever

terraform/aws/kconfigs/Kconfig.location

@@ -1,11 +1,13 @@
 choice
-	prompt "AWS region to use"
-	default TERRAFORM_AWS_US_WEST_2
+	prompt "AWS region"
+	default TERRAFORM_AWS_REGION_US_WEST_2
 	help
-	  Use this option to select the AWS region that is
-	  geographically closest to you.
+	  Use this option to select the AWS region that hosts your
+	  compute and storage resources. If you do not explicitly
+	  specify a region, the US West (Oregon) region is the
+	  default.
 
-	  Once selected, you can stick with the default AV region,
+	  Once selected, you can stick with the default AV zone
 	  chosen by kdevops, or use:
 
 	    aws ec2 describe-availability-zones --region <region-name>
@@ -14,28 +16,8 @@ choice
 	  AWS account. Enter your selection from this list using the
 	  TERRAFORM_AWS_AV_REGION menu.
 
-config TERRAFORM_AWS_US_EAST_1
-	bool "us-east-1 - N. Virginia"
-	help
-	  This option will set the AWS region to us-east-1.
-
-config TERRAFORM_AWS_US_EAST_2
-	bool "us-east-2 - Ohio"
-	help
-	  This option will set the AWS region to us-east-2.
-
-config TERRAFORM_AWS_US_WEST_1
-	bool "us-west-1 - North California"
-	help
-	  This option will set the AWS region to us-west-1.
-
-config TERRAFORM_AWS_US_WEST_2
-	bool "us-west-2 - Oregon"
-	help
-	  This option will set the AWS region to us-west-2.
-
-	  If you wish to expand on this list send a patch after reading
-	  this list:
+	  If you wish to expand on the region list, send a patch after
+	  reading this list:
 
 	  https://docs.aws.amazon.com/general/latest/gr/rande.html
 
@@ -68,17 +50,44 @@ config TERRAFORM_AWS_US_WEST_2
 	  aws ec2 describe-images --image-ids ami-0699f753302dd8b00 | grep OwnerId
 	    "OwnerId": "137112412989",
 
+config TERRAFORM_AWS_REGION_US_EAST_1
+	bool "us-east-1 - N. Virginia"
+	help
+	  This option specifies the United States east-1 region.
+	  Multiple data centers are located in the US state of
+	  Virginia.
+
+config TERRAFORM_AWS_REGION_US_EAST_2
+	bool "us-east-2 - Ohio"
+	help
+	  This option specifies the United States east-2 region.
+	  The data center is located in Columbus, Ohio, US.
+
+config TERRAFORM_AWS_REGION_US_WEST_1
+	bool "us-west-1 - North California"
+	help
+	  This option specifies the United States west-1 region.
+	  The data center is located in San Francisco, California,
+	  US.
+
+config TERRAFORM_AWS_REGION_US_WEST_2
+	bool "us-west-2 - Oregon"
+	help
+	  This option specifies the United States west-2 region.
+	  Multiple data centers are located in the US state of
+	  Oregon.
+
 endchoice
 
 config TERRAFORM_AWS_REGION
 	string
 	output yaml
-	default "us-west-2" if TERRAFORM_AWS_US_WEST_2
-	default "us-west-1" if TERRAFORM_AWS_US_WEST_1
-	default "us-east-2" if TERRAFORM_AWS_US_EAST_2
-	default "us-east-1" if TERRAFORM_AWS_US_EAST_1
+	default "us-east-1" if TERRAFORM_AWS_REGION_US_EAST_1
+	default "us-east-2" if TERRAFORM_AWS_REGION_US_EAST_2
+	default "us-west-1" if TERRAFORM_AWS_REGION_US_WEST_1
+	default "us-west-2" if TERRAFORM_AWS_REGION_US_WEST_2
 
-if TERRAFORM_AWS_US_EAST_1
+if TERRAFORM_AWS_REGION_US_EAST_1
 
 choice
 	prompt "AWS East 1 availability zone to use"
@@ -116,9 +125,9 @@ config TERRAFORM_AWS_AV_REGION_EAST_1F
 
 endchoice
 
-endif # TERRAFORM_AWS_US_EAST_1
+endif # TERRAFORM_AWS_REGION_US_EAST_1
 
-if TERRAFORM_AWS_US_EAST_2
+if TERRAFORM_AWS_REGION_US_EAST_2
 
 choice
 	prompt "AWS East 2 availability zone to use"
@@ -141,9 +150,9 @@ config TERRAFORM_AWS_AV_REGION_EAST_2C
 
 endchoice
 
-endif # TERRAFORM_AWS_US_EAST_2
+endif # TERRAFORM_AWS_REGION_US_EAST_2
 
-if TERRAFORM_AWS_US_WEST_2
+if TERRAFORM_AWS_REGION_US_WEST_2
 
 choice
 	prompt "AWS West 2 AV region to use"
@@ -174,7 +183,7 @@ config TERRAFORM_AWS_AV_REGION_WEST_2D
 
 endchoice
 
-endif # TERRAFORM_AWS_US_WEST_2
+endif # TERRAFORM_AWS_REGION_US_WEST_2
 
 config TERRAFORM_AWS_AV_REGION
 	string