Skip to content

Commit c31459d

Browse files
committed
scripts/bringup_guestfs.sh: fix silly directory permission fix
The bringup process for libvirt URI system support (not session, so all debian based distros) requierss us to be paranoid about the permissions of our storage directory where we place our libvirt storage pool, and guestfs images. That's no reason to be hammering with a sledge hammer a crazy sudo chown -R on a target storage path. Specially when that directory may be shared with other users. Essentially this now does: sudo chown -R foo.libvirt-qemu /path/to/storage/ For small systems that may be OK, but that's nuts for partitions which are shared with other users, which is the way that kdevops storage pools was designed to support in the first place. Just remove this as this is very dangerous. I will soon post a replacement with an ansible check and it just checks for the permissions and complains and fails if we don't have the right permissions. Signed-off-by: Luis Chamberlain <[email protected]>
1 parent 8aa5012 commit c31459d

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

scripts/bringup_guestfs.sh

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -273,13 +273,6 @@ fi
273273
$USE_SUDO mkdir -p $STORAGEDIR
274274
$USE_SUDO mkdir -p $BASE_IMAGE_DIR
275275

276-
277-
if [[ "$CONFIG_LIBVIRT_URI_SYSTEM" == "y" ]]; then
278-
sudo chown -R $(whoami):$QEMU_GROUP $STORAGETOPDIR
279-
sudo chmod -R g+rw $STORAGETOPDIR
280-
sudo chmod -R g+s $STORAGETOPDIR
281-
fi
282-
283276
cmdfile=$(mktemp)
284277

285278
if [ ! -f $BASE_IMAGE ]; then

0 commit comments

Comments
 (0)