playbooks: all: add changed_when

Fix Ansible lint errors. Avoid duplicates and ensure proper indentation.

Signed-off-by: Daniel Gomez <[email protected]>

Author: dkruces

playbooks/roles/blktests/tasks/main.yml

@@ -175,6 +175,7 @@
 - name: Get used target kernel version
   tags: ["blktests", "copy_results", "augment_expunge_list"]
   ansible.builtin.command: "uname -r"
+  changed_when: false
   register: uname_cmd
 
 - name: Store last kernel variable
@@ -193,6 +194,7 @@
 
 - name: Document used target kernel version
   ansible.builtin.shell: echo {{ last_kernel }} > {{ blktests_results_target }}/last-kernel.txt
+  changed_when: false
   delegate_to: localhost
   tags: ["blktests", "copy_results", "augment_expunge_list"]
   run_once: true
@@ -238,6 +240,7 @@
   become_flags: "su - -c"
   become_method: ansible.builtin.sudo
   ansible.builtin.command: "test -e {{ verify_dev_list }}"
+  changed_when: false
   when:
     - kdevops_run_blktests|bool
     - blktests_test_devs|length != 0

playbooks/roles/bootlinux/tasks/build/9p.yml

@@ -88,6 +88,7 @@
 
 - name: Apply message patch set if requested on the control node
   ansible.builtin.shell: b4 am -o - {{target_linux_apply_patch_message_id}} | git am
+  changed_when: false
   args:
     chdir: "{{ bootlinux_9p_host_path }}"
   when:
@@ -107,6 +108,7 @@
 
 - name: Set kernel localversion if requested on the control node
   ansible.builtin.shell: "echo {{ active_linux_localversion | default(target_linux_localversion) }} > {{ bootlinux_9p_host_path }}/localversion"
+  changed_when: false
   when:
     - (active_linux_localversion is defined and active_linux_localversion != "") or (target_linux_localversion is defined and target_linux_localversion != "")
   run_once: true

playbooks/roles/bootlinux/tasks/build/targets.yml

@@ -61,6 +61,7 @@
 
 - name: Apply message patch set if requested on the target nodes
   ansible.builtin.shell: b4 am -o - {{target_linux_apply_patch_message_id}} | git am
+  changed_when: false
   args:
     chdir: "{{ target_linux_dir_path }}"
   when:
@@ -78,6 +79,7 @@
 
 - name: Set kernel localversion if requested on the target nodes
   ansible.builtin.shell: "echo {{ target_linux_localversion }} > {{ target_linux_dir_path }}/localversion"
+  changed_when: false
   when:
     - target_linux_localversion is defined and target_linux_localversion != ""
 

playbooks/roles/bootlinux/tasks/main.yml

@@ -213,6 +213,7 @@
 
 - name: Run uname before
   ansible.builtin.command: "uname -r"
+  changed_when: false
   register: uname_cmd_before
   tags: ["uninstall-linux"]
 
@@ -348,6 +349,7 @@
 
 - name: Run uname
   ansible.builtin.command: "uname -r"
+  changed_when: false
   register: uname_cmd
   tags: ["uname"]
 

playbooks/roles/bootlinux/tasks/update-grub/redhat.yml

@@ -4,6 +4,7 @@
   become_flags: "su - -c"
   become_method: ansible.builtin.sudo
   ansible.builtin.command: grub2-editenv - unset menu_auto_hide
+  changed_when: false
 - name: Determine if system was booted using UEFI
   ansible.builtin.stat:
     path: /sys/firmware/efi/efivars

playbooks/roles/cxl/tasks/cxl-create-dc-region/main.yml

@@ -2,6 +2,7 @@
 - name: Create a DC region before DC extents can be added
   become: true
   become_method: ansible.builtin.sudo
+  changed_when: false
   ansible.builtin.shell: "rid=0; region=$(cat /sys/bus/cxl/devices/decoder0.0/create_dc_region); echo $region > /sys/bus/cxl/devices/decoder0.0/create_dc_region;
     echo 256 > /sys/bus/cxl/devices/$region/interleave_granularity; echo 1 > /sys/bus/cxl/devices/$region/interleave_ways; echo dc$rid >/sys/bus/cxl/devices/decoder2.0/mode;
     echo 0x40000000 >/sys/bus/cxl/devices/decoder2.0/dpa_size; echo 0x40000000 > /sys/bus/cxl/devices/$region/size; echo  decoder2.0 > /sys/bus/cxl/devices/$region/target0;

playbooks/roles/cxl/tasks/cxl-dcd-setup/main.yml

@@ -1,6 +1,7 @@
 ---
 - name: Add DC extents to the hosts
   ansible.builtin.shell: " qmp_port_str={{ qmp_port_str }}; qmp_port=`echo $qmp_port_str | awk -F'[^0-9]+' '{ print $2 }'`;qmp_str=' { \"execute\": \"qmp_capabilities\"\
+  changed_when: false
     \ } { \"execute\": \"cxl-add-dynamic-capacity\", \"arguments\": { \"path\": \"/machine/peripheral/kdevops-cxl-dcd0\", \"region-id\": 0, \"extents\": [ { \"offset\"\
     : 0, \"len\": 128 }, { \"offset\": 128, \"len\": 256 } ] } } '; echo $qmp_str | ncat localhost $qmp_port"
   register: command_output
@@ -14,6 +15,7 @@
 - name: Show DC extents added
   become: false
   ansible.builtin.command: "ls /sys/bus/cxl/devices/decoder0.0/region0/dax_region0/ -lt"
+  changed_when: false
   register: command_output
   tags: ["cxl-dcd-setup"]
 
@@ -35,6 +37,7 @@
 - name: Show dax devices added
   become: false
   ansible.builtin.shell: "ls /dev/dax* -lt"
+  changed_when: false
   register: command_output
   tags: ["cxl-dcd-setup"]
 
@@ -56,6 +59,7 @@
 - name: Show system memory with lsmem
   become: false
   ansible.builtin.command: "lsmem"
+  changed_when: false
   register: command_output
   tags: ["cxl-dcd-setup"]
 

playbooks/roles/cxl/tasks/main.yml

@@ -80,6 +80,7 @@
 - name: Get used target kernel version
   tags: ["ndctl", "cxl-test-prep", "copy_results"]
   ansible.builtin.command: "uname -r"
+  changed_when: false
   register: uname_cmd
 
 - name: Store last kernel variable
@@ -183,6 +184,7 @@
 
 - name: Document used target kernel version
   ansible.builtin.shell: echo {{ last_kernel }} > {{ cxl_results_target }}/last-kernel.txt
+  changed_when: false
   delegate_to: localhost
   run_once: true
   tags: ["ndctl", "cxl-test-meson", "copy_results"]

playbooks/roles/devconfig/tasks/install-deps/suse/main.yml

@@ -446,6 +446,7 @@
   become_flags: "su - -c"
   become_method: ansible.builtin.sudo
   ansible.builtin.shell: kdumptool calibrate | grep ^High | awk '{print $2}'
+  changed_when: false
   register: kdump_high
   when:
     - install_kdump|bool
@@ -458,6 +459,7 @@
   become_flags: "su - -c"
   become_method: ansible.builtin.sudo
   ansible.builtin.shell: kdumptool calibrate | grep ^Low | awk '{print $2}'
+  changed_when: false
   register: kdump_low
   when:
     - install_kdump|bool

playbooks/roles/devconfig/tasks/kotd-rev-kernel/main.yml

@@ -26,10 +26,12 @@
 - name: Get used target kernel version prior to reving kernel
   tags: ["kotd"]
   ansible.builtin.command: "uname -r"
+  changed_when: false
   register: uname_cmd
 
 - name: Document used target kernel version prior to reving kernel
   ansible.builtin.shell: echo {{ uname_cmd.stdout_lines | regex_replace('\]') | regex_replace('\[') }} > {{ kotd_uname_before }}
+  changed_when: false
   delegate_to: localhost
   tags: ["kotd"]
   run_once: true
@@ -60,10 +62,12 @@
 - name: Get used target kernel version after reving kernel
   tags: ["kotd"]
   ansible.builtin.command: "uname -r"
+  changed_when: false
   register: uname_cmd
 
 - name: Document used target kernel version after reving kernel
   ansible.builtin.shell: echo {{ uname_cmd.stdout_lines | regex_replace('\]') | regex_replace('\[') }} > {{ kotd_uname_after }}
+  changed_when: false
   delegate_to: localhost
   tags: ["kotd"]
   run_once: true