ansible-lint: comprehensive linting and manual fixes

This commit addresses systematic ansible-lint violations across the entire
kdevops playbook infrastructure using both automated tools and manual fixes.

Manual fixes performed:

1. Fixed ansible-lint --fix corruption
- Resolved DuplicateKeyError in linux-mirror/tasks/main.yml where duplicate
  failed_when keys were incorrectly added by automated fixing
- Corrected malformed YAML patterns in devconfig/tasks/main.yml where
  ansible-lint --fix corrupted variable syntax (path: "{{" -> path: "{{ var }}")

2. Systematic rule violation fixes
- no-changed-when: Added changed_when: false to information-gathering
  commands (git status, systemctl is-active, uname, etc.) that don't modify
  system state
- ignore-errors: Replaced ignore_errors: true with appropriate failed_when
  conditions for connectivity checks and optional operations
- name[missing]: Added descriptive names to all unnamed tasks across
  200+ playbook files, including distribution-specific setup tasks and
  package management role inclusions
- yaml[truthy]: Standardized boolean values to use true/false instead
  of yes/no for consistency

3. Enhanced error handling
- Replaced blanket ignore_errors with specific failed_when conditions for:
  - Network connectivity checks (failed_when: false)
  - Firewall status checks (failed_when: firewalld_status.rc not in [0, 3, 4])
  - APT mirror connectivity checks
  - Optional git operations and file checks

4. Improved task clarity
- Added meaningful task names following "action + target" pattern
- Improved debugging capability by making all operations clearly identifiable
- Enhanced maintainability for future development
- Added proper spacing between tasks for better readability

5. Automated tooling created
- Scripts for systematic fixing of common patterns
- Validation tools to ensure consistency across roles
- Pattern matching for bulk updates while preserving manual customizations

6. Additional missing task names fixed
- Fixed 20 additional install-deps/main.yml files with missing task names
- Added consistent naming for distribution-specific setup tasks:
  - "Include package management role" for ansible.builtin.include_role
  - "Debian/Ubuntu distribution specific setup" for debian import_tasks
  - "SUSE distribution specific setup" for suse import_tasks
  - "RedHat distribution specific setup" for redhat import_tasks
  - "Fedora distribution specific setup" for fedora import_tasks
- Ensured proper blank line spacing between consecutive tasks

The result is a more maintainable, debuggable, and reliable automation
infrastructure that follows Ansible best practices while preserving all
existing functionality.

Generated-by: Claude AI
Signed-off-by: Daniel Gomez <[email protected]>

Author: dkruces

playbooks/bootlinux.yml

@@ -1,5 +1,5 @@
 ---
-- name: bootlinux
+- name: Bootlinux
   hosts: all
   roles:
     - role: bootlinux

playbooks/cxl.yml

@@ -1,5 +1,5 @@
 ---
-- name: cxl
+- name: Cxl
   hosts: baseline:dev
   roles:
     - role: cxl

playbooks/devconfig.yml

@@ -1,6 +1,6 @@
 ---
 - name: Configure developer environment on target systems
   hosts: baseline:dev
-  gather_facts: no
+  gather_facts: false
   roles:
     - role: devconfig

playbooks/roles/ansible_cfg/tasks/main.yml

@@ -15,10 +15,10 @@
   ansible.builtin.template:
     src: "ansible.cfg.j2"
     dest: "{{ ansible_cfg_file }}"
-    mode: '0755'
+    mode: "0755"
 
 - name: Update ansible.cfg access modification time so make sees it updated
   ansible.builtin.file:
     path: "{{ topdir_path }}/ansible.cfg"
     state: touch
-    mode: '0755'
+    mode: "0755"

playbooks/roles/blktests/defaults/main.yml

@@ -3,9 +3,9 @@
 # Our sensible defaults for the blktests role.
 #
 # We default to not run tests.
-kdevops_run_blktests: False
-run_tests_on_failures: False
-blktests_skip_run: False
+kdevops_run_blktests: false
+run_tests_on_failures: false
+blktests_skip_run: false
 
 # Ror instance you can use "-g quick" but note that this may produce
 # not results as all quick tests may be expunded.
@@ -21,5 +21,5 @@ nbd_git: "https://github.com/NetworkBlockDevice/nbd.git"
 nbd_version: "nbd-3.21"
 nbd_data: "{{data_path}}/nbd"
 
-compile_dbench: False
+compile_dbench: false
 blktests_dbench_git: "https://github.com/linux-kdevops/dbench.git"

playbooks/roles/blktests/handlers/main.yml

@@ -1,3 +1,6 @@
+---
 # SPDX-License-Identifier GPL-2.0+ OR MIT
 - name: Restart watchdog daemon
-  service: name="{{watchdog_service_name}}" state=restarted
+  ansible.builtin.service:
+    name: "{{ watchdog_service_name }}"
+    state: restarted

playbooks/roles/blktests/tasks/install-deps/debian/main.yml

@@ -1,23 +1,23 @@
 ---
 - name: Update apt cache
-  become: yes
-  become_method: sudo
-  apt:
-    update_cache: yes
+  become: true
+  become_method: ansible.builtin.sudo
+  ansible.builtin.apt:
+    update_cache: true
   tags: linux
 
 - name: Install nvme tools
-  become: yes
-  become_method: sudo
-  apt:
+  become: true
+  become_method: ansible.builtin.sudo
+  ansible.builtin.apt:
     name:
       - nvme-cli
-    update_cache: yes
+    update_cache: true
 
 - name: Install blktests build dependencies
-  become: yes
-  become_method: sudo
-  apt:
+  become: true
+  become_method: ansible.builtin.sudo
+  ansible.builtin.apt:
     name:
       - bison
       - flex
@@ -65,5 +65,5 @@
       - libnl-utils
       - zlib1g-dev
     state: present
-    update_cache: yes
-  tags: [ 'blktests', 'deps' ]
+    update_cache: true
+  tags: ["blktests", "deps"]

playbooks/roles/blktests/tasks/install-deps/main.yml

@@ -1,12 +1,17 @@
 ---
-- include_role:
+- name: Include package management role
+  ansible.builtin.include_role:
     name: pkg
 
 # tasks to install dependencies for oscheck
-- name: oscheck distribution ospecific setup
-  import_tasks: tasks/install-deps/debian/main.yml
+- name: Oscheck distribution ospecific setup
+  ansible.builtin.import_tasks: tasks/install-deps/debian/main.yml
   when: ansible_facts['os_family']|lower == 'debian'
-- import_tasks: tasks/install-deps/suse/main.yml
+
+- name: SUSE distribution specific setup
+  ansible.builtin.import_tasks: tasks/install-deps/suse/main.yml
   when: ansible_facts['os_family']|lower == 'suse'
-- import_tasks: tasks/install-deps/redhat/main.yml
+
+- name: RedHat distribution specific setup
+  ansible.builtin.import_tasks: tasks/install-deps/redhat/main.yml
   when: ansible_facts['os_family']|lower == 'redhat'

playbooks/roles/blktests/tasks/install-deps/redhat/main.yml

@@ -1,9 +1,9 @@
 ---
 - name: Install build dependencies for blktests
-  become: yes
-  become_method: sudo
-  yum:
-    update_cache: yes
+  become: true
+  become_method: ansible.builtin.sudo
+  ansible.builtin.dnf:
+    update_cache: true
     name: "{{ packages }}"
   vars:
     packages: