Merge branch 'main' into cel/fixes

Author: chucklever

.rustfmt.toml

@@ -0,0 +1,12 @@
+edition = "2021"
+newline_style = "Unix"
+
+# Unstable options that help catching some mistakes in formatting and that we may want to enable
+# when they become stable.
+#
+# They are kept here since they are useful to run from time to time.
+#format_code_in_doc_comments = true
+#reorder_impl_items = true
+#comment_width = 100
+#wrap_comments = true
+#normalize_comments = true

CLAUDE.md

@@ -481,6 +481,28 @@ The style checker will identify:
 Fix all reported issues before submitting your work. The `make style` command
 checks both file whitespace and the most recent commit message format.
 
+### Rust Code Quality
+
+For Rust code in kdevops (workflows/rcloud, etc.), ALWAYS run both:
+
+```bash
+# Format code using Linux kernel rustfmt standards
+cargo fmt
+
+# Check for common mistakes and idioms
+cargo clippy --all-targets --all-features -- -D warnings
+```
+
+**Rust Quality Checklist**:
+- ✅ Run `cargo fmt` to auto-format code according to .rustfmt.toml
+- ✅ Run `cargo clippy` with `-D warnings` (treat warnings as errors)
+- ✅ Fix ALL clippy warnings before committing
+- ✅ Common clippy fixes: remove unnecessary casts, use `.flatten()` instead of manual `if let Ok`, remove unused imports
+
+The install-rust-deps role provides both cargo/rustc and the .rustfmt.toml
+configuration from the Linux kernel, ensuring consistent Rust code quality
+across all kdevops workflows.
+
 ### Automatic Whitespace Fixing
 
 For convenience, you can automatically fix whitespace issues using:

Makefile

@@ -179,6 +179,7 @@ endif # WORKFLOW_KOTD_ENABLE
 DEFAULT_DEPS += $(DEFAULT_DEPS_REQS_EXTRA_VARS)
 
 include scripts/install-menuconfig-deps.Makefile
+include scripts/install-rcloud-deps.Makefile
 
 include Makefile.btrfs_progs
 
@@ -197,6 +198,10 @@ endif # CONFIG_HYPERVISOR_TUNING
 include Makefile.linux-mirror
 include Makefile.docker-mirror
 
+ifeq (y,$(CONFIG_RCLOUD))
+include workflows/rcloud/Makefile
+endif
+
 ifeq (y,$(CONFIG_KDEVOPS_DISTRO_REG_METHOD_TWOLINE))
 DEFAULT_DEPS += playbooks/secret.yml
 endif

README.md

@@ -377,6 +377,7 @@ want to just use the kernel that comes with your Linux distribution.
   * [kdevops CXL docs](docs/cxl.md)
   * [kdevops NFS docs](docs/nfs.md)
   * [kdevops selftests docs](docs/selftests.md)
+  * [kdevops rcloud docs](workflows/rcloud/docs/TESTING.md)
   * [kdevops reboot-limit docs](docs/reboot-limit.md)
   * [kdevops AI workflow docs](docs/ai/README.md)
   * [kdevops vLLM workflow docs](workflows/vllm/)

defconfigs/rcloud

@@ -0,0 +1,53 @@
+# rcloud server-only configuration
+#
+# PURPOSE: Production deployment of rcloud REST API server
+#
+# Use this when:
+#   - Deploying rcloud to a dedicated server
+#   - Base images already exist (created elsewhere or separately)
+#   - You only need the rcloud server component
+#
+# For testing/development, use 'defconfig-rcloud-guest-test' instead,
+# which includes both base image creation AND rcloud server setup.
+#
+# This defconfig:
+#   - Installs the rcloud REST API server
+#   - Enables the Terraform provider
+#   - Configures the systemd service
+#   - Does NOT create base images (assumes they exist)
+#   - Does NOT create test VMs (rcloud creates them on demand via API)
+#
+# After 'make rcloud', the API will be available at:
+#   http://localhost:8765/api/v1/health
+#
+# Test with:
+#   make rcloud-status                    # Check health
+#   curl http://localhost:8765/api/v1/vms # List VMs
+#   terraform apply                       # Use Terraform provider
+
+# Skip interactive bringup (rcloud server doesn't need test VMs)
+CONFIG_SKIP_BRINGUP=y
+
+# Disable test workflows (this is a cloud infrastructure server)
+CONFIG_WORKFLOWS=n
+
+# Enable guestfs for base image management
+CONFIG_GUESTFS=y
+
+# Use Debian nocloud variant for local VM testing
+# The nocloud variant doesn't have cloud-init and is designed for bare metal/local use
+# The generic variant requires cloud-init which virt-builder removes, breaking networking
+CONFIG_GUESTFS_DEBIAN_TRIXIE_NOCLOUD_AMD64=y
+
+# Don't copy host APT sources to guest base images
+# Base images should use standard Debian repositories for reliability
+# Custom repositories can be added during per-user VM customization
+# Note: Must disable GUESTFS_DEBIAN_COPY_HOST_SOURCES (not COPY_SOURCES directly)
+# because Kconfig 'select' cannot be overridden
+CONFIG_GUESTFS_DEBIAN_COPY_HOST_SOURCES=n
+
+# Enable rcloud REST API server
+CONFIG_RCLOUD=y
+CONFIG_RCLOUD_SERVER_BIND="127.0.0.1:8765"
+CONFIG_RCLOUD_WORKERS=4
+CONFIG_RCLOUD_ENABLE_TERRAFORM_PROVIDER=y

defconfigs/rcloud-guest-test

@@ -0,0 +1,58 @@
+# rcloud user/client configuration
+#
+# PURPOSE: Provision VMs through rcloud REST API using Terraform
+#
+# This defconfig is for USERS who want to provision VMs through an existing
+# rcloud server. The admin must have already set up the rcloud server using
+# defconfig-rcloud.
+#
+# Typical workflow:
+#   # Admin setup (one time):
+#   make defconfig-rcloud
+#   make
+#   make rcloud            # Sets up rcloud server and base images
+#
+#   # User workflow (on same system or remotely):
+#   make defconfig-rcloud-guest-test
+#   make
+#   make bringup           # Provisions VMs through rcloud API using Terraform
+#
+# This treats rcloud as a local cloud provider, just like AWS or Azure.
+# Users provision VMs through the standard Terraform workflow.
+
+# Basic system configuration
+CONFIG_KDEVOPS_HOSTS_PREFIX="rcloud-test"
+
+# Number of VMs to create
+CONFIG_KDEVOPS_NODES=1
+
+# VM resources (requested from rcloud)
+CONFIG_LIBVIRT_MACHINE_TYPE_Q35=y
+CONFIG_LIBVIRT_HOST_PASSTHROUGH=y
+CONFIG_LIBVIRT_MEMORY_MB=4096
+CONFIG_LIBVIRT_VCPUS=2
+
+# Disk configuration
+CONFIG_LIBVIRT_EXTRA_STORAGE_DRIVE_NVME=y
+CONFIG_LIBVIRT_NVME_DISK_SIZE_GIB=50
+
+# Disable test workflows (rcloud provides the infrastructure)
+CONFIG_WORKFLOWS=n
+
+# Use Terraform to provision VMs through rcloud API
+# This treats rcloud as a local cloud provider, similar to AWS/Azure
+CONFIG_TERRAFORM=y
+CONFIG_TERRAFORM_RCLOUD=y
+CONFIG_TERRAFORM_RCLOUD_API_URL="http://localhost:8765"
+# Use nocloud variant to match the base image created by defconfig-rcloud
+# The nocloud variant doesn't have cloud-init and works better for local testing
+CONFIG_TERRAFORM_RCLOUD_BASE_IMAGE="debian-13-nocloud-amd64-daily.raw"
+
+# IMPORTANT: SSH key configuration for rcloud service
+# The rcloud service cannot access files in ~/.ssh/ due to directory permissions.
+# You MUST configure the SSH key path to a location accessible by the rcloud service.
+# Recommended: Store keys in your kdevops directory, for example:
+#   CONFIG_TERRAFORM_SSH_CONFIG_PUBKEY_FILE="/path/to/kdevops/kdevops_terraform.pub"
+# The private key path will automatically derive from the public key path (removes .pub suffix).
+# After loading this defconfig, run 'make menuconfig' and update the SSH paths under:
+#   "Bring up methods" -> "Terraform ssh configuration" -> "SSH public key file"

kconfigs/Kconfig.guestfs

@@ -64,6 +64,7 @@ config GUESTFS_DISTRO_SOURCE_AND_DEST_FILE
 	string
 	depends on GUESTFS_COPY_SOURCES_FROM_HOST_TO_GUEST
 	output yaml
+	default "/etc/apt/sources.list.d/debian.sources" if GUESTFS_DEBIAN_TRIXIE
 	default "/etc/apt/sources.list" if GUESTFS_DEBIAN
 
 endif

kconfigs/workflows/Kconfig

@@ -614,3 +614,5 @@ config KDEVOPS_WORKFLOW_NAME
 endif
 
 endif # WORKFLOWS
+
+source "workflows/rcloud/Kconfig"

playbooks/devconfig.yml

@@ -1,6 +1,6 @@
 ---
 - name: Configure developer environment on target systems
-  hosts: baseline:dev:service
+  hosts: all:!localhost
   gather_facts: false
   roles:
     - role: devconfig

playbooks/install-rcloud-deps.yml

@@ -0,0 +1,5 @@
+---
+- name: Install rcloud build dependencies
+  hosts: localhost
+  roles:
+    - role: install-rcloud-deps