base_image: use guest OS detection for Debian-specific packages

The virt-builder template was using the distro_debian_based variable to
determine which packages to install in guest images, but this variable
reflects the host OS rather than the guest OS. This caused installation
failures when creating Fedora guests from a Debian host, as the template
attempted to install Debian-specific packages like isc-dhcp-client and
ifupdown on Fedora systems where they don't exist.

Replace the host OS check with proper guest OS detection using the
virtbuilder_os_version variable, which contains the actual guest OS name
like "fedora-41" or "debian-13". This ensures Debian-specific networking
packages and configuration only apply to Debian and Ubuntu guests regardless
of the host operating system.

Additionally, consolidate locale configuration by moving it from the
trixie-specific block to the general Debian block. This ensures all
Debian-based guests get proper locale setup during image build, not just
Debian Trixie. The locale commands (locale-gen, update-locale) are
Debian-specific and safe to run during virt-builder image creation for
any Debian-based distribution.

This change enables creation of fedora-41 guests from debian hosts without
package installation failures or incorrect network configuration.

Link: https://lore.kernel.org/all/[email protected]/ [1]
Fixes: 9822799 ("devconfig: drop locales-all leftovers")
Reported-by: Chuck Lever <[email protected]>
Generated-by: Claude AI
Signed-off-by: Daniel Gomez <[email protected]>

Author: dkruces

playbooks/roles/base_image/templates/virt-builder.j2

@@ -29,7 +29,7 @@ root-password password:kdevops
 sm-unregister
 {% endif %}
 
-{% if distro_debian_based is defined and distro_debian_based %}
+{% if virtbuilder_os_version is defined and ('debian' in virtbuilder_os_version or 'ubuntu' in virtbuilder_os_version) %}
 {# Ugh, debian has to be told to bring up the network and regenerate ssh keys #}
 {# Hope we get that interface name right! #}
 install isc-dhcp-client,ifupdown
@@ -43,6 +43,13 @@ firstboot-command DEBIAN_FRONTEND=noninteractive DEBCONF_NONINTERACTIVE_SEEN=tru
 firstboot-command systemctl start ssh
 firstboot-command apt update && apt upgrade --yes
 uninstall unattended-upgrades
+write /etc/default/locale:LANG=en_US.UTF-8
+append-line /etc/default/locale:LANGUAGE=en_US:en
+write /etc/locale.gen:en_US.UTF-8 UTF-8
+run-command locale-gen en_US.UTF-8
+run-command update-locale LANG=en_US.UTF-8
+firstboot-command locale-gen en_US.UTF-8
+firstboot-command update-locale LANG=en_US.UTF-8
 
 {% if distro_debian_trixie is defined and distro_debian_trixie %}
 {# CONFIG_GUESTFS_COPY_SOURCES_FROM_HOST_TO_GUEST will not work #}
@@ -67,13 +74,6 @@ append-line /etc/nsswitch.conf:ethers:         db files
 append-line /etc/nsswitch.conf:rpc:            db files
 append-line /etc/nsswitch.conf:netgroup:       nis
 uninstall cloud-init
-write /etc/default/locale:LANG=en_US.UTF-8
-append-line /etc/default/locale:LANGUAGE=en_US:en
-write /etc/locale.gen:en_US.UTF-8 UTF-8
-run-command locale-gen en_US.UTF-8
-run-command update-locale LANG=en_US.UTF-8
-firstboot-command locale-gen en_US.UTF-8
-firstboot-command update-locale LANG=en_US.UTF-8
 firstboot-command systemctl stop ssh
 firstboot-command systemctl start ssh