Skip to content

Commit ee72aad

Browse files
committed
fstests: enable FSTESTS_WATCHDOG_RESET_HUNG_SYSTEMS on CI systems
CI systems will use something like: make defconfig-xfs LINUX_TREE=https://github.com/linux-kdevops/linux-xfs-kpd.git When this is used BOOTLINUX_TREE_SET_BY_CLI is y, and so we can just modify the existing distro heuristic for when a distro prefers a reset on hung system detection: HAVE_DISTRO_PREFERS_FSTESTS_WATCHDOG_RESET So we default that to y when BOOTLINUX_TREE_SET_BY_CLI is set. So with the above command we'd end up with: grep FSTESTS_WATCHDOG_RESET_HUNG_SYSTEMS .config CONFIG_FSTESTS_WATCHDOG_RESET_HUNG_SYSTEMS=y This will allow us to force a reset on a target node when libvirt is used, for guestfs we'll try sudo virsh reset. The default timeout is 60 minutes for a new test. Since each CI uses a "new" test, then that's our limit. We can later enhance this by leveraging prior art check.time values but we'd need to also match the soak duration configuration, so a bit more thought is required for this. For now this should suffice to at least test trying to see if we can pick up kernel crashes and if we reset a system accordingly. Post-mortem analysis of a crash to highlight a crash happened should be evaluated next, because as-is we'd just reset the system and kdevops would go on with the test, and its not clear if xunit picks up on the failed test. Signed-off-by: Luis Chamberlain <[email protected]>
1 parent 33bd44f commit ee72aad

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

workflows/fstests/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ config HAVE_DISTRO_PREFERS_FSTESTS_WATCHDOG_KILL
2020

2121
config HAVE_DISTRO_PREFERS_FSTESTS_WATCHDOG_RESET
2222
bool
23-
default n
23+
default BOOTLINUX_TREE_SET_BY_CLI
2424

2525
# This nameless bool is done so that when kconfig gets support to output a yaml
2626
# file we can simply remove the respective makefile entry which queries for this

0 commit comments

Comments
 (0)