Skip to content

Commit f169097

Browse files
committed
gen_hosts: remove 'write-your-own-template' placeholder text
During patch review, it was noted that the placeholder text 'write-your-own-template-for-...-workflow' was introduced in commit 71f085a4d77f ("kdevops: replace ansible hosts generation jinja2 templating") from kdevops-history and has been expanded to other templates. This placeholder text serves no functional purpose and should be replaced with proper template structure. The cxl.j2 and pynfs.j2 workflow templates contained these placeholders which have now been replaced with proper host definitions following the pattern used by other workflow templates. The templates now properly define: - The workflow host in [all] section - A [baseline] group with the workflow host - A workflow-specific group ([cxl] or [pynfs]) with the host - Proper ansible_python_interpreter variables for each group This cleanup ensures consistency across all workflow templates. Suggested-by: Daniel Gomez <[email protected]> Fixes: 40df5ef ("gen_hosts: use kdevops_workflow_name directly for template selection") Signed-off-by: Luis Chamberlain <[email protected]>
1 parent c884721 commit f169097

File tree

2 files changed

+26
-2
lines changed

2 files changed

+26
-2
lines changed
Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,19 @@
11
{# Workflow template for CXL #}
22
[all]
33
localhost ansible_connection=local
4-
write-your-own-template-for-cxl-workflow
4+
{{ kdevops_host_prefix }}-cxl
55

66
[all:vars]
77
ansible_python_interpreter = "{{ kdevops_python_interpreter }}"
8+
9+
[baseline]
10+
{{ kdevops_host_prefix }}-cxl
11+
12+
[baseline:vars]
13+
ansible_python_interpreter = "{{ kdevops_python_interpreter }}"
14+
15+
[cxl]
16+
{{ kdevops_host_prefix }}-cxl
17+
18+
[cxl:vars]
19+
ansible_python_interpreter = "{{ kdevops_python_interpreter }}"
Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,19 @@
11
{# Workflow template for pynfs #}
22
[all]
33
localhost ansible_connection=local
4-
write-your-own-template-for-pynfs-workflow
4+
{{ kdevops_host_prefix }}-pynfs
55

66
[all:vars]
77
ansible_python_interpreter = "{{ kdevops_python_interpreter }}"
8+
9+
[baseline]
10+
{{ kdevops_host_prefix }}-pynfs
11+
12+
[baseline:vars]
13+
ansible_python_interpreter = "{{ kdevops_python_interpreter }}"
14+
15+
[pynfs]
16+
{{ kdevops_host_prefix }}-pynfs
17+
18+
[pynfs:vars]
19+
ansible_python_interpreter = "{{ kdevops_python_interpreter }}"

0 commit comments

Comments
 (0)