Skip to content

Commit f5822ce

Browse files
committed
selftests: create /lib/firmware for firmware selftests
The first test which the firmware selftests runs assumes you have /lib/firmware directory created as we want to mount /lib/firmware onto tmpfs. This test was added via upstream Linux commit 901cff7cb9614 ("firmware_loader: load files from the mount namespace of init"). The test will fail if the directory does not exist. We'll send a fix for that, but in the meantime, ensure that kdevops creates the directory for us on the target test node. The test was failing because the directory does not exist, and it gives the impression the test fails, but this is false positive, the test needs improvement so to ensure the directory exists before it tries to mount. I'll send a fix after this. Signed-off-by: Luis Chamberlain <[email protected]>
1 parent 01084fc commit f5822ce

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

playbooks/roles/selftests/tasks/main.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,18 @@
8383
when:
8484
- selftests_section_firmware|bool
8585

86+
- name: Create /lib/firmware directory
87+
tags: [ 'selftests', 'deps' ]
88+
become: yes
89+
become_flags: 'su - -c'
90+
become_method: sudo
91+
file:
92+
path: "/lib/firmware"
93+
state: directory
94+
mode: '0755'
95+
when:
96+
- selftests_section_firmware|bool
97+
8698
- include_role:
8799
name: create_data_partition
88100
tags: [ 'data_partition' ]

0 commit comments

Comments
 (0)