backends: mark all functions as static

lumag · lumag · commit 8663f5c7b474 · 2023-10-02T17:33:13.000+03:00
Now as each backend exports data structure, mark all functions as
static.

Signed-off-by: Dmitry Baryshkov &lt;dmitry.baryshkov@linaro.org&gt;
diff --git a/alpaca.c b/alpaca.c
@@ -53,7 +53,7 @@ struct alpaca {
 static int alpaca_device_power(struct alpaca *alpaca, int on);
 static int alpaca_usb_device_power(struct alpaca *alpaca, int on);
 
-void *alpaca_open(struct device *dev)
+static void *alpaca_open(struct device *dev)
 {
 	struct alpaca *alpaca;
 
@@ -121,22 +121,22 @@ static int alpaca_power_off(struct device *dev)
 	return 0;
 }
 
-int alpaca_power(struct device *dev, bool on)
+static int alpaca_power(struct device *dev, bool on)
 {
 	if (on)
 		return alpaca_power_on(dev);
 	else
 		return alpaca_power_off(dev);
 }
 
-void alpaca_usb(struct device *dev, bool on)
+static void alpaca_usb(struct device *dev, bool on)
 {
 	struct alpaca *alpaca = dev->cdb;
 
 	alpaca_usb_device_power(alpaca, on);
 }
 
-void alpaca_key(struct device *dev, int key, bool asserted)
+static void alpaca_key(struct device *dev, int key, bool asserted)
 {
 	switch (key) {
 	case DEVICE_KEY_FASTBOOT:
diff --git a/cdb_assist.c b/cdb_assist.c
@@ -273,7 +273,7 @@ static int cdb_ctrl_write(struct cdb_assist *cdb, const char *buf, size_t len)
 	return write(cdb->control_tty, buf, len);
 }
 
-void *cdb_assist_open(struct device *dev)
+static void *cdb_assist_open(struct device *dev)
 {
 	struct cdb_assist *cdb;
 	int ret;
@@ -295,7 +295,7 @@ void *cdb_assist_open(struct device *dev)
 	return cdb;
 }
 
-void cdb_assist_close(struct device *dev)
+static void cdb_assist_close(struct device *dev)
 {
 	struct cdb_assist *cdb = dev->cdb;
 
@@ -311,14 +311,14 @@ static void cdb_power(struct cdb_assist *cdb, bool on)
 	cdb_ctrl_write(cdb, &cmd[on], 1);
 }
 
-void cdb_vbus(struct cdb_assist *cdb, bool on)
+static void cdb_vbus(struct cdb_assist *cdb, bool on)
 {
 	const char cmd[] = "vV";
 
 	cdb_ctrl_write(cdb, &cmd[on], 1);
 }
 
-int cdb_assist_power(struct device *dev, bool on)
+static int cdb_assist_power(struct device *dev, bool on)
 {
 	struct cdb_assist *cdb = dev->cdb;
 
@@ -327,23 +327,18 @@ int cdb_assist_power(struct device *dev, bool on)
 	return 0;
 }
 
-void cdb_assist_usb(struct device *dev, bool on)
+static void cdb_assist_usb(struct device *dev, bool on)
 {
 	cdb_vbus(dev->cdb, on);
 }
 
-void cdb_gpio(struct cdb_assist *cdb, int gpio, bool on)
+static void cdb_gpio(struct cdb_assist *cdb, int gpio, bool on)
 {
 	const char *cmd[] = { "aA", "bB", "cC" };
 	cdb_ctrl_write(cdb, &cmd[gpio][on], 1);
 }
 
-unsigned int cdb_vref(struct cdb_assist *cdb)
-{
-	return cdb->vref;
-}
-
-void cdb_assist_print_status(struct device *dev)
+static void cdb_assist_print_status(struct device *dev)
 {
 	struct cdb_assist *cdb = dev->cdb;
 	char buf[128];
@@ -371,7 +366,7 @@ static void cdb_set_voltage(struct cdb_assist *cdb, unsigned mV)
 	cdb_ctrl_write(cdb, buf, n);
 }
 
-void cdb_assist_key(struct device *dev, int key, bool asserted)
+static void cdb_assist_key(struct device *dev, int key, bool asserted)
 {
 	struct cdb_assist *cdb = dev->cdb;
 
diff --git a/conmux.c b/conmux.c
@@ -224,7 +224,7 @@ static int conmux_data(int fd, void *data)
 	return 0;
 }
 
-void *conmux_open(struct device *dev)
+static void *conmux_open(struct device *dev)
 {
 	struct addrinfo hints = {0}, *addrs, *addr;
 	struct conmux_response resp = {};
@@ -297,7 +297,7 @@ void *conmux_open(struct device *dev)
 	return conmux;
 }
 
-int conmux_power_on(struct device *dev)
+static int conmux_power_on(struct device *dev)
 {
 	struct conmux *conmux = dev->cdb;
 	char sz[] = "~$hardreset\n";
@@ -317,22 +317,22 @@ static int conmux_power_off(struct device *dev)
 	return write(conmux->fd, sz, sizeof(sz));
 }
 
-int conmux_power(struct device *dev, bool on)
+static int conmux_power(struct device *dev, bool on)
 {
 	if (on)
 		return conmux_power_on(dev);
 	else
 		return conmux_power_off(dev);
 }
 
-int conmux_write(struct device *dev, const void *buf, size_t len)
+static int conmux_write(struct device *dev, const void *buf, size_t len)
 {
 	struct conmux *conmux = dev->cdb;
 
 	return write(conmux->fd, buf, len);
 }
 
-void *conmux_console_open(struct device *dev)
+static void *conmux_console_open(struct device *dev)
 {
 	return dev->cdb;
 }
diff --git a/console.c b/console.c
@@ -57,7 +57,7 @@ static int console_data(int fd, void *data)
 	return 0;
 }
 
-void *console_open(struct device *device)
+static void *console_open(struct device *device)
 {
 	struct console *console;
 
@@ -71,14 +71,14 @@ void *console_open(struct device *device)
 	return console;
 }
 
-int console_write(struct device *device, const void *buf, size_t len)
+static int console_write(struct device *device, const void *buf, size_t len)
 {
 	struct console *console = device->console;
 
 	return write(console->console_fd, buf, len);;
 }
 
-void console_send_break(struct device *device)
+static void console_send_break(struct device *device)
 {
 	struct console *console = device->console;
 
diff --git a/ftdi-gpio.c b/ftdi-gpio.c
@@ -159,7 +159,7 @@ static void ftdi_gpio_parse_config(struct ftdi_gpio *ftdi_gpio, char *control_de
 	}
 }
 
-void *ftdi_gpio_open(struct device *dev)
+static void *ftdi_gpio_open(struct device *dev)
 {
 	struct ftdi_gpio *ftdi_gpio;
 	int ret;
@@ -224,21 +224,21 @@ static void ftdi_gpio_device_usb(struct ftdi_gpio *ftdi_gpio, bool on)
 	ftdi_gpio_toggle_io(ftdi_gpio, GPIO_USB_DISCONNECT, on);
 }
 
-int ftdi_gpio_power(struct device *dev, bool on)
+static int ftdi_gpio_power(struct device *dev, bool on)
 {
 	struct ftdi_gpio *ftdi_gpio = dev->cdb;
 
 	return ftdi_gpio_device_power(ftdi_gpio, on);
 }
 
-void ftdi_gpio_usb(struct device *dev, bool on)
+static void ftdi_gpio_usb(struct device *dev, bool on)
 {
 	struct ftdi_gpio *ftdi_gpio = dev->cdb;
 
 	ftdi_gpio_device_usb(ftdi_gpio, on);
 }
 
-void ftdi_gpio_key(struct device *dev, int key, bool asserted)
+static void ftdi_gpio_key(struct device *dev, int key, bool asserted)
 {
 	struct ftdi_gpio *ftdi_gpio = dev->cdb;
 
diff --git a/qcomlt_dbg.c b/qcomlt_dbg.c
@@ -50,7 +50,7 @@ struct qcomlt_dbg {
 	struct termios orig_tios;
 };
 
-void *qcomlt_dbg_open(struct device *dev)
+static void *qcomlt_dbg_open(struct device *dev)
 {
 	struct qcomlt_dbg *dbg;
 
@@ -68,23 +68,23 @@ void *qcomlt_dbg_open(struct device *dev)
 	return dbg;
 }
 
-int qcomlt_dbg_power(struct device *dev, bool on)
+static int qcomlt_dbg_power(struct device *dev, bool on)
 {
 	struct qcomlt_dbg *dbg = dev->cdb;	
 
 	// fprintf(stderr, "qcomlt_dbg_power(%d)\n", on);
 	return write(dbg->fd, &("pP"[on]), 1);
 }
 
-void qcomlt_dbg_usb(struct device *dev, bool on)
+static void qcomlt_dbg_usb(struct device *dev, bool on)
 {
 	struct qcomlt_dbg *dbg = dev->cdb;	
 
 	// fprintf(stderr, "qcomlt_dbg_usb(%d)\n", on);
 	write(dbg->fd, &("uU"[on]), 1);
 }
 
-void qcomlt_dbg_key(struct device *dev, int key, bool asserted)
+static void qcomlt_dbg_key(struct device *dev, int key, bool asserted)
 {
 	struct qcomlt_dbg *dbg = dev->cdb;	
 

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ struct alpaca {`
`53`	`53`	`static int alpaca_device_power(struct alpaca *alpaca, int on);`
`54`	`54`	`static int alpaca_usb_device_power(struct alpaca *alpaca, int on);`
`55`	`55`
`56`		`-void alpaca_open(struct device dev)`
	`56`	`+static void alpaca_open(struct device dev)`
`57`	`57`	`{`
`58`	`58`	`struct alpaca *alpaca;`
`59`	`59`
`@@ -121,22 +121,22 @@ static int alpaca_power_off(struct device *dev)`
`121`	`121`	`return 0;`
`122`	`122`	`}`
`123`	`123`
`124`		`-int alpaca_power(struct device *dev, bool on)`
	`124`	`+static int alpaca_power(struct device *dev, bool on)`
`125`	`125`	`{`
`126`	`126`	`if (on)`
`127`	`127`	`return alpaca_power_on(dev);`
`128`	`128`	`else`
`129`	`129`	`return alpaca_power_off(dev);`
`130`	`130`	`}`
`131`	`131`
`132`		`-void alpaca_usb(struct device *dev, bool on)`
	`132`	`+static void alpaca_usb(struct device *dev, bool on)`
`133`	`133`	`{`
`134`	`134`	`struct alpaca *alpaca = dev->cdb;`
`135`	`135`
`136`	`136`	`alpaca_usb_device_power(alpaca, on);`
`137`	`137`	`}`
`138`	`138`
`139`		`-void alpaca_key(struct device *dev, int key, bool asserted)`
	`139`	`+static void alpaca_key(struct device *dev, int key, bool asserted)`
`140`	`140`	`{`
`141`	`141`	`switch (key) {`
`142`	`142`	`case DEVICE_KEY_FASTBOOT:`
Original file line number	Diff line number	Diff line change
`@@ -273,7 +273,7 @@ static int cdb_ctrl_write(struct cdb_assist cdb, const char buf, size_t len)`
`273`	`273`	`return write(cdb->control_tty, buf, len);`
`274`	`274`	`}`
`275`	`275`
`276`		`-void cdb_assist_open(struct device dev)`
	`276`	`+static void cdb_assist_open(struct device dev)`
`277`	`277`	`{`
`278`	`278`	`struct cdb_assist *cdb;`
`279`	`279`	`int ret;`
`@@ -295,7 +295,7 @@ void cdb_assist_open(struct device dev)`
`295`	`295`	`return cdb;`
`296`	`296`	`}`
`297`	`297`
`298`		`-void cdb_assist_close(struct device *dev)`
	`298`	`+static void cdb_assist_close(struct device *dev)`
`299`	`299`	`{`
`300`	`300`	`struct cdb_assist *cdb = dev->cdb;`
`301`	`301`
`@@ -311,14 +311,14 @@ static void cdb_power(struct cdb_assist *cdb, bool on)`
`311`	`311`	`cdb_ctrl_write(cdb, &cmd[on], 1);`
`312`	`312`	`}`
`313`	`313`
`314`		`-void cdb_vbus(struct cdb_assist *cdb, bool on)`
	`314`	`+static void cdb_vbus(struct cdb_assist *cdb, bool on)`
`315`	`315`	`{`
`316`	`316`	`const char cmd[] = "vV";`
`317`	`317`
`318`	`318`	`cdb_ctrl_write(cdb, &cmd[on], 1);`
`319`	`319`	`}`
`320`	`320`
`321`		`-int cdb_assist_power(struct device *dev, bool on)`
	`321`	`+static int cdb_assist_power(struct device *dev, bool on)`
`322`	`322`	`{`
`323`	`323`	`struct cdb_assist *cdb = dev->cdb;`
`324`	`324`
`@@ -327,23 +327,18 @@ int cdb_assist_power(struct device *dev, bool on)`
`327`	`327`	`return 0;`
`328`	`328`	`}`
`329`	`329`
`330`		`-void cdb_assist_usb(struct device *dev, bool on)`
	`330`	`+static void cdb_assist_usb(struct device *dev, bool on)`
`331`	`331`	`{`
`332`	`332`	`cdb_vbus(dev->cdb, on);`
`333`	`333`	`}`
`334`	`334`
`335`		`-void cdb_gpio(struct cdb_assist *cdb, int gpio, bool on)`
	`335`	`+static void cdb_gpio(struct cdb_assist *cdb, int gpio, bool on)`
`336`	`336`	`{`
`337`	`337`	`const char *cmd[] = { "aA", "bB", "cC" };`
`338`	`338`	`cdb_ctrl_write(cdb, &cmd[gpio][on], 1);`
`339`	`339`	`}`
`340`	`340`
`341`		`-unsigned int cdb_vref(struct cdb_assist *cdb)`
`342`		`-{`
`343`		`- return cdb->vref;`
`344`		`-}`
`345`		`-`
`346`		`-void cdb_assist_print_status(struct device *dev)`
	`341`	`+static void cdb_assist_print_status(struct device *dev)`
`347`	`342`	`{`
`348`	`343`	`struct cdb_assist *cdb = dev->cdb;`
`349`	`344`	`char buf[128];`
`@@ -371,7 +366,7 @@ static void cdb_set_voltage(struct cdb_assist *cdb, unsigned mV)`
`371`	`366`	`cdb_ctrl_write(cdb, buf, n);`
`372`	`367`	`}`
`373`	`368`
`374`		`-void cdb_assist_key(struct device *dev, int key, bool asserted)`
	`369`	`+static void cdb_assist_key(struct device *dev, int key, bool asserted)`
`375`	`370`	`{`
`376`	`371`	`struct cdb_assist *cdb = dev->cdb;`
`377`	`372`
Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,7 @@ static int conmux_data(int fd, void *data)`
`224`	`224`	`return 0;`
`225`	`225`	`}`
`226`	`226`
`227`		`-void conmux_open(struct device dev)`
	`227`	`+static void conmux_open(struct device dev)`
`228`	`228`	`{`
`229`	`229`	`struct addrinfo hints = {0}, addrs, addr;`
`230`	`230`	`struct conmux_response resp = {};`
`@@ -297,7 +297,7 @@ void conmux_open(struct device dev)`
`297`	`297`	`return conmux;`
`298`	`298`	`}`
`299`	`299`
`300`		`-int conmux_power_on(struct device *dev)`
	`300`	`+static int conmux_power_on(struct device *dev)`
`301`	`301`	`{`
`302`	`302`	`struct conmux *conmux = dev->cdb;`
`303`	`303`	`char sz[] = "~$hardreset\n";`
`@@ -317,22 +317,22 @@ static int conmux_power_off(struct device *dev)`
`317`	`317`	`return write(conmux->fd, sz, sizeof(sz));`
`318`	`318`	`}`
`319`	`319`
`320`		`-int conmux_power(struct device *dev, bool on)`
	`320`	`+static int conmux_power(struct device *dev, bool on)`
`321`	`321`	`{`
`322`	`322`	`if (on)`
`323`	`323`	`return conmux_power_on(dev);`
`324`	`324`	`else`
`325`	`325`	`return conmux_power_off(dev);`
`326`	`326`	`}`
`327`	`327`
`328`		`-int conmux_write(struct device dev, const void buf, size_t len)`
	`328`	`+static int conmux_write(struct device dev, const void buf, size_t len)`
`329`	`329`	`{`
`330`	`330`	`struct conmux *conmux = dev->cdb;`
`331`	`331`
`332`	`332`	`return write(conmux->fd, buf, len);`
`333`	`333`	`}`
`334`	`334`
`335`		`-void conmux_console_open(struct device dev)`
	`335`	`+static void conmux_console_open(struct device dev)`
`336`	`336`	`{`
`337`	`337`	`return dev->cdb;`
`338`	`338`	`}`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ static int console_data(int fd, void *data)`
`57`	`57`	`return 0;`
`58`	`58`	`}`
`59`	`59`
`60`		`-void console_open(struct device device)`
	`60`	`+static void console_open(struct device device)`
`61`	`61`	`{`
`62`	`62`	`struct console *console;`
`63`	`63`
`@@ -71,14 +71,14 @@ void console_open(struct device device)`
`71`	`71`	`return console;`
`72`	`72`	`}`
`73`	`73`
`74`		`-int console_write(struct device device, const void buf, size_t len)`
	`74`	`+static int console_write(struct device device, const void buf, size_t len)`
`75`	`75`	`{`
`76`	`76`	`struct console *console = device->console;`
`77`	`77`
`78`	`78`	`return write(console->console_fd, buf, len);;`
`79`	`79`	`}`
`80`	`80`
`81`		`-void console_send_break(struct device *device)`
	`81`	`+static void console_send_break(struct device *device)`
`82`	`82`	`{`
`83`	`83`	`struct console *console = device->console;`
`84`	`84`
Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ static void ftdi_gpio_parse_config(struct ftdi_gpio ftdi_gpio, char control_de`
`159`	`159`	`}`
`160`	`160`	`}`
`161`	`161`
`162`		`-void ftdi_gpio_open(struct device dev)`
	`162`	`+static void ftdi_gpio_open(struct device dev)`
`163`	`163`	`{`
`164`	`164`	`struct ftdi_gpio *ftdi_gpio;`
`165`	`165`	`int ret;`
`@@ -224,21 +224,21 @@ static void ftdi_gpio_device_usb(struct ftdi_gpio *ftdi_gpio, bool on)`
`224`	`224`	`ftdi_gpio_toggle_io(ftdi_gpio, GPIO_USB_DISCONNECT, on);`
`225`	`225`	`}`
`226`	`226`
`227`		`-int ftdi_gpio_power(struct device *dev, bool on)`
	`227`	`+static int ftdi_gpio_power(struct device *dev, bool on)`
`228`	`228`	`{`
`229`	`229`	`struct ftdi_gpio *ftdi_gpio = dev->cdb;`
`230`	`230`
`231`	`231`	`return ftdi_gpio_device_power(ftdi_gpio, on);`
`232`	`232`	`}`
`233`	`233`
`234`		`-void ftdi_gpio_usb(struct device *dev, bool on)`
	`234`	`+static void ftdi_gpio_usb(struct device *dev, bool on)`
`235`	`235`	`{`
`236`	`236`	`struct ftdi_gpio *ftdi_gpio = dev->cdb;`
`237`	`237`
`238`	`238`	`ftdi_gpio_device_usb(ftdi_gpio, on);`
`239`	`239`	`}`
`240`	`240`
`241`		`-void ftdi_gpio_key(struct device *dev, int key, bool asserted)`
	`241`	`+static void ftdi_gpio_key(struct device *dev, int key, bool asserted)`
`242`	`242`	`{`
`243`	`243`	`struct ftdi_gpio *ftdi_gpio = dev->cdb;`
`244`	`244`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ struct qcomlt_dbg {`
`50`	`50`	`struct termios orig_tios;`
`51`	`51`	`};`
`52`	`52`
`53`		`-void qcomlt_dbg_open(struct device dev)`
	`53`	`+static void qcomlt_dbg_open(struct device dev)`
`54`	`54`	`{`
`55`	`55`	`struct qcomlt_dbg *dbg;`
`56`	`56`
`@@ -68,23 +68,23 @@ void qcomlt_dbg_open(struct device dev)`
`68`	`68`	`return dbg;`
`69`	`69`	`}`
`70`	`70`
`71`		`-int qcomlt_dbg_power(struct device *dev, bool on)`
	`71`	`+static int qcomlt_dbg_power(struct device *dev, bool on)`
`72`	`72`	`{`
`73`	`73`	`struct qcomlt_dbg *dbg = dev->cdb;`
`74`	`74`
`75`	`75`	`// fprintf(stderr, "qcomlt_dbg_power(%d)\n", on);`
`76`	`76`	`return write(dbg->fd, &("pP"[on]), 1);`
`77`	`77`	`}`
`78`	`78`
`79`		`-void qcomlt_dbg_usb(struct device *dev, bool on)`
	`79`	`+static void qcomlt_dbg_usb(struct device *dev, bool on)`
`80`	`80`	`{`
`81`	`81`	`struct qcomlt_dbg *dbg = dev->cdb;`
`82`	`82`
`83`	`83`	`// fprintf(stderr, "qcomlt_dbg_usb(%d)\n", on);`
`84`	`84`	`write(dbg->fd, &("uU"[on]), 1);`
`85`	`85`	`}`
`86`	`86`
`87`		`-void qcomlt_dbg_key(struct device *dev, int key, bool asserted)`
	`87`	`+static void qcomlt_dbg_key(struct device *dev, int key, bool asserted)`
`88`	`88`	`{`
`89`	`89`	`struct qcomlt_dbg *dbg = dev->cdb;`
`90`	`90`