Skip to content

Commit 2d8ea74

Browse files
quic-bjorandeandersson
authored andcommitted
sahara: Improve error message about missing images
It might not be obvious to the user that an "invalid image id" is the result of them not providing the correct programmer loaders. Make the error message more user friendly. Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
1 parent 44e7be0 commit 2d8ea74

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

sahara.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,8 @@ static void sahara_read(struct qdl_device *qdl, struct sahara_pkt *pkt,
160160

161161
image_idx = pkt->read_req.image;
162162
if (image_idx >= MAPPING_SZ || !images[image_idx].ptr) {
163-
ux_err("device requested invalid image: %u\n", image_idx);
163+
ux_err("device requested unknown image id %u, ensure that all Sahara images are provided\n",
164+
image_idx);
164165
sahara_send_reset(qdl);
165166
return;
166167
}
@@ -195,7 +196,8 @@ static void sahara_read64(struct qdl_device *qdl, struct sahara_pkt *pkt,
195196

196197
image_idx = pkt->read64_req.image;
197198
if (image_idx >= MAPPING_SZ || !images[image_idx].ptr) {
198-
ux_err("device requested invalid image: %u\n", image_idx);
199+
ux_err("device requested unknown image id %u, ensure that all Sahara images are provided\n",
200+
image_idx);
199201
sahara_send_reset(qdl);
200202
return;
201203
}

0 commit comments

Comments
 (0)