tests: create temp files after skip check

We have a bunch of skip checks, which prevent tests from
running if the test doesn't apply (e.g. shellcheck when
commit has no shell scripts). Make sure we create temp
files for output only after the check, otherwise we
won't delete them.

Signed-off-by: Jakub Kicinski <[email protected]>

Author: kuba-moo

tests/patch/build_clang_rust/build_clang_rust.sh

@@ -7,8 +7,6 @@ cc=clang
 output_dir=build_clang_rust/
 ncpu=$(grep -c processor /proc/cpuinfo)
 build_flags="-Oline -j $ncpu W=1"
-tmpfile_o=$(mktemp)
-tmpfile_n=$(mktemp)
 rc=0
 
 prep_config() {
@@ -94,6 +92,9 @@ echo "Baseline building the tree"
 prep_config
 make LLVM=1 O=$output_dir $build_flags
 
+tmpfile_o=$(mktemp)
+tmpfile_n=$(mktemp)
+
 git checkout -q HEAD~
 
 echo "Building the tree before the patch"

tests/patch/build_tools/build_tools.sh

@@ -4,8 +4,6 @@
 output_dir=build_tools/
 ncpu=$(grep -c processor /proc/cpuinfo)
 build_flags="-Oline -j $ncpu"
-tmpfile_o=$(mktemp)
-tmpfile_n=$(mktemp)
 rc=0
 
 pr() {
@@ -18,6 +16,9 @@ if ! git diff --name-only HEAD~ | grep -q -E "^(include)|(tools)/"; then
     exit 0
 fi
 
+tmpfile_o=$(mktemp)
+tmpfile_n=$(mktemp)
+
 # Looks like tools inherit WERROR, otherwise
 make O=$output_dir allmodconfig
 ./scripts/config --file $output_dir/.config -d werror

tests/patch/pylint/pylint.sh

@@ -2,8 +2,6 @@
 # SPDX-License-Identifier: GPL-2.0
 
 HEAD=$(git rev-parse HEAD)
-tmpfile_o=$(mktemp)
-tmpfile_n=$(mktemp)
 rc=0
 
 pr() {
@@ -17,6 +15,9 @@ then
     exit 0
 fi
 
+tmpfile_o=$(mktemp)
+tmpfile_n=$(mktemp)
+
 echo "Redirect to $tmpfile_o and $tmpfile_n"
 
 echo "Tree base:"

tests/patch/shellcheck/shellcheck.sh

@@ -2,8 +2,6 @@
 # SPDX-License-Identifier: GPL-2.0
 
 HEAD=$(git rev-parse HEAD)
-tmpfile_o=$(mktemp)
-tmpfile_n=$(mktemp)
 rc=0
 
 pr() {
@@ -17,6 +15,9 @@ then
     exit 0
 fi
 
+tmpfile_o=$(mktemp)
+tmpfile_n=$(mktemp)
+
 echo "Redirect to $tmpfile_o and $tmpfile_n"
 
 echo "Tree base:"