build: replace AppImage with static build binary

The AppImage build was introduced to give users access to a test binary.
Before the switch to meson, the static build was used for this. In the
meantime we figured out how to build a static build with meson, so there
is no need for the AppImage workflow.

Start to add to the release versions of nvme the tag as postfix.
Furthermore, upload the artifacts to github.

Signed-off-by: Daniel Wagner <[email protected]>
Co-authored-by: Dennis Maisenbacher <[email protected]>

Author: igaw

.github/AppImageBuilder.yml

@@ -0,0 +1,86 @@
+name: upload
+
+on:
+  push:
+    branches: [master]
+  release:
+    types: [published]
+
+jobs:
+  build-static:
+    name: build static binary
+    runs-on: ubuntu-latest
+    container:
+      image: ghcr.io/linux-nvme/debian:latest
+    outputs:
+      VERSION: ${{ steps.build.outputs.VERSION }}
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: build
+        id: build
+        run: |
+          git config --global --add safe.directory "$GITHUB_WORKSPACE"
+          VERSION="$(git describe --always --abbrev=12 --dirty)"
+          echo "VERSION=${VERSION}" >> $GITHUB_OUTPUT
+          echo $VERSION
+
+          scripts/build.sh static
+          mkdir upload
+          cp .build-ci/nvme upload/nvme-cli-latest-x86_64
+          if [ "${GITHUB_EVENT_NAME}" = "release" ]; then
+            cp .build-ci/nvme "upload/nvme-cli-${VERSION}-x86_64"
+          fi
+
+      - uses: actions/upload-artifact@v4
+        name: upload artifacts to github
+        with:
+          name: nvme-cli
+          path: upload/*
+
+  upload-test-binary:
+    name: upload test binary
+    runs-on: ubuntu-latest
+    needs: build-static
+    if: ${{ github.event_name == 'push' || github.event_name == 'release' }}
+    steps:
+      - uses: actions/download-artifact@v4
+        with:
+          name: nvme-cli
+          path: upload
+
+      - name: FTP Deployer
+        uses: sand4rt/[email protected]
+        with:
+          sftp: true
+          host: ${{ secrets.SFTP_SERVER }}
+          port: 22
+          username: ${{ secrets.SFTP_USERNAME }}
+          password: ${{ secrets.SFTP_PASSWORD }}
+          remote_folder: '/upload'
+          local_folder: upload
+          cleanup: false
+          include: '[ "nvme-cli-*" ]'
+          exclude: '[".github/**", ".git/**", "*.env"]'
+
+  upload-release-assets:
+    name: upload GitHub release assets
+    runs-on: ubuntu-latest
+    needs: build-static
+    env:
+      VERSION: ${{ needs.build-static.outputs.VERSION }}
+    if: ${{ github.event_name == 'release' }}
+    steps:
+      - uses: actions/download-artifact@v4
+        with:
+          name: nvme-cli
+          path: upload
+      - name: upload versioned binary
+        uses: actions/upload-release-asset@v1
+        with:
+          upload_url: ${{ github.event.release.upload_url }}
+          asset_path: upload/nvme-cli-${{ env.VERSION }}-x86_64
+          asset_name: nvme-cli-${{ env.VERSION }}-x86_64
+          asset_content_type: application/octet-stream

.github/workflows/appimage.yml

@@ -71,6 +71,7 @@ static:
 	meson setup ${BUILD-DIR} --buildtype=release \
 		--wrap-mode=forcefallback \
 		--default-library=static \
+		--prefix=/usr \
 		-Dc_link_args="-static" \
 		-Dlibnvme:default_library=static \
 		-Dlibnvme:keyutils=disabled \

.github/workflows/upload.yml

@@ -329,7 +329,7 @@ sees the complete file.
 
 ## Testing
 
-For testing purposes a x86_64 AppImage is build from the current HEAD and is
+For testing purposes a x86_64 static build from the current HEAD and is
 available here:
 
-https://monom.org/linux-nvme/upload/AppImage/nvme-cli-latest-x86_64.AppImage
+https://monom.org/linux-nvme/upload/nvme-cli-latest-x86_64

Makefile

@@ -21,7 +21,6 @@ usage() {
     echo "                      and build them as shared libraries"
     echo "  cross               use cross toolchain to build"
     echo "  coverage            build coverage report"
-    echo "  appimage            build AppImage target"
     echo "  distro              build libnvme and nvme-cli separately"
     echo "  docs                build documentation"
     echo "  static              build a static binary"
@@ -114,16 +113,6 @@ config_meson_coverage() {
         "${BUILDDIR}"
 }
 
-config_meson_appimage() {
-    CC="${CC}" "${MESON}" setup                 \
-        --werror                                \
-        --buildtype="${BUILDTYPE}"              \
-        --force-fallback-for=libnvme            \
-        --prefix=/usr                           \
-        -Dlibnvme:werror=false                  \
-        "${BUILDDIR}"
-}
-
 config_meson_docs() {
     CC="${CC}" "${MESON}" setup                 \
         -Ddocs=all                              \
@@ -139,6 +128,7 @@ config_meson_static() {
         --buildtype=release                     \
         --default-library=static                \
         --wrap-mode=forcefallback               \
+        --prefix=/usr                           \
         -Dc_link_args="-static"                 \
         -Dlibnvme:keyutils=disabled             \
         "${BUILDDIR}"
@@ -169,11 +159,6 @@ test_meson_coverage() {
     ninja -C "${BUILDDIR}" coverage --verbose
 }
 
-install_meson_appimage() {
-    "${MESON}" install                          \
-        -C "${BUILDDIR}"
-}
-
 install_meson_docs() {
     "${MESON}" install                          \
         -C "${BUILDDIR}"