Skip to content

Commit 94924df

Browse files
MaisenbacherDigaw
authored andcommitted
tests: Remove unneeded sleep statements
Removing sleep statements, which improves the test cases runtime. Signed-off-by: Dennis Maisenbacher <[email protected]>
1 parent 80796ea commit 94924df

File tree

4 files changed

+0
-14
lines changed

4 files changed

+0
-14
lines changed

tests/nvme_attach_detach_ns_test.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@
2929
5. Delete Namespace.
3030
"""
3131

32-
import time
33-
3432
from nvme_test import TestNVMe
3533

3634

@@ -59,7 +57,6 @@ def setUp(self):
5957
self.setup_log_dir(self.__class__.__name__)
6058
self.ctrl_id = self.get_ctrl_id()
6159
self.delete_all_ns()
62-
time.sleep(1)
6360

6461
def tearDown(self):
6562
"""

tests/nvme_create_max_ns_test.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@
2929
5. Delete all Namespaces.
3030
"""
3131

32-
import time
33-
3432
from nvme_test import TestNVMe
3533

3634

@@ -63,7 +61,6 @@ def setUp(self):
6361
self.max_ns = self.get_max_ns()
6462
self.ctrl_id = self.get_ctrl_id()
6563
self.delete_all_ns()
66-
time.sleep(1)
6764

6865
def tearDown(self):
6966
"""

tests/nvme_format_test.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
import json
4141
import math
4242
import subprocess
43-
import time
4443

4544
from nvme_test import TestNVMe
4645

@@ -76,7 +75,6 @@ def setUp(self):
7675
self.test_log_dir = self.log_dir + "/" + self.__class__.__name__
7776
self.setup_log_dir(self.__class__.__name__)
7877
self.delete_all_ns()
79-
time.sleep(1)
8078

8179
def tearDown(self):
8280
"""

tests/nvme_test.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
import stat
3131
import subprocess
3232
import sys
33-
import time
3433
import unittest
3534

3635
from nvme_test_logger import TestNVMeLogger
@@ -165,14 +164,12 @@ def nvme_reset_ctrl(self):
165164
stdout=subprocess.PIPE,
166165
encoding='utf-8')
167166
self.assertEqual(err, 0, "ERROR : nvme reset failed")
168-
time.sleep(5)
169167
rescan_cmd = "echo 1 > /sys/bus/pci/rescan"
170168
proc = subprocess.Popen(rescan_cmd,
171169
shell=True,
172170
stdout=subprocess.PIPE,
173171
stderr=subprocess.PIPE,
174172
encoding='utf-8')
175-
time.sleep(5)
176173
self.assertEqual(proc.wait(), 0, "ERROR : pci rescan failed")
177174

178175
def get_ctrl_id(self):
@@ -385,7 +382,6 @@ def create_and_validate_ns(self, nsid, nsze, ncap, flbas, dps):
385382
"""
386383
err = self.create_ns(nsze, ncap, flbas, dps)
387384
if err == 0:
388-
time.sleep(2)
389385
id_ns_cmd = f"{self.nvme_bin} id-ns {self.ctrl} " + \
390386
f"--namespace-id={str(nsid)}"
391387
err = subprocess.call(id_ns_cmd,
@@ -408,11 +404,9 @@ def attach_ns(self, ctrl_id, ns_id):
408404
shell=True,
409405
stdout=subprocess.PIPE,
410406
encoding='utf-8')
411-
time.sleep(5)
412407
if err == 0:
413408
# enumerate new namespace block device
414409
self.nvme_reset_ctrl()
415-
time.sleep(5)
416410
# check if new namespace block device exists
417411
err = 0 if stat.S_ISBLK(os.stat(self.ns1).st_mode) else 1
418412
return err

0 commit comments

Comments
 (0)