nvme: fix to use NVME_VAL() for CQ entry status field filter

ikegami-t · igaw · commit bc0c529e2622 · 2025-01-03T15:05:21.000+01:00
Previously used incorrectly NVME_GET() but not shifted the masked values.

Signed-off-by: Tokunori Ikegami &lt;ikegami.t@gmail.com&gt;
diff --git a/nvme.c b/nvme.c
@@ -4610,8 +4610,7 @@ static int get_feature_id(struct nvme_dev *dev, struct feat_cfg *cfg,
 
 static int filter_out_flags(int status)
 {
-	return status & (NVME_GET(NVME_SCT_MASK, SCT) |
-			 NVME_GET(NVME_SC_MASK, SC));
+	return status & (NVME_VAL(SCT) | NVME_VAL(SC));
 }
 
 static void get_feature_id_print(struct feat_cfg cfg, int err, __u32 result, void *buf)

Original file line number	Diff line number	Diff line change
`@@ -4610,8 +4610,7 @@ static int get_feature_id(struct nvme_dev dev, struct feat_cfg cfg,`
`4610`	`4610`
`4611`	`4611`	`static int filter_out_flags(int status)`
`4612`	`4612`	`{`
`4613`		`- return status & (NVME_GET(NVME_SCT_MASK, SCT) \|`
`4614`		`- NVME_GET(NVME_SC_MASK, SC));`
	`4613`	`+ return status & (NVME_VAL(SCT) \| NVME_VAL(SC));`
`4615`	`4614`	`}`
`4616`	`4615`
`4617`	`4616`	`static void get_feature_id_print(struct feat_cfg cfg, int err, __u32 result, void *buf)`