Skip to content

Commit d248701

Browse files
ikegami-tigaw
authored andcommitted
ocp: update internal-log command telemetry type description
Add host0 and host1 help documentation description. Signed-off-by: Tokunori Ikegami <[email protected]>
1 parent 6d3ee5f commit d248701

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

Documentation/nvme-ocp-internal-log.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,10 @@ OPTIONS
6464

6565
-t <type>::
6666
--telemetry-type=<type>::
67-
If set to 1, controller shall capture the Telemetry Host-Initiated data
67+
Set the telemetry type to 'host', 'host0', 'host1' or 'controller'.
68+
If set to host1, controller shall capture the Telemetry Host-Initiated data
6869
representing the internal state of the controller at the time the associated
69-
Get Log Page command is processed. If cleared to 0, controller shall not
70+
Get Log Page command is processed. If set to host0, controller shall not
7071
update this data.
7172

7273
EXAMPLES

completions/_nvme

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ _nvme () {
181181
local _internal_log
182182
_internal_log=(
183183
/dev/nvme':supply a device to use (required)'
184-
--telemetry-type=':Telemetry Type; host or controller generated'
184+
--telemetry-type=':Telemetry Type; host, host0, host1 or controller generated'
185185
-t':alias for --telemetry-type'
186186
--data-area=':Telemetry Data Area; 1 or 2'
187187
-a':alias for --data-area'

plugins/ocp/ocp-nvme.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1418,7 +1418,7 @@ static int ocp_telemetry_log(int argc, char **argv, struct command *cmd, struct
14181418
const char *output_format = "output format normal|json";
14191419
const char *data_area = "Telemetry Data Area; 1 or 2;\n"
14201420
"e.g. '-a 1 for Data Area 1.'\n'-a 2 for Data Areas 1 and 2.';\n";
1421-
const char *telemetry_type = "Telemetry Type; 'host' or 'controller'";
1421+
const char *telemetry_type = "Telemetry Type; 'host', 'host0', 'host1' or 'controller'";
14221422

14231423
struct nvme_dev *dev;
14241424
int err = 0;
@@ -1486,7 +1486,8 @@ static int ocp_telemetry_log(int argc, char **argv, struct command *cmd, struct
14861486
else if (!strcmp(opt.telemetry_type, "controller"))
14871487
tele_type = TELEMETRY_TYPE_CONTROLLER;
14881488
else {
1489-
nvme_show_error("telemetry-type should be host or controller.\n");
1489+
nvme_show_error(
1490+
"telemetry-type should be host, host0, host1 or controller.\n");
14901491
goto out;
14911492
}
14921493
} else {

0 commit comments

Comments
 (0)