tests: Namespace Granularity Controller Attribute support breaks all tests

[NateThornton]

When running any of the nvme tests, a controller that supports Namespace Granularity Attribute will fail in setUp(), with the call chain create_and_validate_ns() -> create-ns(). The create-ns command is run with --verbose option, which will elevate the log level to INFO, and thus the "enforce [nsze|ncap] alignment to %PRIx64 because of namespace granularity requirement" message will print every time. This causes the json parsing to fail.

Here, I print the command and the stdout:

nvme create-ns /dev/nvme0 --nsze=3750748848 --ncap=3750748848 --flbas=0 --dps=0 --verbose --output-format=json
enforce nsze alignment to 200 because of namespace granularity requirements
enforce ncap alignment to 200 because of namespace granularity requirements
{
  "create-ns":"success",
  "nsid":"1"
}

I'd be happy to fix this, but am looking for direction. Couple of solutions:

1. Drop the --verbose option in nvme_test.py
2. Only print the "enforce..." strings for normal output in nvme.c

Any preferences?

[igaw]

When --output-format=json is selected, only JSON should be printed even when --verbose is used. I'd say print_info and co should either be extended to print JSON formated output (likely overkill, IMO) or just made aware of the selection and silence it.

[NateThornton]

@igaw Would this modification to print_info and print_debug align with what you were envisioning?

// logging.h
#define print_info(...)					\
	do {						\
		if (is_printable_at_level(LOG_INFO))	\
			printf(__VA_ARGS__);		\
	} while (false)
#define print_debug(...)				\
	do {						\
		if (is_printable_at_level(LOG_DEBUG))	\
			printf(__VA_ARGS__);		\
	} while (false)

bool is_printable_at_level(int level);

// logging.c
bool is_printable_at_level(int level)
{
	return log_level >= level && strcmp(nvme_cfg.output_format, "normal") == 0;
}

[igaw]

Yes, this makes sense to me. Please send PR for this. Thanks!