Skip to content

[PW_SID:1029543] riscv-imsic/aplic: Preserve IMSIC and APLIC states during suspend #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: workflow__riscv__fixes
Choose a base branch
from
Open

[PW_SID:1029543] riscv-imsic/aplic: Preserve IMSIC and APLIC states during suspend #1170

wants to merge 2 commits into from

Conversation

@linux-riscv-bot
Copy link

@linux-riscv-bot linux-riscv-bot commented Dec 2, 2025

PR for series 1029543 applied to workflow__riscv__fixes

Name: riscv-imsic/aplic: Preserve IMSIC and APLIC states during suspend
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1029543
Version: 3

@nick650823
irqchip/riscv-imsic: Add a CPU pm notifier to restore the IMSIC on exit
e3fbaac 
The IMSIC might be reset when the system enters a low power state, but on
exit nothing restores the registers, which prevents interrupt delivery.
Solve this by registering a CPU power management notifier, which restores
the IMSIC on exit.

Reviewed-by: Yong-Xuan Wang <[email protected]>
Reviewed-by: Cyan Yang <[email protected]>
Reviewed-by: Anup Patel <[email protected]>
Reviewed-by: Nutty Liu <[email protected]>
Signed-off-by: Nick Hu <[email protected]>
Signed-off-by: Linux RISC-V bot <[email protected]>
@nick650823
irqchip/riscv-aplic: Preserve APLIC states across suspend/resume
b1543ad 
The APLIC states might be reset when the platform enters a low power
state, but the register states are not being preserved and restored,
which prevents interrupt delivery after the platform resumes.
Solve this by adding a syscore ops and a power management notifier to
preserve and restore the APLIC states on suspend and resume.

Reviewed-by: Yong-Xuan Wang <[email protected]>
Reviewed-by: Cyan Yang <[email protected]>
Reviewed-by: Nutty Liu <[email protected]>
Signed-off-by: Nick Hu <[email protected]>
Signed-off-by: Linux RISC-V bot <[email protected]>
@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 1: "[v3,1/2] irqchip/riscv-imsic: Add a CPU pm notifier to restore the IMSIC on exit"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 111.80 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 1: "[v3,1/2] irqchip/riscv-imsic: Add a CPU pm notifier to restore the IMSIC on exit"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1173.58 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 1: "[v3,1/2] irqchip/riscv-imsic: Add a CPU pm notifier to restore the IMSIC on exit"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1651.56 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 1: "[v3,1/2] irqchip/riscv-imsic: Add a CPU pm notifier to restore the IMSIC on exit"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 24.75 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 1: "[v3,1/2] irqchip/riscv-imsic: Add a CPU pm notifier to restore the IMSIC on exit"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 25.87 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 1: "[v3,1/2] irqchip/riscv-imsic: Add a CPU pm notifier to restore the IMSIC on exit"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.86 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 1: "[v3,1/2] irqchip/riscv-imsic: Add a CPU pm notifier to restore the IMSIC on exit"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 78.82 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 1: "[v3,1/2] irqchip/riscv-imsic: Add a CPU pm notifier to restore the IMSIC on exit"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 1: "[v3,1/2] irqchip/riscv-imsic: Add a CPU pm notifier to restore the IMSIC on exit"
kdoc
Desc: Detects for kdoc errors
Duration: 1.03 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 1: "[v3,1/2] irqchip/riscv-imsic: Add a CPU pm notifier to restore the IMSIC on exit"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 1: "[v3,1/2] irqchip/riscv-imsic: Add a CPU pm notifier to restore the IMSIC on exit"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 1: "[v3,1/2] irqchip/riscv-imsic: Add a CPU pm notifier to restore the IMSIC on exit"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 2: "[v3,2/2] irqchip/riscv-aplic: Preserve APLIC states across suspend/resume"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 111.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 2: "[v3,2/2] irqchip/riscv-aplic: Preserve APLIC states across suspend/resume"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1173.76 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 2: "[v3,2/2] irqchip/riscv-aplic: Preserve APLIC states across suspend/resume"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1652.84 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 2: "[v3,2/2] irqchip/riscv-aplic: Preserve APLIC states across suspend/resume"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 24.40 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 2: "[v3,2/2] irqchip/riscv-aplic: Preserve APLIC states across suspend/resume"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 25.97 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 2: "[v3,2/2] irqchip/riscv-aplic: Preserve APLIC states across suspend/resume"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 18.45 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 2: "[v3,2/2] irqchip/riscv-aplic: Preserve APLIC states across suspend/resume"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 79.03 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 2: "[v3,2/2] irqchip/riscv-aplic: Preserve APLIC states across suspend/resume"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 2: "[v3,2/2] irqchip/riscv-aplic: Preserve APLIC states across suspend/resume"
kdoc
Desc: Detects for kdoc errors
Duration: 0.98 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 2: "[v3,2/2] irqchip/riscv-aplic: Preserve APLIC states across suspend/resume"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 2: "[v3,2/2] irqchip/riscv-aplic: Preserve APLIC states across suspend/resume"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

linux-riscv-bot commented Dec 2, 2025

Patch 2: "[v3,2/2] irqchip/riscv-aplic: Preserve APLIC states across suspend/resume"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@linux-riscv-bot @nick650823