Fix linter warnings

Author: qzed

src/apps/perf/main.cpp

@@ -78,7 +78,7 @@ int run(const int argc, const char **argv)
 
 	const f64 n = casts::to<f64>(count);
 	const f64 mean = casts::to<f64>(total) / n;
-	const f64 stddev = std::sqrt(casts::to<f64>(total_of_squares) / n - mean * mean);
+	const f64 stddev = std::sqrt((casts::to<f64>(total_of_squares) / n) - (mean * mean));
 
 	spdlog::info("Ran {} times", count);
 	spdlog::info("Total: {}μs", total);

src/common/error.hpp

@@ -21,7 +21,7 @@ template <auto T>
 class Error : public std::runtime_error {
 public:
 	template <class... Args>
-	Error(Args... args) : std::runtime_error {msg(args...)}
+	Error(Args... args) : std::runtime_error {msg(std::move(args)...)}
 	{
 		/*
 		 * GCC doesn't see this block as empty, so adding a semicolon to the end to force

src/contacts/detection/algorithms/gaussian.hpp

@@ -77,10 +77,10 @@ void assemble_system(Matrix6<T> &m,
 	const Point &bmax = b.max();
 
 	for (Eigen::Index iy = bmin.y(); iy <= bmax.y(); iy++) {
-		const T y = casts::to<T>(iy) * scale.y() - 1;
+		const T y = (casts::to<T>(iy) * scale.y()) - 1;
 
 		for (Eigen::Index ix = bmin.x(); ix <= bmax.x(); ix++) {
-			const T x = casts::to<T>(ix) * scale.x() - 1;
+			const T x = (casts::to<T>(ix) * scale.x()) - 1;
 
 			const T d =
 				w(iy - bmin.y(), ix - bmin.x()) * gsl::narrow_cast<T>(data(iy, ix));
@@ -154,7 +154,7 @@ bool extract_params(const Vector6<T> &chi, T &scale, Vector2<T> &mean, Matrix2<T
 	mean.y() = (prec(0, 0) * chi[4] - prec(0, 1) * chi[3]) / d;
 
 	const T vtmv = mean.transpose() * prec * mean;
-	scale = std::exp(chi[5] + vtmv / casts::to<T>(2));
+	scale = std::exp(chi[5] + (vtmv / casts::to<T>(2)));
 
 	return true;
 }
@@ -184,10 +184,10 @@ void update_weight_maps(std::vector<Parameters<typename DenseBase<Derived>::Scal
 		const Point bmax = p.bounds.max();
 
 		for (Eigen::Index iy = bmin.y(); iy <= bmax.y(); iy++) {
-			const T y = casts::to<T>(iy) * scale.y() - 1;
+			const T y = (casts::to<T>(iy) * scale.y()) - 1;
 
 			for (Eigen::Index ix = bmin.x(); ix <= bmax.x(); ix++) {
-				const T x = casts::to<T>(ix) * scale.x() - 1;
+				const T x = (casts::to<T>(ix) * scale.x()) - 1;
 
 				const T v = p.scale * gaussian_like({x, y}, p.mean, p.prec);
 				p.weights(iy - bmin.y(), ix - bmin.x()) = v;
@@ -294,20 +294,20 @@ bool ge_solve(Matrix6<T> a, Vector6<T> b, Vector6<T> &x)
 	x[5] = b[5];
 	x[5] /= a(5, 5);
 
-	x[4] = b[4] - a(5, 4) * x[5];
+	x[4] = b[4] - (a(5, 4) * x[5]);
 	x[4] /= a(4, 4);
 
-	x[3] = b[3] - a(5, 3) * x[5] - a(4, 3) * x[4];
+	x[3] = b[3] - (a(5, 3) * x[5]) - (a(4, 3) * x[4]);
 	x[3] /= a(3, 3);
 
-	x[2] = b[2] - a(5, 2) * x[5] - a(4, 2) * x[4] - a(3, 2) * x[3];
+	x[2] = b[2] - (a(5, 2) * x[5]) - (a(4, 2) * x[4]) - (a(3, 2) * x[3]);
 	x[2] /= a(2, 2);
 
-	x[1] = b[1] - a(5, 1) * x[5] - a(4, 1) * x[4] - a(3, 1) * x[3] - a(2, 1) * x[2];
+	x[1] = b[1] - (a(5, 1) * x[5]) - (a(4, 1) * x[4]) - (a(3, 1) * x[3]) - (a(2, 1) * x[2]);
 	x[1] /= a(1, 1);
 
-	x[0] = b[0] - a(5, 0) * x[5] - a(4, 0) * x[4] - a(3, 0) * x[3] - a(2, 0) * x[2] -
-	       a(1, 0) * x[1];
+	x[0] = b[0] - (a(5, 0) * x[5]) - (a(4, 0) * x[4]) - (a(3, 0) * x[3]) - (a(2, 0) * x[2]) -
+	       (a(1, 0) * x[1]);
 	x[0] /= a(0, 0);
 
 	return true;

src/contacts/detection/algorithms/kernels.hpp

@@ -31,10 +31,10 @@ Matrix<T, Rows, Cols> gaussian(const T sigma)
 	const Eigen::Index rows = kernel.rows();
 
 	for (Eigen::Index y = 0; y < rows; y++) {
-		const T vy = casts::to<T>(y) - casts::to<T>(rows - 1) / casts::to<T>(2);
+		const T vy = casts::to<T>(y) - (casts::to<T>(rows - 1) / casts::to<T>(2));
 
 		for (Eigen::Index x = 0; x < cols; x++) {
-			const T vx = casts::to<T>(x) - casts::to<T>(cols - 1) / casts::to<T>(2);
+			const T vx = casts::to<T>(x) - (casts::to<T>(cols - 1) / casts::to<T>(2));
 
 			const T norm = (Vector2<T> {vy, vx} / sigma).squaredNorm();
 			const T val = std::exp(gsl::narrow_cast<T>(-0.5) * norm);

src/contacts/detection/algorithms/optimized/convolution.3x3-extend.hpp

@@ -40,7 +40,7 @@ inline void run_3x3(const DenseBase<DerivedData> &in,
 	};
 
 	const auto d = [&](Eigen::Index i, isize dx, isize dy) constexpr -> T {
-		const isize sdx = casts::to_signed(i) + dy * casts::to_signed(cols) + dx;
+		const isize sdx = casts::to_signed(i) + (dy * casts::to_signed(cols)) + dx;
 		const Eigen::Index index = casts::to_eigen(sdx);
 
 		if constexpr (common::buildopts::ForceAccessChecks) {

src/contacts/detection/algorithms/optimized/convolution.5x5-extend.hpp

@@ -40,7 +40,7 @@ void run_5x5(const DenseBase<DerivedData> &in,
 	};
 
 	const auto d = [&](Eigen::Index i, isize dx, isize dy) constexpr -> T {
-		const isize sdx = casts::to_signed(i) + dy * casts::to_signed(cols) + dx;
+		const isize sdx = casts::to_signed(i) + (dy * casts::to_signed(cols)) + dx;
 		const Eigen::Index index = casts::to_eigen(sdx);
 
 		if constexpr (common::buildopts::ForceAccessChecks) {

src/contacts/finder.hpp

@@ -37,7 +37,7 @@ class Finder {
 	validation::Validator<T> m_validator;
 
 public:
-	Finder(Config<T> config)
+	Finder(const Config<T> &config)
 		: m_detector {config.detection},
 		  m_stabilizer {config.stability},
 		  m_validator {config.validation} {};

src/core/generic/dft.hpp

@@ -174,7 +174,7 @@ class DftStylus {
 				xt *= m_config.width / m_config.dft_tilt_distance;
 				yt *= m_config.height / m_config.dft_tilt_distance;
 
-				const f64 azm = std::fmod(std::atan2(-yt, xt) + 2 * M_PI, 2 * M_PI);
+				const f64 azm = std::fmod(std::atan2(-yt, xt) + (2 * M_PI), 2 * M_PI);
 				const f64 alt = std::asin(std::min(1.0, std::hypot(xt, yt)));
 
 				m_stylus.azimuth = azm;
@@ -214,7 +214,7 @@ class DftStylus {
 			                 dft.y[0].imag[ipts::protocol::dft::NUM_COMPONENTS / 2];
 
 			// same phase as position signal = eraser, opposite phase = button
-			const i32 val = m_real * real + m_imag * imag;
+			const i32 val = (m_real * real) + (m_imag * imag);
 
 			button = val < 0;
 			rubber = val > 0;
@@ -340,9 +340,9 @@ class DftStylus {
 		const f64 cos = row.imag.at(maxi) / amp;
 
 		std::array<f64, 3> x = {
-			sin * row.real.at(maxi - 1) + cos * row.imag.at(maxi - 1),
+			(sin * row.real.at(maxi - 1)) + (cos * row.imag.at(maxi - 1)),
 			amp,
-			sin * row.real.at(maxi + 1) + cos * row.imag.at(maxi + 1),
+			(sin * row.real.at(maxi + 1)) + (cos * row.imag.at(maxi + 1)),
 		};
 
 		// convert the amplitudes into something we can fit a parabola to
@@ -414,11 +414,11 @@ class DftStylus {
 
 		// interpolate using Eric Jacobsen's modified quadratic estimator
 		const i32 ra = real[0] - real[2];
-		const i32 rb = 2 * real[1] - real[0] - real[2];
+		const i32 rb = (2 * real[1]) - real[0] - real[2];
 		const i32 ia = imag[0] - imag[2];
-		const i32 ib = 2 * imag[1] - imag[0] - imag[2];
+		const i32 ib = (2 * imag[1]) - imag[0] - imag[2];
 
-		const f64 d = (ra * rb + ia * ib) / casts::to<f64>(rb * rb + ib * ib);
+		const f64 d = (ra * rb + ia * ib) / casts::to<f64>((rb * rb) + (ib * ib));
 
 		return (maxi + std::clamp(d, mind, maxd)) / (rows - 1);
 	}

src/core/linux/runner.hpp

@@ -70,7 +70,7 @@ class Runner {
 		info.meta = m_ipts.metadata();
 
 		const ConfigLoader loader {info};
-		m_application.emplace(loader.config(), info, args...);
+		m_application.emplace(loader.config(), info, std::move(args)...);
 
 		m_buffer.resize(m_ipts.buffer_size());