Skip to content

Commit 7ef7212

Browse files
committed
tests: Actually test permanent ipset add/remove
Actually do what the `name:` suggests. Runtime mode is already checked above (looks like a copy pasta). Also, fix the name: of removing the ipset from the default zone.
1 parent c0be822 commit 7ef7212

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

tests/tests_ipsets.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@
126126
failed_when: result.stdout != item["expected"]
127127

128128
# Test that ipset can be added to zones
129-
- name: Add ipset to default zone
129+
- name: Add ipset to default zone (runtime)
130130
include_role:
131131
name: linux-system-roles.firewall
132132
vars:
@@ -135,7 +135,7 @@
135135
state: enabled
136136
runtime: true
137137

138-
- name: Add ipset to default zone again
138+
- name: Add ipset to default zone again (runtime)
139139
include_role:
140140
name: linux-system-roles.firewall
141141
vars:
@@ -157,7 +157,7 @@
157157
firewall:
158158
- source: "ipset:customipset"
159159
state: enabled
160-
runtime: true
160+
permanent: true
161161

162162
- name: Add ipset to default zone again (permanent)
163163
include_role:
@@ -166,15 +166,15 @@
166166
firewall:
167167
- source: "ipset:customipset"
168168
state: enabled
169-
runtime: true
169+
permanent: true
170170
register: result
171171

172172
- name: Fail if adding ipset is not idempotent (permanent)
173173
fail:
174174
msg: "enabling ipsets in zones is not idempotent (permanent)"
175175
when: result.changed | bool # noqa no-handler
176176

177-
- name: Add ipset to default zone
177+
- name: Remove ipset from default zone
178178
include_role:
179179
name: linux-system-roles.firewall
180180
vars:

0 commit comments

Comments
 (0)