chore: add sourcery-ai inspired improvements

Author: idevat

module_utils/ha_cluster_lsr/info/exporter/corosync_conf.py

@@ -40,12 +40,12 @@ def export_corosync_transport(corosync_conf_dict: SrcDict) -> Dict[str, Any]:
             corosync_conf_dict["transport_options"]
         )
     if corosync_conf_dict["links_options"]:
-        link_list = []
-        for link_dict in corosync_conf_dict["links_options"].values():
+        transport["links"] = [
             # linknumber is an index in links_options, but it is present in
             # link_dict as well
-            link_list.append(dict_to_nv_list(link_dict))
-        transport["links"] = link_list
+            dict_to_nv_list(link_dict)
+            for link_dict in corosync_conf_dict["links_options"].values()
+        ]
     if corosync_conf_dict["compression_options"]:
         transport["compression"] = dict_to_nv_list(
             corosync_conf_dict["compression_options"]

module_utils/ha_cluster_lsr/info/exporter/resources.py

@@ -66,14 +66,13 @@ def _nv_list(
     if skip_keys is None:
         skip_keys = []
 
-    nv_list = dict_to_nv_list(
+    return dict_to_nv_list(
         {
             (key_map[key] if key in key_map else key): value
             for key, value in input_dict.items()
             if not (is_none(value) or key in skip_keys)
         }
     )
-    return nv_list
 
 
 def _attrs(nvsets: _AttrsSrc) -> _Attrs:

module_utils/ha_cluster_lsr/info/exporter/various.py

@@ -114,13 +114,11 @@ def export_pcs_permission_list(
     """
     # Currently, only format version 2 is in use, so we don't check for file
     # format version
-    result: List[Dict[str, Any]] = []
-    for permission in pcs_settings_conf_dict["permissions"]["local_cluster"]:
-        result.append(
-            {
-                "type": permission["type"],
-                "name": permission["name"],
-                "allow_list": list(permission["allow"]),
-            }
-        )
-    return result
+    return [
+        {
+            "type": permission["type"],
+            "name": permission["name"],
+            "allow_list": list(permission["allow"]),
+        }
+        for permission in pcs_settings_conf_dict["permissions"]["local_cluster"]
+    ]