fix: Adjust for Ansible 2.19

- Ensure boolean values for `when:` conditions.
- Avoid `ansible_managed` variable, it's an internal constant.
- Remove jinja templates from assertions.

Author: martinpitt

handlers/main.yml

@@ -4,7 +4,7 @@
 - name: Handle nbde_client update initramfs
   when:
     - __nbde_client_update_initramfs | bool
-    - __nbde_client_initramfs_update_cmd | default("")
+    - __nbde_client_initramfs_update_cmd | default("") | length > 0
   command: "{{ __nbde_client_initramfs_update_cmd }}"
   changed_when: false
 

tasks/main-clevis.yml

@@ -24,7 +24,7 @@
 
 - name: Check whether devices are at the desired state
   when:
-    - nbde_client_bindings | default([])
+    - nbde_client_bindings | default([]) | length > 0
   nbde_client_clevis:
     bindings: "{{ nbde_client_bindings | default([]) }}"
   check_mode: true
@@ -41,7 +41,7 @@
         state: directory
         suffix: nbde_client_encryption_keys
       when:
-        - nbde_client_bindings | default([])
+        - nbde_client_bindings | default([]) | length > 0
       register: nbde_client_tempdir
 
     - name: Ensure we transfer key files
@@ -51,15 +51,15 @@
         mode: '0400'
       when:
         - nbde_client_tempdir.path is defined
-        - item.encryption_key_src | default("")
+        - item.encryption_key_src | default("") | length > 0
       loop: "{{ nbde_client_bindings }}"
       loop_control:
         label: "{{ item.encryption_key_src | default('') }}"
       no_log: true
 
     - name: Perform clevis operations
       when:
-        - nbde_client_bindings | default([])
+        - nbde_client_bindings | default([]) | length > 0
         - nbde_client_tempdir.path is defined
       nbde_client_clevis:
         bindings: "{{ nbde_client_bindings | default([]) }}"
@@ -78,7 +78,7 @@
         path: "{{ nbde_client_tempdir.path }}"
         state: absent
       when:
-        - nbde_client_bindings | default([])
+        - nbde_client_bindings | default([]) | length > 0
         - nbde_client_tempdir.path is defined
 
 - name: Deploy mechanism to clear network configuration generated during early boot

tests/tasks/check_header.yml

@@ -9,8 +9,8 @@
 - name: Check for presence of ansible managed header, fingerprint
   assert:
     that:
-      - ansible_managed in content
+      - __ansible_managed in content
       - __fingerprint in content
   vars:
     content: "{{ (__file_content | d(__content)).content | b64decode }}"
-    ansible_managed: "{{ lookup('template', 'get_ansible_managed.j2') }}"
+    __ansible_managed: "{{ lookup('template', 'get_ansible_managed.j2') }}"

tests/tests_default_vars.yml

@@ -9,8 +9,8 @@
             name: linux-system-roles.nbde_client
         - name: Assert that the role declares all parameters in defaults
           assert:
-            that: "{{ item }} is defined"
-          loop:
-            - nbde_client_provider
-            - nbde_client_bindings
+            that:
+              - nbde_client_provider is defined
+              - nbde_client_bindings is defined
+
 # vim:set ts=2 sw=2 et: