Skip to content

Commit bcfd2ee

Browse files
committed
fix: add support for EL10
According to the Ansible team, support for listing platforms in role `meta/main.yml` files is being removed. Instead, they recommend using `galaxy_tags` https://github.com/ansible/ansible/blob/stable-2.17/changelogs/CHANGELOG-v2.17.rst "Remove the galaxy_info field platforms from the role templates" ansible/ansible#82453 Many roles already have tags such as "rhel", "redhat", "centos", and "fedora". I propose that we ensure all of the system roles have these tags. Some of our roles support Suse, Debian, Ubuntu, and others. We should add tags for those e.g. the ssh role already has tags for "debian" and "ubuntu". In addition - for each version listed under `platforms.EL` - add a tag like `elN`. Q: Why not use a delimiter between the platform and the version e.g. `el-10`? This is not allowed by ansible-lint: ``` meta-no-tags: Tags must contain lowercase letters and digits only., invalid: 'el-10' meta/main.yml:1 ``` So we cannot use uppercase letters either. Q: Why not use our own meta/main.yml field? No other fields are allowed by ansible-lint: ``` syntax-check[specific]: 'myfield' is not a valid attribute for a RoleMetadata ``` Q: Why not use some other field? There are no other applicable or suitable fields. Q: What happens when we want to support versions like `N.M`? Use the word "dot" instead of "." e.g. `el10dot3`. Similarly - use "dash" instead of "-". We do not need tags such as `fedoraall`. The `fedora` tag implies that the role works on all supported versions of fedora. Otherwise, use tags such as `fedora40` if the role only supports specific versions. In addition - for roles that have different variable files for EL9, create the corresponding EL10 files. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
1 parent 5d1882b commit bcfd2ee

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

meta/main.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@
22
---
33
galaxy_info:
44
author: Sergio Correia <scorreia@redhat.com>
5-
description: >
6-
Ansible role for configuring Network-Bound Disk Encryption servers
7-
(e.g. tang)
5+
description: Ansible role for configuring Network-Bound Disk Encryption servers (e.g. tang)
6+
87
company: Red Hat, Inc.
98
license: MIT
109
min_ansible_version: "2.9"
@@ -17,14 +16,15 @@ galaxy_info:
1716
- "7"
1817
- "8"
1918
- "9"
20-
2119
galaxy_tags:
2220
- centos
21+
- clevis
22+
- el7
23+
- el8
24+
- el9
25+
- el10
2326
- fedora
24-
- redhat
2527
- nbde
26-
- clevis
28+
- redhat
2729
- tang
28-
2930
dependencies: []
30-
# vim:set ts=2 sw=2 et:

0 commit comments

Comments
 (0)