-
Notifications
You must be signed in to change notification settings - Fork 18
ci: skip most CI checks if title contains citest skip [citest_skip] #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a conditional to multiple GitHub Actions workflows so that most CI jobs are skipped when a pull request title contains the marker "[citest_skip]". Flow diagram for CI job execution based on PR title markerflowchart TD
A[PR_opened] --> B[Read_PR_title]
B --> C{Title_contains_citest_skip_marker}
C -- Yes --> D[Skip_selected_CI_jobs<br/>ansible_lint<br/>ansible_managed_var_comment<br/>codeql<br/>codespell<br/>markdownlint<br/>woke]
C -- No --> E[Run_all_configured_CI_jobs]
D --> F[PR_checks_complete]
E --> F
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Several workflows (e.g., codeql with a
scheduletrigger) can run on events other thanpull_request, but the condition unconditionally referencesgithub.event.pull_request.title; consider guarding the check withgithub.event_name == 'pull_request'(e.g.,if: github.event_name != 'pull_request' || !contains(github.event.pull_request.title, '[citest_skip]')) to avoid runtime evaluation issues on non-PR events. - If the intent is only to skip heavier jobs (e.g., ansible, qemu), you might want to revisit applying
[citest_skip]to lighter, fast-running checks like markdownlint, codespell, or woke so that basic validation still runs even when full CI is skipped.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Several workflows (e.g., codeql with a `schedule` trigger) can run on events other than `pull_request`, but the condition unconditionally references `github.event.pull_request.title`; consider guarding the check with `github.event_name == 'pull_request'` (e.g., `if: github.event_name != 'pull_request' || !contains(github.event.pull_request.title, '[citest_skip]')`) to avoid runtime evaluation issues on non-PR events.
- If the intent is only to skip heavier jobs (e.g., ansible, qemu), you might want to revisit applying `[citest_skip]` to lighter, fast-running checks like markdownlint, codespell, or woke so that basic validation still runs even when full CI is skipped.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
When we submit a PR for a CI update or docs, we do not want to start CI checking for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more roles, this fires off a lot of unnecessary tests, which sometimes causes the linux-system-roles org in github to be throttled. When submitting a PR that can skip ci, use "[citest_skip]" in the PR title. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
When we submit a PR for a CI update or docs, we do not want to start CI checking for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more roles, this fires off a lot of unnecessary tests, which sometimes causes the linux-system-roles org in github to be throttled. When submitting a PR that can skip ci, use "[citest_skip]" in the PR title. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we submit a PR for a CI update or docs, we do not want to start CI checking
for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more
roles, this fires off a lot of unnecessary tests, which sometimes causes the
linux-system-roles org in github to be throttled.
When submitting a PR that can skip ci, use "[citest_skip]" in the PR title.