ci: Pass in __bootc_validation as boolean, not string

[richm]

Pass in a YAML true value as __bootc_validation: true using
the --extra-vars option to ensure that __bootc_validation is
treated as a boolean and not a string value.

-e "__bootc_validation: true"

You can also use JSON format:

-e '{"__bootc_validation": true}'

but YAML is simpler in this case.

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Improve CI configuration by passing __bootc_validation as a boolean, updating tox-lsr version, and refining test rerun logic; add local CI testing instructions to the contribution guide.

CI:

• Bump tox-lsr dependency from v3.11.0 to v3.11.1 across GitHub Actions workflows
• Pass __bootc_validation as a YAML boolean (--extra-vars "__bootc_validation: true") instead of a plain string
• Extend tft_citest_bad workflow to consider cancelled runs as failures for reruns

Documentation:

• Add a detailed guide in contributing.md for running CI tests locally with tox-lsr and QEMU

[sourcery-ai]

Reviewer's Guide

This PR updates CI workflows to pass the __bootc_validation flag as a YAML boolean, bumps the tox-lsr dependency to version 3.11.1 across multiple workflows, extends the TF test runner to handle cancelled runs, and enhances the contributing guide with local CI testing instructions.

Flow diagram for local CI testing instructions in contributing guide

flowchart TD
  A["Enable EPEL repository"] --> B["Install standard-test-roles-inventory-qemu"]
  B --> C["Install tox"]
  C --> D["Install tox-lsr"]
  D --> E["Download linux-system-roles.json config file"]
  E --> F["Run tox with qemu options"]
  F --> G["Customize with options/env vars"]

Loading

File-Level Changes

Change	Details	Files
Pass __bootc_validation as a YAML boolean	Replaced -e __bootc_validation=true with -e "__bootc_validation: true" in the QEMU integration job	.github/workflows/qemu-kvm-integration-tests.yml
Bump tox-lsr version to 3.11.1	Updated pip install lines to use git+…@3.11.1 in all CI workflows	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Handle cancelled TF test runs	Extended the jq filter to include runs with conclusion failure or cancelled	.github/workflows/tft_citest_bad.yml
Add local CI testing instructions	Added a ‘Running CI Tests Locally’ section with step-by-step qemu and tox-lsr setup	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}