ci: rollout several recent changes to CI testing

[richm]

• Pass in a YAML true value as __bootc_validation: true using
  the --extra-vars option to ensure that __bootc_validation is
  treated as a boolean and not a string value.

-e "__bootc_validation: true"

You can also use JSON format:

-e '{"__bootc_validation": true}'

but YAML is simpler in this case.

• Use tox-lsr version 3.11.1

• Ensure the citest bad comment works when the test was cancelled in
  addition to the failure case.

• Update contributing.md documentation

• Update number of nodes to use in testing farm, if needed

• remove unnecessary ansible-lint skips

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Roll out recent improvements to CI testing by bumping tox-lsr, correctly passing boolean variables, handling cancelled test runs, cleaning up lint skips, and enhancing local test documentation

Bug Fixes:

• Ensure the citest bad comment workflow detects cancelled runs in addition to failures

Enhancements:

• Upgrade tox-lsr to version 3.11.1 across multiple CI workflows
• Pass the __bootc_validation flag as a YAML boolean in qemu integration tests
• Remove unnecessary ansible-lint skips

Documentation:

• Add a detailed guide to contributing.md for running CI tests locally with tox-lsr and qemu

[sourcery-ai]

Reviewer's Guide

This PR refines the CI testing setup by passing the __bootc_validation flag as a YAML boolean, upgrading tox-lsr to 3.11.1 across workflows, broadening cancellation detection in the citest bad workflow, and enriching the contributing guide with local CI test instructions.

Sequence diagram for citest bad workflow handling cancelled and failed runs

sequenceDiagram
  participant "GitHub Actions Workflow"
  participant "GitHub API"
  participant "Test Farm (TF)"

  "GitHub Actions Workflow"->>"GitHub API": Query workflow runs for PR title
  "GitHub API"-->>"GitHub Actions Workflow": Return runs with conclusion (failure or cancelled)
  "GitHub Actions Workflow"->>"Test Farm (TF)": Process failed or cancelled run
  "Test Farm (TF)"-->>"GitHub Actions Workflow": Return status

Loading

File-Level Changes

Change	Details	Files
Switch to YAML boolean for __bootc_validation in CI runs	Changed extra-vars flag format to use "__bootc_validation: true" Ensured the boolean is quoted for correct YAML parsing	.github/workflows/qemu-kvm-integration-tests.yml
Bump tox-lsr to version 3.11.1 across CI workflows	Updated pip install URLs to reference [email protected] Replaced all occurrences of version 3.11.0 with 3.11.1	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Enhance citest bad workflow to handle cancelled runs	Extended jq filter to include tests with conclusion "cancelled" Added a comment noting TF tests can be cancelled	.github/workflows/tft_citest_bad.yml
Expand local CI testing instructions in contributing guide	Added a new section on installing and using tox-lsr with QEMU Provided step-by-step commands for setting up inventory and running qemu-ansible-core	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}