fix: cannot use community-general version 12 - no py27 and py36 support

[richm]

community.general version 12 has dropped support for py27 and py36 - ensure that
the roles do not install/use this version - see
ansible-collections/community.general#582

By default, installation will get the latest 11.x version. The lower bound
6.6.0 is an older version, but I don't want to restrict the ability of a user
of a particular role to use an old version, rather than forcing them to use
11.x or later. Some roles like rhc explicitly require 6.6.0 or later - I
think this is a reasonable lower bound for all roles.If a role needs a different
version, the role can define its own community_general_version in the role's
host_vars file in .github.

Standardize file format across all roles for consistency and ease of updating

This update may remove the SPDX license information from the file - this is ok -
the role/project already has a license, this file is trivial, and many
requirements files do not have the license header anyway.

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Pin community.general to versions >=6.6.0 and <12 to retain Python 2.7/3.6 support, and standardize the format of collection requirements files across all roles.

Bug Fixes:

• Restrict community.general to <12 to avoid installing a version that drops py27 and py36 support

Enhancements:

• Set the lower bound of community.general to 6.6.0 to maintain backward compatibility without enforcing a specific x-version
• Unify the structure of meta/collection-requirements.yml files by using explicit name fields and adding a managed-by header
• Remove SPDX license headers from trivial requirements files for consistency with common practice

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Restricts community.general to versions >=6.6.0 and <12 to preserve Python 2.7/3.6 compatibility, and enforces a uniform meta/collection-requirements.yml format across roles by adding a managed-by header, explicit name fields, and removing SPDX license headers.

Class diagram for updated collection-requirements.yml structure

classDiagram
    class CollectionRequirementFile {
        +managed_by : string
        +collections : Collection[]
    }
    class Collection {
        +name : string
    }
    CollectionRequirementFile "1" -- "*" Collection : contains

Loading

Flow diagram for standardized collection-requirements.yml format

flowchart TD
    A["Start: Update collection-requirements.yml"] --> B["Add managed-by header"]
    B --> C["Use explicit 'name' fields for collections"]
    C --> D["Remove SPDX license header"]
    D --> E["Result: Standardized requirements file"]

Loading

File-Level Changes

Change	Details	Files
Pin community.general between 6.6.0 and 12 to maintain legacy Python support	Set version specifier >=6.6.0,<12 in collection requirements Ensure roles default to latest 11.x unless overridden	meta/collection-requirements.yml
Standardize collection-requirements.yml structure across roles	Insert a ‘DO NOT EDIT’ managed-by header Convert collection list items into name-mappings Remove SPDX license headers from trivial requirement files	meta/collection-requirements.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}