tests: adjust UUID checks to newer versions of insights-core#220
Merged
richm merged 1 commit intolinux-system-roles:mainfrom Feb 26, 2025
Merged
Conversation
Starting from version 3.4.6 [1], insights-core (used internally by insights-client) adjusted its logic to generate the UUID (written in the /etc/insights-client/machine-id file): instead of a new random UUID, it uses the subscription-manager UUID in case the system is registered with it (which now is the only supported option). The expectations in tests_insights_client_register were that, unregistering and registering again with insights-client would give a new UUID, which are no more true now. Thus adjust the checks to either check for the old behaviour, or check that the UUID is now the same as the rhsm UUID. This is only a fix for the test, the behaviour of the role itself is correct. [1] RedHatInsights/insights-core#4057 Signed-off-by: Pino Toscano <ptoscano@redhat.com>
Collaborator
Author
|
[citest] |
spetrosi
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from version 3.4.6 [1], insights-core (used internally by
insights-client) adjusted its logic to generate the UUID (written in the/etc/insights-client/machine-idfile): instead of a new random UUID, it uses thesubscription-managerUUID in case the system is registered with it (which now is the only supported option).The expectations in tests_insights_client_register were that, unregistering and registering again with
insights-clientwould give a new UUID, which are no more true now. Thus adjust the checks to either check for the old behaviour, or check that the UUID is now the same as the rhsm UUID.This is only a fix for the test, the behaviour of the role itself is correct.
[1] RedHatInsights/insights-core#4057