ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]#156
Merged
ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]#156
Conversation
…s them [citest_skip] tox-lsr 3.17.1 has a fix for the broken container tests There was one shell function for both setting up the callback plugins and the connection plugin. When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not set, so all subsequent tests failed. The connection plugin must be present and the env. var. must be set in order to run any container tests. The code was fixed to ensure that there is always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS is always set and contains this path. Also, setting up the callback plugins and the connection plugin is already idempotent, so no reason to skip them. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates GitHub Actions workflows to use tox-lsr 3.17.1 (which fixes broken container tests) and simplifies test execution by no longer skipping callback/connection plugin setup between test runs in the qemu-kvm integration workflow. Sequence diagram for CI container tests with tox_lsr_3_17_1 ensuring connection_plugin setupsequenceDiagram
participant GA as GitHubActions
participant W as qemu_kvm_integration_workflow
participant T as tox
participant L as tox_lsr_3_17_1
participant A as Ansible
participant CP as ConnectionPlugin
participant E as Env_ANSIBLE_CONNECTION_PLUGINS
participant C as ContainerTests
GA->>W: Trigger workflow run
W->>T: Invoke tox environment
T->>L: Load tox_lsr configuration
alt previous_version_3_17_0
L->>L: Decide to skip plugin_setup in some cases
L-->>E: ANSIBLE_CONNECTION_PLUGINS not set
L-->>CP: Connection plugin may not be installed
L->>A: Run container tests
A->>C: Execute tests
C-->>A: Fail due to missing connection plugin
else fixed_version_3_17_1
L->>L: Always run plugin_setup (idempotent)
L->>CP: Ensure connection plugin installed
L->>E: Set ANSIBLE_CONNECTION_PLUGINS with plugin path
L->>A: Run container tests
A->>C: Execute tests
C-->>A: Tests run successfully using connection plugin
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The tox-lsr version is hardcoded in multiple workflows; consider centralizing it (e.g., in a reusable workflow or using a workflow/env variable) so it only needs to be updated in one place next time.
- Since SKIP_CALLBACK_PLUGINS is no longer exported in qemu-kvm-integration-tests.yml, double-check there are no remaining references to this variable in tox/env scripts or other workflows to avoid dead configuration paths.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The tox-lsr version is hardcoded in multiple workflows; consider centralizing it (e.g., in a reusable workflow or using a workflow/env variable) so it only needs to be updated in one place next time.
- Since SKIP_CALLBACK_PLUGINS is no longer exported in qemu-kvm-integration-tests.yml, double-check there are no remaining references to this variable in tox/env scripts or other workflows to avoid dead configuration paths.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tox-lsr 3.17.1 has a fix for the broken container tests
There was one shell function for both setting up the callback plugins and the connection plugin.
When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not
set, so all subsequent tests failed. The connection plugin must be present and the env. var.
must be set in order to run any container tests. The code was fixed to ensure that there is
always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS
is always set and contains this path.
Also, setting up the callback plugins and the connection plugin is already idempotent, so no
reason to skip them.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Update CI workflows to use tox-lsr 3.17.1 and adjust container test setup flags to restore container test execution.
Bug Fixes:
CI: