Skip to content

Commit 1c92228

Browse files
committed
remove include_vars, use public: true to export role vars, defaults
The tests_deps.yml test was using include_vars assuming the symlink roles/linux-system-roles.storage was present. This is deprecated. The test was doing this in order to get the defaults and vars from the role. The better way to do this is to use `include_role` with the `public: true` parameter so that the role will expose its private variables to the play.
1 parent 744be83 commit 1c92228

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

tests/run_blivet.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
---
2-
- include_vars:
3-
file: roles/linux-system-roles.storage/defaults/main.yml
4-
52
- name: test lvm and xfs package deps
63
blivet:
74
packages_only: "{{ packages_only }}"

tests/tests_deps.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
tasks:
66
- include_role:
77
name: linux-system-roles.storage
8+
public: true
89

910
- name: test lvm and xfs package deps
1011
include_tasks: run_blivet.yml

0 commit comments

Comments
 (0)