Install packages according to package_facts module and ansible_facts.packages

Update the installation task conditionals to check whether the current package is already a subset of rpm packages installed in the hosts machine. This way, we don't need to track a list of packages we've installed on the playbook run thus far.

Author: timflannagan

defaults/main.yml

@@ -3,8 +3,6 @@
 storage_backend: "default"
 pool_layers: ["pool-partitions", "vg"]  # md, luks, vdo under vg
 volume_layers: ["partition", "lv", "fs", "mount"]  # luks under fs
-storage_packages: []
-
 use_partitions: false
 disklabel_type: gpt
 

tasks/fs-default.yml

@@ -2,32 +2,34 @@
 - name: Stat the final device file
   include_tasks: stat_device.yml
 
-- block:
-  - name: Install xfsprogs for xfs file system type
-    package:
-      name: xfsprogs
-      state: present
-  - set_fact:
-      storage_packages: "{{ storage_packages + ['xfsprogs'] }}"
-  when: "'xfsprogs' not in storage_packages and volume.fs_type == 'xfs' and not ansible_check_mode"
+- name: Install xfsprogs for xfs file system type
+  package:
+    name: xfsprogs
+    state: present
+  register: xfsprogs_installed
+  when: "volume.fs_type == 'xfs' and ['xfsprogs'] is not subset(ansible_facts.packages.keys()) \
+         and xfsprogs_installed is undefined and not ansible_check_mode \
+         and (pool.state in 'present' and volume.state in 'present')"
 
-- block:
-  - name: Install e2fsprogs for ext file system type
-    package:
-      name: e2fsprogs
-      state: present
-  - set_fact:
-      storage_packages: "{{ storage_packages + ['e2fsprogs'] }}"
-  when: "'e2fsprogs' not in storage_packages and volume.fs_type in ['ext2', 'ext3', 'ext4'] and not ansible_check_mode"
+- name: Install e2fsprogs for ext file system type
+  package:
+    name: e2fsprogs
+    state: present
+  register: e2fsprogs_installed
+  when: "volume.fs_type in ['ext2', 'ext3', 'ext4'] and \
+         ['e2fsprogs'] is not subset(ansible_facts.packages.keys()) and \
+         e2fsprogs_installed is undefined and not ansible_check_mode \
+         and (pool.state in 'present' and volume.state in 'present')"
 
-- block:
-  - name: Install util-linux as needed
-    package:
-      name: util-linux
-      state: present
-  - set_fact:
-      storage_packages: "{{ storage_packages + ['util-linux'] }}"
-  when: "'util-linux' not in storage_packages and (volume.fs_type == 'swap' or volume.state == 'absent' or (pool.state is defined and pool.state == 'absent')) and not ansible_check_mode"
+- name: Install util-linux as needed
+  package:
+    name: util-linux
+    state: present
+  register: util_linux_installed
+  when: "(volume.fs_type == 'swap' or volume.state == 'absent' or \
+         (pool.state is defined and pool.state == 'absent')) and \
+         ['util-linux'] is not subset(ansible_facts.packages.keys()) and \
+         util_linux_installed is undefined and not ansible_check_mode"
 
 - name: unmount fs if we're going to reformat
   mount:

tasks/lv-default.yml

@@ -1,12 +1,16 @@
 ---
 - block:
-  - name: Install LVM2 commands as needed
-    package:
-      name: lvm2
-      state: present
-  - set_fact:
-      storage_packages: "{{ storage_packages + ['lvm2'] }}"
-  when: "'lvm2' not in storage_packages and volume.type == 'lvm' and not ansible_check_mode"
+    - name: Install LVM2 commands as needed
+      package:
+        name: lvm2
+        state: present
+    - name: Run the setup module to use ansible_facts.lvm
+      setup:
+    - name: Ensure the setup module runs above by setting a flag that lvm was installed
+      set_fact:
+        lvm_installed: true
+  when: "volume.type == 'lvm' and (['lvm2'] is not subset(ansible_facts.packages.keys()) and \
+         lvm_installed is undefined) and not ansible_check_mode"
 
 - name: Make sure LV exists
   lvol:

tasks/main.yml

@@ -1,4 +1,7 @@
 ---
+- name: get a list of rpm packages installed on host machine
+  package_facts:
+    manager: "auto"
 
 - name: manage pools
   include_tasks: pool-{{ storage_backend }}.yml

tasks/vg-default.yml

@@ -9,11 +9,13 @@
       package:
         name: lvm2
         state: present
-    - name: Update ansible_facts after installing lvm2
+    - name: Run the setup module to use ansible_facts.lvm
       setup:
-    - set_fact:
-        storage_packages: "{{ storage_packages + ['lvm2'] }}"
-  when: "'lvm2' not in storage_packages and pool.type == 'lvm' and not ansible_check_mode"
+    - name: Ensure the setup module runs above by setting a flag that lvm was installed
+      set_fact:
+        lvm_installed: true
+  when: "pool.type == 'lvm' and (['lvm2'] is not subset(ansible_facts.packages.keys()) and \
+        lvm_installed is undefined) and not ansible_check_mode"
 
 - block:
     - name: collect list of current pvs
@@ -50,7 +52,8 @@
 - name: Set pvs from current vg
   set_fact:
     pool: "{{ pool|combine({'_orig_members': pvs_cmd.stdout.split()}) }}"
-  when: pool.type == "lvm" and ansible_facts.lvm is defined and pool.name in ansible_facts.lvm.vgs and not pvs_cmd.failed and not ansible_check_mode
+  when: "pool.type == 'lvm' and ansible_facts.lvm is defined and pool.name in \
+        ansible_facts.lvm.vgs and not pvs_cmd.failed and not ansible_check_mode"
 
 #
 # Configure the VG