fix: there is no kmod-kvdo on EL10 and later

Cause: The blivet module adds `kmod-kvdo` as a required package on
platforms that do not have the pacakge.

Consequence: The package fails to be installed on EL10 and causes
the role to fail with an error.

Fix: Ensure `kmod-kvdo` is not added as a required package on EL10.

Result: The storage role does not give an error when using VDO
on EL10 and later.

Signed-off-by: Rich Megginson <[email protected]>

Author: richm

library/blivet.py

@@ -309,6 +309,11 @@
               when creating a disk volume (that is, a whole disk filesystem)
         type: dict
         default: {}
+    uses_kmod_kvdo:
+        description:
+            - bool - set if platform uses_kmod_kvdo
+        type: bool
+        default: false
 author:
     - David Lehman (@dwlehman)
 '''
@@ -604,7 +609,9 @@ def required_packages(self):
         if self._volume.get('encryption'):
             packages.extend(get_format('luks').packages)
         if self._volume.get('compression') or self._volume.get('deduplication'):
-            packages.extend(['vdo', 'kmod-kvdo'])
+            packages.append('vdo')
+            if uses_kmod_kvdo:
+                packages.append('kmod-kvdo')
         return packages
 
     @property
@@ -2376,7 +2383,9 @@ def run_module():
         pool_defaults=dict(type='dict', required=False),
         volume_defaults=dict(type='dict', required=False),
         use_partitions=dict(type='bool', required=False),
-        diskvolume_mkfs_option_map=dict(type='dict', required=False, default={}))
+        diskvolume_mkfs_option_map=dict(type='dict', required=False, default={}),
+        uses_kmod_kvdo=dict(type='bool', required=False, default=False),
+    )
 
     # comment this out if not generating module docs
     # mod_arg_str = generate_module_doc(module_args)
@@ -2434,6 +2443,9 @@ def run_module():
     if 'volume_defaults' in module.params:
         volume_defaults = module.params['volume_defaults']
 
+    global uses_kmod_kvdo
+    uses_kmod_kvdo = module.params['uses_kmod_kvdo']
+
     b = Blivet()
     b.reset()
     fstab = FSTab(b)

tasks/main-blivet.yml

@@ -27,6 +27,7 @@
     pool_defaults: "{{ storage_pool_defaults }}"
     volume_defaults: "{{ storage_volume_defaults }}"
     packages_only: true
+    uses_kmod_kvdo: "{{ __storage_uses_kmod_kvdo }}"
   register: package_info
   when: storage_skip_checks is not defined or
         not "packages_installed" in storage_skip_checks
@@ -93,6 +94,7 @@
         # yamllint disable-line rule:line-length
         diskvolume_mkfs_option_map: "{{ __storage_blivet_diskvolume_mkfs_option_map | d(omit) }}"
         # yamllint enable rule:line-length
+        uses_kmod_kvdo: "{{ __storage_uses_kmod_kvdo }}"
       register: blivet_output
 
     - name: Workaround for udev issue on some platforms

tests/tests_create_lvmvdo_then_remove.yml

@@ -21,9 +21,6 @@
       set_fact:
         storage_skip_checks:
           - blivet_available
-          - "{{ (lookup('env',
-                        'SYSTEM_ROLES_REMOVE_CLOUD_INIT') in ['', 'false']) |
-                ternary('packages_installed', '') }}"
           - service_facts
 
     - name: Gather package facts

vars/main.yml

@@ -13,6 +13,10 @@ __storage_required_facts:
 __storage_required_facts_subsets: "{{ ['!all', '!min'] +
   __storage_required_facts }}"
 
+# Set flag for blivet to know if there is a kmod-kvdo package
+__storage_uses_kmod_kvdo: "{{ __storage_is_rh_distro and
+  ansible_facts['distribution_major_version'] | int < 10 }}"
+
 # BEGIN - DO NOT EDIT THIS BLOCK - rh distros variables
 # Ansible distribution identifiers that the role treats like RHEL
 __storage_rh_distros: