Skip to content

Commit decc513

Browse files
committed
fix: add support for EL10
According to the Ansible team, support for listing platforms in role `meta/main.yml` files is being removed. Instead, they recommend using `galaxy_tags` https://github.com/ansible/ansible/blob/stable-2.17/changelogs/CHANGELOG-v2.17.rst "Remove the galaxy_info field platforms from the role templates" ansible/ansible#82453 Many roles already have tags such as "rhel", "redhat", "centos", and "fedora". I propose that we ensure all of the system roles have these tags. Some of our roles support Suse, Debian, Ubuntu, and others. We should add tags for those e.g. the ssh role already has tags for "debian" and "ubuntu". In addition - for each version listed under `platforms.EL` - add a tag like `elN`. Q: Why not use a delimiter between the platform and the version e.g. `el-10`? This is not allowed by ansible-lint: ``` meta-no-tags: Tags must contain lowercase letters and digits only., invalid: 'el-10' meta/main.yml:1 ``` So we cannot use uppercase letters either. Q: Why not use our own meta/main.yml field? No other fields are allowed by ansible-lint: ``` syntax-check[specific]: 'myfield' is not a valid attribute for a RoleMetadata ``` Q: Why not use some other field? There are no other applicable or suitable fields. Q: What happens when we want to support versions like `N.M`? Use the word "dot" instead of "." e.g. `el10dot3`. Similarly - use "dash" instead of "-". We do not need tags such as `fedoraall`. The `fedora` tag implies that the role works on all supported versions of fedora. Otherwise, use tags such as `fedora40` if the role only supports specific versions. In addition - for roles that have different variable files for EL9, create the corresponding EL10 files. Signed-off-by: Rich Megginson <[email protected]>
1 parent e551220 commit decc513

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

meta/main.yml

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,6 @@
33
galaxy_info:
44
author: Michal Sekletar <[email protected]>
55
description: Deploy and control systemd units
6-
galaxy_tags:
7-
- system
8-
- systemd
9-
- service
10-
- rhel
11-
- fedora
12-
- centos
136
company: Red Hat, Inc.
147
license: MIT
158
min_ansible_version: "2.9"
@@ -22,5 +15,15 @@ galaxy_info:
2215
- "7"
2316
- "8"
2417
- "9"
25-
18+
galaxy_tags:
19+
- centos
20+
- el7
21+
- el8
22+
- el9
23+
- el10
24+
- fedora
25+
- rhel
26+
- service
27+
- system
28+
- systemd
2629
allow_duplicates: true

0 commit comments

Comments
 (0)