ci: tox-lsr 3.16.0 - fix qemu tox test failures - rename to qemu-ansible-core-X-Y [citest_skip]

[richm]

the latest version of tox 4.49 has a strange issue - it thinks that a tox testenv
like [qemu-ansible-core-2.20] is specifying python 2.20 which conflicts with the
testenv basepython of python 3.latest. There appears to be no way to workaround this.

So, rename all of the testenvs to use major-minor instead of major.minor e.g.
[qemu-ansible-core-2-20]

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI tox-lsr version and align qemu/container tox environment names with the new ansible-core naming convention.

CI:

• Bump tox-lsr used in all GitHub Actions workflows from 3.15.0 to 3.16.0 and adjust qemu/container matrix env names from major.minor to major-minor to avoid tox 4 Python version parsing issues.

Documentation:

• Update contributing guide qemu tox example to use the new qemu-ansible-core-2-20 env name.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI tox-lsr dependency to 3.16.0 and renames QEMU/container tox environments from dot-based ansible-core versions (e.g. 2.16) to dash-based variants (e.g. 2-16) to avoid tox 4.49 misinterpreting them as Python versions, including aligning documentation with the new names.

File-Level Changes

Change	Details	Files
Rename QEMU and container tox environment names from dot to dash version format to avoid tox 4.49 Python version parsing issues.	Update qemu-ansible-core-* matrix env values from major.minor to major-minor format in the qemu-kvm integration workflow. Update container-ansible-core-* matrix env values from major.minor to major-minor format, including commented-out entries, in the qemu-kvm integration workflow. Adjust the example tox invocation in contributing documentation to use the new qemu-ansible-core-2-20 environment name.	.github/workflows/qemu-kvm-integration-tests.yml contributing.md
Bump tox-lsr dependency from 3.15.0 to 3.16.0 across CI workflows to pick up the new qemu env naming support.	Update tox-lsr version in qemu-kvm integration workflow install step. Update tox-lsr version in ansible-lint workflow. Update tox-lsr version in ansible-managed-var-comment workflow. Update tox-lsr version in ansible-test workflow. Update tox-lsr version in python-unit-test workflow.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml .github/workflows/python-unit-test.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The example in contributing.md now references qemu-ansible-core-2-20, but the workflow matrix only defines up to 2-19; consider updating the example to use an environment that actually exists (or adding 2-20 consistently across tox and CI).
• Since the tox environment names changed from major.minor to major-minor, double-check that all other references (e.g., in tox.ini or helper scripts) have been updated to avoid mismatched env names at runtime.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The example in `contributing.md` now references `qemu-ansible-core-2-20`, but the workflow matrix only defines up to 2-19; consider updating the example to use an environment that actually exists (or adding 2-20 consistently across tox and CI).
- Since the tox environment names changed from `major.minor` to `major-minor`, double-check that all other references (e.g., in `tox.ini` or helper scripts) have been updated to avoid mismatched env names at runtime.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}