Check for undefined variable. See #450 (#451)

henry2cox · web-flow · commit fa6c2108be04 · 2026-01-08T09:53:38.000-05:00
Signed-off-by: Henry Cox &lt;henry.cox@mediatek.com&gt;
diff --git a/bin/geninfo b/bin/geninfo
@@ -338,7 +338,7 @@ if (0 == scalar(@gcov_tool)) {
     } elsif (!file_name_is_absolute($tool)) {
         $tool = abs_path($tool);
     }
-    if (!-x $tool) {
+    unless (defined($tool) && -x $tool) {
         die("cannot access gcov tool '$gcov_tool[0]'");
     }
     $gcov_tool[0] = $tool;

Original file line number	Diff line number	Diff line change
`@@ -338,7 +338,7 @@ if (0 == scalar(@gcov_tool)) {`
`338`	`338`	`} elsif (!file_name_is_absolute($tool)) {`
`339`	`339`	`$tool = abs_path($tool);`
`340`	`340`	`}`
`341`		`- if (!-x $tool) {`
	`341`	`+ unless (defined($tool) && -x $tool) {`
`342`	`342`	`die("cannot access gcov tool '$gcov_tool[0]'");`
`343`	`343`	`}`
`344`	`344`	`$gcov_tool[0] = $tool;`