Simplify IOBuffer API

Removed flush() method since it wasn't offering any solution.

Signed-off-by: Andrea Cervesato <[email protected]>

Author: acerv

ltp/dispatcher.py

@@ -198,9 +198,6 @@ def write(self, data: str) -> None:
 
         self.stdout += data
 
-    def flush(self) -> None:
-        pass
-
 
 class RedirectStdout(IOBuffer):
     """
@@ -216,9 +213,6 @@ def write(self, data: str) -> None:
 
         ltp.events.fire("sut_stdout_line", self._sut.name, data)
 
-    def flush(self) -> None:
-        pass
-
 
 class SerialDispatcher(Dispatcher):
     """

ltp/host.py

@@ -137,7 +137,6 @@ def _read_stdout(
         # write on stdout buffers
         if iobuffer:
             iobuffer.write(rdata)
-            iobuffer.flush()
 
         return rdata
 

ltp/qemu.py

@@ -233,7 +233,6 @@ def _read_stdout(self, size: int, iobuffer: IOBuffer) -> str:
         # write on stdout buffers
         if iobuffer:
             iobuffer.write(rdata)
-            iobuffer.flush()
 
         return rdata
 

ltp/session.py

@@ -40,9 +40,6 @@ def write(self, data: str) -> None:
         else:
             ltp.events.fire("sut_stdout_line", self._sut.name, data)
 
-    def flush(self) -> None:
-        pass
-
 
 class Session:
     """

ltp/ssh.py

@@ -238,7 +238,6 @@ def _reset(self, timeout: float = 30, iobuffer: IOBuffer = None) -> None:
                                 errors="ignore")
 
                             iobuffer.write(rdata)
-                            iobuffer.flush()
 
                     if proc.poll() is not None:
                         break
@@ -345,7 +344,6 @@ def run_command(
                     stdout_str += line
                     if iobuffer:
                         iobuffer.write(line)
-                        iobuffer.flush()
 
                 t_end = time.time() - t_start
 

ltp/sut.py

@@ -38,12 +38,6 @@ def write(self, data: str) -> None:
         """
         raise NotImplementedError()
 
-    def flush(self) -> None:
-        """
-        Flush data.
-        """
-        raise NotImplementedError()
-
 
 TAINTED_MSG = [
     "proprietary module was loaded",

ltp/tests/sut.py

@@ -24,9 +24,6 @@ def __init__(self) -> None:
     def write(self, data: str) -> None:
         print(data, end="")
 
-    def flush(self):
-        pass
-
 
 @pytest.fixture
 def sut():

ltp/tests/test_host.py

@@ -118,9 +118,6 @@ class MyBuffer(IOBuffer):
             def write(self, _: str) -> None:
                 self.executed.append(1)
 
-            def flush(self) -> None:
-                pass
-
         buffer = MyBuffer()
         results = []
         cpu_count = os.cpu_count()

ltp/tests/test_ssh.py

@@ -85,9 +85,6 @@ def write(self, data: str) -> None:
                 # wait for data inside the buffer
                 time.sleep(0.1)
 
-            def flush(self) -> None:
-                return
-
         buffer = MyBuffer()
         sut.stop(timeout=1, iobuffer=buffer)